Re: gdb: FTBFS on hurd-i386 (for review)

2012-09-28 Thread Samuel Thibault
Thomas Schwinge, le Thu 27 Sep 2012 09:15:23 +0200, a écrit : $ gcc -dM -E -x c - /dev/null | grep -i mach #define __MACH 1 #define __MACH__ 1 #define MACH 1 On Linux i386, both linux and i386 macros are defined, which poses its own problems too. I'd indeed tend to say that

[PATCH,HURD] mknod: allow to create also sockets

2012-09-28 Thread Pino Toscano
Hi, attached there is a small patch to allow Hurd's mknod(at) to create also sockets; while POSIX does not specify them, on Linux they seem to be supported, and the implementation is very small. I also took the liberty of simplifying the checks done to decide whether use the device number

Re: [PATCH,HURD] mknod: allow to create also sockets

2012-09-28 Thread Pino Toscano
Alle venerdì 28 settembre 2012, Roland McGrath ha scritto: What's the point of ever creating a local-domain socket node with mknod? To be honest, I was making tst-mknodat.c pass on Hurd; if it does not make sense that mknod can create sockets, then that test should be removed, since all it

Re: [PATCH,HURD] mknod: allow to create also sockets

2012-09-28 Thread Roland McGrath
To be honest, I was making tst-mknodat.c pass on Hurd; if it does not make sense that mknod can create sockets, then that test should be removed, since all it does is testing the creation of a single socket. I think the intent of the change is to test the mknodat interface, not any

Re: [PATCH,HURD] mknod: allow to create also sockets

2012-09-28 Thread Pino Toscano
Alle venerdì 28 settembre 2012, Roland McGrath ha scritto: To be honest, I was making tst-mknodat.c pass on Hurd; if it does not make sense that mknod can create sockets, then that test should be removed, since all it does is testing the creation of a single socket. I think the intent

Re: [PATCH,HURD] mknod: allow to create also sockets

2012-09-28 Thread Roland McGrath
What's the point of ever creating a local-domain socket node with mknod? They are created on demand when you use bind.

Re: [PATCH,HURD] mknod: allow to create also sockets

2012-09-28 Thread Roland McGrath
That change looks fine if the test still passes on Linux.

Re: [PATCH,HURD] mknod: allow to create also sockets

2012-09-28 Thread Pino Toscano
Alle venerdì 28 settembre 2012, Roland McGrath ha scritto: That change looks fine if the test still passes on Linux. It does on Linux/x86_64, so I pushed it. Thanks for the reviews, -- Pino Toscano signature.asc Description: This is a digitally signed message part.