[PATCH] rpctrace: Don't allocate an unneeded structure

2016-11-02 Thread Brent Baccala
* utils/rpctrace.c (trace_and_forward): Don't allocate request structure 'req' unless we actually expect a reply --- utils/rpctrace.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/utils/rpctrace.c b/utils/rpctrace.c index 2664ffd..6086ab6 100644

Re: two more rpctrace patches

2016-11-02 Thread Brent W. Baccala
On Wed, Nov 2, 2016 at 2:26 PM, Kalle Olavi Niemitalo wrote: > > Look at how the commit messages in hurd.git at Savannah (not at > Debian) are formatted. "make dist" runs gitlog-to-changelog, > which generates a ChangeLog file from those. > OK, I think I see what you want.

Re: two more rpctrace patches

2016-11-02 Thread Kalle Olavi Niemitalo
"Brent W. Baccala" writes: > How do you submit changelog-style descriptions? They don't seem to be kept > in ChangeLog... Look at how the commit messages in hurd.git at Savannah (not at Debian) are formatted. "make dist" runs gitlog-to-changelog, which generates a ChangeLog file from those. (

Re: two more rpctrace patches

2016-11-02 Thread Brent W. Baccala
On Wed, Nov 2, 2016 at 3:10 AM, Justus Winter wrote: > > Cool. Two nitpicks: 1/ Instead of attaching patches, why don't you use > git send-email. That is easier for everyone. 2/ The summary line of > your patches is too long, try to keep it at ~60 chars or so, and we > require changelog-style

Re: two more rpctrace patches

2016-11-02 Thread Justus Winter
Hi! "Brent W. Baccala" writes: > I'm attaching two more patches to rpctrace that close bug 48863. Cool. Two nitpicks: 1/ Instead of attaching patches, why don't you use git send-email. That is easier for everyone. 2/ The summary line of your patches is too long, try to keep it at ~60 chars o

Re: spin gsync patch

2016-11-02 Thread Svante Signell
On Tue, 2016-11-01 at 16:20 +0100, Samuel Thibault wrote: > Svante Signell, on Tue 01 Nov 2016 16:19:19 +0100, wrote: > > > > I have now rebuilt gcc-2.24-6 without hurd-i386/tg-libpthread-gsync- > > spin.diff > > and do not experience any filesystem corruptions when sync is issued for the > > patc

Re: rpctrace man page

2016-11-02 Thread Brent W. Baccala
On Tue, Nov 1, 2016 at 5:15 AM, Samuel Thibault wrote: > > GNU projects usually don't have man pages, but info pages. The > doc/hurd.texi indeed doesn't have any part for rpctrace. It should :) > > What an embarrassing *faux pas*! It's like fumbling to put the Metro card in the turnstile, like

two more rpctrace patches

2016-11-02 Thread Brent W. Baccala
Aloha - I'm attaching two more patches to rpctrace that close bug 48863. agape brent From 10a2a49e370ca55b6cea4cdc4a54ae106b243817 Mon Sep 17 00:00:00 2001 From: Brent Baccala Date: Tue, 1 Nov 2016 01:07:52 -1000 Subject: [PATCH 1/2] rpctrace: don't wrap send-once rights sent to the task