Re: [PATCH] LwIP translator

2017-09-26 Thread Samuel Thibault
Samuel Thibault, on mer. 27 sept. 2017 00:44:15 +0200, wrote: > Last but not least, did you try to run the glibc testsuite while running > this TCP/IP stack? It would probably find potential bugs. Also, the > perl testsuite is probably a nice thing to run. (I'm not saying I won't commit this

Re: [PATCH] LwIP translator

2017-09-26 Thread Samuel Thibault
Hello, Joan Lledó, on mer. 06 sept. 2017 10:09:36 +0200, wrote: > --- /dev/null > +++ b/lwip/iioctl-ops.c > +/* Get the interface from its name */ > +static struct netif * > +get_if (char *name) ... > + > + netif = netif_list; > + while (netif != 0) > +{ > + if (strcmp

Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?

2017-09-26 Thread Samuel Thibault
Hello, This time it looks correct :) (just a couple of nitpicks which I'll just fix). Samuel

Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?

2017-09-26 Thread Svante Signell
On Tue, 2017-09-26 at 16:24 +0200, Samuel Thibault wrote: > That should be “filename” instead of “file”. Yes of course. That was merely a copy/paste error. Thanks for finding it. > Take the case of PATH containing e.g. :bin: , and your current directory > contains a bin directory which contains

Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?

2017-09-26 Thread Samuel Thibault
Svante Signell, on mar. 26 sept. 2017 16:15:06 +0200, wrote: > + /* Relative path */ > + else > + { > + cwd = getcwd (NULL, 0); > + if (cwd == NULL) > + goto out; > + > + res = asprintf (_name, "%s/%s", cwd, file); That should be

Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?

2017-09-26 Thread Svante Signell
On Mon, 2017-09-25 at 18:01 +0200, Samuel Thibault wrote: > Svante Signell, on lun. 25 sept. 2017 17:51:52 +0200, wrote: > > The following tests still reveal unwanted behaviour: (where to change ?) These two tests are now OK. > It's in the PATH lookup case, just below where you added your code.