[PATCH] acpi: Fix brokenness

2021-03-07 Thread Damien Zammit
Fix count and size --- acpi/netfs_impl.c | 41 + 1 file changed, 29 insertions(+), 12 deletions(-) diff --git a/acpi/netfs_impl.c b/acpi/netfs_impl.c index 84f52c89..d9853a08 100644 --- a/acpi/netfs_impl.c +++ b/acpi/netfs_impl.c @@ -58,25 +58,26 @@ get_di

Re: [PATCH: hurd x6]

2021-03-07 Thread Damien Zammit
On 7/3/21 9:25 pm, Samuel Thibault wrote: > Damien Zammit, le dim. 07 mars 2021 17:39:04 +1100, a ecrit: >> [PATCH 3/6] libnetfs: Hacks to allow pci to run with no cred >> >> This is still needed to bypass the cred uid=0. >> I tried to call fsys_getroot, but it failed/hung when running it >> at the

[PATCH 2/2] pci-arbiter: Introduce machdev into this server

2021-03-07 Thread Damien Zammit
* pci-arbiter/Makefile Add machdev lib and simplify * pci-arbiter/main.c (pci_device_{open,close,shutdown}): New methods (netfs_server_func): Thread the demuxer loop (pcifs_startup): Custom startup method (main): Use machdev for server and detach worker threads * pci-arbiter/options.{c,h} Add disk-

[PATCH hurd x2] - Rebased

2021-03-07 Thread Damien Zammit
[PATCH 1/2] pci-arbiter: Fix brokenness This patch does not include mustbedir option because I believe there is already logic that detects if it is looking up a directory, by checking the entry->dir != 0. When I tried adding it in, it did not work correctly. [PATCH 2/2] pci-arbiter: Introduce ma

[PATCH 1/2] pci-arbiter: Fix brokenness

2021-03-07 Thread Damien Zammit
* pci-arbiter/netfs_impl.c (get_dirents): Fix count and size detection (netfs_attempt_lookup): Strip trailing slashes and leading dot slashes * pci-arbiter/pci-ops.c (check_permissions): Use the overridable method instead --- pci-arbiter/netfs_impl.c | 41

Re: pci arbiter being killed

2021-03-07 Thread Joan Lledó
Hi El 7/3/21 a les 20:33, Samuel Thibault ha escrit: Joan Lledó, le dim. 07 mars 2021 20:08:21 +0100, a ecrit: is not there any process that kills the arbiter after a while of not being used? That shouldn't be happening. and how could I know who is sending the SIGKILL? How do you notice t

Re: pci arbiter being killed

2021-03-07 Thread Samuel Thibault
Joan Lledó, le dim. 07 mars 2021 20:08:21 +0100, a ecrit: > is not there any process that kills the arbiter after a while of not > being used? That shouldn't be happening. > and how could I know who is sending the SIGKILL? How do you notice that it's a SIGKILL? You could e.g. put mach_prints in

pci arbiter being killed

2021-03-07 Thread Joan Lledó
Hi Hurd, I've observed how my instance of the pci arbiter receives a SIGKILL about a minute after start, it could be my fault as I've being messing around with gnumach, libpciaccess and the arbiter itself, but just to confirm: is not there any process that kills the arbiter after a while of n

Re: [PATCH: hurd x6]

2021-03-07 Thread Samuel Thibault
Damien Zammit, le dim. 07 mars 2021 17:39:04 +1100, a ecrit: > [PATCH 3/6] libnetfs: Hacks to allow pci to run with no cred > > This is still needed to bypass the cred uid=0. > I tried to call fsys_getroot, but it failed/hung when running it > at the point where I needed the root port. Where is t

Re: [PATCH 2/6] pci-arbiter: Introduce machdev into this server

2021-03-07 Thread Samuel Thibault
This looks good! Could you write a commit log? Samuel Damien Zammit, le dim. 07 mars 2021 17:39:06 +1100, a ecrit: > --- > pci-arbiter/Makefile | 7 +- > pci-arbiter/main.c| 147 +++--- > pci-arbiter/options.c | 19 + > pci-arbiter/options

Re: [PATCH 1/6] pci-arbiter: Fix brokenness

2021-03-07 Thread Samuel Thibault
Damien Zammit, le dim. 07 mars 2021 17:39:05 +1100, a ecrit: > - if (max_entries < 0) > -count = dir->dir->num_entries; > + count = nentries - first_entry; > + if (max_entries > 0 && count > max_entries) > +count = max_entries; It was previously considering max_entries == 0 meaning rea