Re: [PATCH v11 0/2 hurd] Add irqhelp library and clean up ddekit

2024-03-24 Thread Damien Zammit
Hi, On 24 Mar 2024, 11:05 pm, Samuel Thibault < samuel.thiba...@gnu.org> wrote: > Ok, but there's not even a comment about it. If somebody else comes and > changes the code a bit, they'll very easily get to the unsafe side again. And > really, accessing local variables from nested functions is

Re: ntpdate : Depends: ntpsec-ntpdate but it is not installable

2024-03-24 Thread Jose Luis Alarcon Sanchez
On Sun, Mar 24, 2024 at 02:11:39PM +0100, Samuel Thibault wrote: > Hello, > > Jose Luis Alarcon Sanchez, le dim. 24 mars 2024 13:31:22 +0100, a ecrit: > > What's the situation with the package ntpsec-ntpdate?. Is there a fix > > possible?. I volunteer, if i am able. Waiting for instructions to

Re: ntpdate : Depends: ntpsec-ntpdate but it is not installable

2024-03-24 Thread Samuel Thibault
Hello, Jose Luis Alarcon Sanchez, le dim. 24 mars 2024 13:31:22 +0100, a ecrit: > What's the situation with the package ntpsec-ntpdate?. Is there a fix > possible?. I volunteer, if i am able. Waiting for instructions to follow. Fixing the build to at least support the step adjustment should be

ntpdate : Depends: ntpsec-ntpdate but it is not installable

2024-03-24 Thread Jose Luis Alarcon Sanchez
Hi. What's the situation with the package ntpsec-ntpdate?. Is there a fix possible?. I volunteer, if i am able. Waiting for instructions to follow. Thanks very much, in advance. Regards. Jose. -- https://lordofunix.org/ Not Registered GNU/Hurd User. Registered BSD User 51101. Registered Linux

Re: [PATCH v11 0/2 hurd] Add irqhelp library and clean up ddekit

2024-03-24 Thread Samuel Thibault
Damien Zammit, le dim. 24 mars 2024 11:40:27 +, a ecrit: > \ Original Message > On 24 Mar 2024, 9:32 pm, Samuel Thibault > >... Your version 11 is however still accessing the \`irq\` local parameter, > >so it's still only by luck that it's working. You need to restore

Re: [PATCH v11 0/2 hurd] Add irqhelp library and clean up ddekit

2024-03-24 Thread Damien Zammit
Hi Samuel, Original Message On 24 Mar 2024, 9:32 pm, Samuel Thibault >... Your version 11 is however still accessing the `irq` local parameter, so >it's still only by luck that it's working. You need to restore allocating the >params structure to store irq and priv, which was

Re: [PATCH v11 0/2 hurd] Add irqhelp library and clean up ddekit

2024-03-24 Thread Samuel Thibault
Damien Zammit, le dim. 24 mars 2024 10:08:30 +, a ecrit: > The previous problem was that calling a function with a global param > from inside the wrapped_server_loop was crashing netdde > due to a bogus stack offset. This is fixed. Ah, it's not a global param, but a local param. Passing a

[PATCH v11 2/2 hurd] ddekit: Use libirqhelp for interrupt registration

2024-03-24 Thread Damien Zammit
Use the new irqhelp library in ddekit and clean up. --- libddekit/Makefile| 2 +- libddekit/interrupt.c | 214 ++ 2 files changed, 31 insertions(+), 185 deletions(-) diff --git a/libddekit/Makefile b/libddekit/Makefile index 88a0c8909..c74ec1128

[PATCH v11 1/2 hurd] libirqhelp: Add library

2024-03-24 Thread Damien Zammit
Add a helper library for attaching interrupt handlers in userspace. --- Makefile | 1 + libirqhelp/Makefile | 28 libirqhelp/irqhelp.c | 358 +++ libirqhelp/irqhelp.h | 49 ++ 4 files changed, 436 insertions(+) create mode 100644

[PATCH v11 0/2 hurd] Add irqhelp library and clean up ddekit

2024-03-24 Thread Damien Zammit
Hi, This patchset adds a new library irqhelp for assisting the attachment of irq handlers in userspace. The previous problem was that calling a function with a global param from inside the wrapped_server_loop was crashing netdde due to a bogus stack offset. This is fixed. The mach_msg_server