Re: [PATCH libpciaccess] hurd: Clients or nested arbiters don't touch ioports

2022-08-27 Thread Samuel Thibault
Hello, Damien Zammit, le sam. 27 août 2022 04:34:20 +, a ecrit: > I don't understand how a client/nested arbiter could be currently using these > methods > successfully because the hurd access method would fail to enable io via > x86_enable_io(). In the Xorg case, it seems the server alread

Re: [PATCH libpciaccess] hurd: Clients or nested arbiters don't touch ioports

2022-08-26 Thread Damien Zammit
Hi Samuel, I don't understand how a client/nested arbiter could be currently using these methods successfully because the hurd access method would fail to enable io via x86_enable_io(). That is how we determine if we are a client not a master, by attempting to grab all io ports and getting rejec

Re: [PATCH libpciaccess] hurd: Clients or nested arbiters don't touch ioports

2022-08-24 Thread Samuel Thibault
Damien Zammit, le mar. 23 août 2022 08:36:56 +, a ecrit: > I tested this patch and linked it to both pci-arbiter.static > and rumpdisk.static, everything still works. Did you try Xorg? It uses pci_io_read32 & alike. > +.open_legacy_io = NULL, > +.close_io = NULL, > +.read32 = NULL

Re: [PATCH libpciaccess] hurd: Clients or nested arbiters don't touch ioports

2022-08-23 Thread Damien Zammit
Hi, On 23/8/22 10:23 pm, Joan Lledó wrote: > El 23/8/22 a les 10:36, Damien Zammit ha escrit: >> @@ -600,14 +599,14 @@ static const struct pci_system_methods >> hurd_pci_methods = { >> .read = pci_device_hurd_read, >> .write = pci_device_hurd_write, >> .fill_capabilities = pci_f

Re: [PATCH libpciaccess] hurd: Clients or nested arbiters don't touch ioports

2022-08-23 Thread Joan Lledó
Hi, El 23/8/22 a les 10:36, Damien Zammit ha escrit: @@ -600,14 +599,14 @@ static const struct pci_system_methods hurd_pci_methods = { .read = pci_device_hurd_read, .write = pci_device_hurd_write, .fill_capabilities = pci_fill_capabilities_generic, -.open_legacy_io = pci_d

[PATCH libpciaccess] hurd: Clients or nested arbiters don't touch ioports

2022-08-23 Thread Damien Zammit
I tested this patch and linked it to both pci-arbiter.static and rumpdisk.static, everything still works. I/O ports are not needed at all by nested arbiters/clients of master because we are not reserving them per device. This design may need to change if we want to be more fine-grained over i/o p