Re: [PATCH v2] libmachdev: Introduce startup notification for clean rumpdisk shutdown

2020-08-02 Thread Samuel Thibault
I applied, thanks! Just one thing: I moved the functions so as to get the code in the execution order: fsys_startup, then fsys_init, then arrange_shutdown_notification, and S_startup_dosync before trivfs_goaway. Samuel

Re: [PATCH v2] libmachdev: Introduce startup notification for clean rumpdisk shutdown

2020-08-02 Thread Samuel Thibault
Damien Zammit, le sam. 01 août 2020 15:05:38 +1000, a ecrit: > +static void > +device_shutdown (void) > +{ > + struct block_data *bd = block_head; > + > + while (bd) > +{ > + device_close((void *)bd); > + bd = bd->next; > +} > + rump_sys_reboot (0, NULL); > +} Did you check

Re: [PATCH v2] libmachdev: Introduce startup notification for clean rumpdisk shutdown

2020-08-02 Thread Samuel Thibault
Samuel Thibault, le dim. 02 août 2020 23:16:22 +0200, a ecrit: > Damien Zammit, le sam. 01 août 2020 15:09:57 +1000, a ecrit: > > I figured out why it was hanging on reboot: > > netdde was frozen because pci-arbiter was not working > > with my setup that used x86 method of pci access for rumpdisk.

Re: [PATCH v2] libmachdev: Introduce startup notification for clean rumpdisk shutdown

2020-08-02 Thread Samuel Thibault
Hello, Damien Zammit, le sam. 01 août 2020 15:09:57 +1000, a ecrit: > I figured out why it was hanging on reboot: > netdde was frozen because pci-arbiter was not working > with my setup that used x86 method of pci access for rumpdisk. > > When I removed the translators from /dev/netdde and

Re: [PATCH v2] libmachdev: Introduce startup notification for clean rumpdisk shutdown

2020-07-31 Thread Damien Zammit
Hi, I figured out why it was hanging on reboot: netdde was frozen because pci-arbiter was not working with my setup that used x86 method of pci access for rumpdisk. When I removed the translators from /dev/netdde and /servers/bus/pci, reboot-hurd rebooted cleanly with this patch. Damien

[PATCH v2] libmachdev: Introduce startup notification for clean rumpdisk shutdown

2020-07-31 Thread Damien Zammit
--- libmachdev/Makefile | 4 +- libmachdev/ds_routines.c | 10 +++ libmachdev/machdev-device_emul.h | 1 + libmachdev/machdev.h | 1 + libmachdev/trivfs_server.c | 116 ++- libmachdev/trivfs_server.h | 33 +