Re: [PATCH] pci-arbiter: Remove embedded pciaccess code

2019-11-09 Thread Almudena Garcia
Then, does Debian repositories includes all new PCI Arbitrer and libpciaccess0 updates? Samuel asked me to test the latest versions of netdde, libpciaccess0 and hurd, in my Thinkpad T60, but I don't know if I simply have to "apt full-upgrade", or I need to do a manual compilation from upstream El

Re: [PATCH] pci-arbiter: Remove embedded pciaccess code

2019-11-09 Thread Joan Lledó via Bug reports for the GNU Hurd
Hi, El 3/11/19 a les 21:48, Samuel Thibault ha escrit: > Hello, > > Uploaded fixed netdde, pciutils, libpciaccess, and commited this > pci-arbiter cleanup! > Great! Now I have some questions: - You said libpciaccess upstream code for the Hurd doesn't match the one in the Debian package.

Re: [PATCH] pci-arbiter: Remove embedded pciaccess code

2019-11-09 Thread Guillem Jover
Hi! [ BTW it seems like something on the gnu.org side is mandling UTF-8 characters? :/ ] On Sat, 2019-11-09 at 11:54:15 +0100, Samuel Thibault wrote: > Joan Lledó via Bug reports for the GNU Hurd, le sam. 09 nov. 2019 10:50:18 > +0100, a ecrit: > > And, about pciutils, what did you do? >

Re: [PATCH] pci-arbiter: Remove embedded pciaccess code

2019-11-09 Thread Samuel Thibault
Almudena Garcia, le sam. 09 nov. 2019 15:15:31 +0100, a ecrit: > but I don't know if I simply have to "apt full-upgrade", That's exactly it, no manual compilation needed. Just make sure to be getting upgrades from the "unreleased" distrib. Samuel

Re: [PATCH] pci-arbiter: Remove embedded pciaccess code

2019-11-09 Thread Almudena Garcia
> That's exactly it, no manual compilation needed. Just make sure to be > getting upgrades from the "unreleased" distrib. Thanks. This week I'll try to test It El sáb., 9 nov. 2019 a las 15:21, Samuel Thibault () escribió: > Almudena Garcia, le sam. 09 nov. 2019 15:15:31 +0100, a ecrit: > > but

Re: [PATCH] pci-arbiter: Remove spurious memset()

2019-11-09 Thread Samuel Thibault
Joan Lledó via Bug reports for the GNU Hurd, le sam. 09 nov. 2019 10:35:31 +0100, a ecrit: > From: Joan Lledó > > * pci-arbiter/pcifs.c: > * create_fs_tree: > Remove all memset() previous to snprintf() calls. Applied, thanks! > --- > pci-arbiter/pcifs.c | 4 > 1 file

Re: [PATCH] pci-arbiter: Remove embedded pciaccess code

2019-11-09 Thread Samuel Thibault
Concerning packages uploaded to the "unreleased" distribution, a repository if there was one would be on https://salsa.debian.org/hurd-team I however don't create one for each and very package I upload to "unreleased". Normally the patchs uploaded there are already submitted upstream or to a

Re: [PATCH] pci-arbiter: Remove embedded pciaccess code

2019-11-09 Thread Joan Lledó
Hi, Thanks for your explanations, Samuel. Then I'll take your changes on the libpciaccess patch, fix the closedir() issue and send it to upstream. I was also wondering if after your changes, libpciaccess would support nested arbiters, or if is that something we want at all. About pciutils, I've

[PATCH] pci-arbiter: Remove spurious memset()

2019-11-09 Thread Joan Lledó via Bug reports for the GNU Hurd
From: Joan Lledó * pci-arbiter/pcifs.c: * create_fs_tree: Remove all memset() previous to snprintf() calls. --- pci-arbiter/pcifs.c | 4 1 file changed, 4 deletions(-) diff --git a/pci-arbiter/pcifs.c b/pci-arbiter/pcifs.c index cc08fad0..aaee7f0b 100644 ---

Re: [PATCH 3/4] pci-arbiter: Fix a -Wstringop-truncation warning

2019-11-09 Thread Joan Lledó
Hi, El 3/11/19 a les 17:47, Samuel Thibault ha escrit: > The memset still seems spurious to me, isn't it? > Yes, I wrote it to ensure a '\0' was written at the end of the string, no matter its size. But if snprintf() already null terminates, then there's no need for the memset().

Re: [PATCH] pci-arbiter: Remove embedded pciaccess code

2019-11-09 Thread Joan Lledó via Bug reports for the GNU Hurd
El 9/11/19 a les 10:48, Joan Lledó via Bug reports for the GNU Hurd ha escrit: > Now I have some questions: > > - You said libpciaccess upstream code for the Hurd doesn't match the one > in the Debian package. Where is the debian repo for the package? I found > [1] but it doesn't seem to have

Re: [PATCH] pci-arbiter: Remove embedded pciaccess code

2019-11-09 Thread Samuel Thibault
Joan Lledó, le sam. 09 nov. 2019 17:36:19 +0100, a ecrit: > I was also wondering if after your changes, libpciaccess would support > nested arbiters, or if is that something we want at all. We'd want this, yes. > About pciutils, I've seen our patch doesn't use the RPC get_ndevs(), so > no need