Re: [PATCH] rumpkernel dependencies

2020-03-28 Thread Samuel Thibault
Damien Zammit, le sam. 28 mars 2020 16:50:41 +1100, a ecrit: > Apply these first to libpciaccess: > upstreaming/libpciaccess/99-fix-pciconf-calls > upstreaming/libpciaccess/99-region-probe > upstreaming/libpciaccess/99-common-reuse-mapping Concerning 99-common-reuse-mapping, as mentioned I'd

Re: [PATCH] rumpkernel dependencies

2020-03-28 Thread Samuel Thibault
Damien Zammit, le sam. 28 mars 2020 16:50:41 +1100, a ecrit: > I could then push out my latest debian rumpkernel tree. I'd say yes, you can go ahead. I don't think you need to wait for libpciaccess patches? Sure all the pieces are needed for the whole thing to work, but compile-wise,

Re: [PATCH] rumpkernel dependencies

2020-03-28 Thread Samuel Thibault
> diff --git a/libmachdevrump/block.c b/libmachdevrump/block.c > new file mode 100644 > index 0..e4b519bb8 > --- /dev/null > +++ b/libmachdevrump/block.c > +static io_return_t > +device_open (mach_port_t reply_port, mach_msg_type_name_t reply_port_type, > + dev_mode_t mode, char

Re: [PATCH] rumpkernel dependencies

2020-03-28 Thread Samuel Thibault
Hello, Damien Zammit, le sam. 28 mars 2020 16:50:41 +1100, a ecrit: > I am sending this primarily because I don't want to lose these patches. Ok, I already have comments on them :) + /* Parse @master:/dev/hello */ + master = strdup (name); + copy = strdup (name); + pos =

Re: [PATCH] rumpkernel dependencies

2020-03-28 Thread Samuel Thibault
Damien Zammit, le sam. 28 mars 2020 16:50:41 +1100, a ecrit: > I'm not sure how to solve this exactly, I'm guessing you don't want > rumpkernel to be a build-dep for hurd. I don't think this is a problem? I mean, we have cross-deps in various places: we have to build hurd before building glibc

Re: [PATCH] rumpkernel dependencies

2020-03-28 Thread Samuel Thibault
Damien Zammit, le sam. 28 mars 2020 16:50:41 +1100, a ecrit: > upstreaming/hurd/pciarbiter-short-rw.patch Applied, thanks! Samuel

Re: [PATCH] rumpkernel dependencies

2020-03-28 Thread Samuel Thibault
--- a/src/common_interface.c +++ b/src/common_interface.c @@ -290,11 +290,13 @@ pci_device_map_range(struct pci_device *dev, pciaddr_t base, /* Make sure that there isn't already a mapping with the same base and * size. + * If there is, use it. */ for (i = 0; i <

Re: [PATCH] rumpkernel dependencies

2020-03-28 Thread Samuel Thibault
diff --git a/src/hurd_pci.c b/src/hurd_pci.c index 26505f3..ada7af8 100644 --- a/src/hurd_pci.c +++ b/src/hurd_pci.c @@ -162,7 +162,7 @@ pciclient_cfg_read(mach_port_t device_port, int reg, char *buf, data = buf; nread = *nbytes; -err = pci_conf_read(device_port, reg, , ,

Re: [PATCH] rumpkernel dependencies

2020-03-28 Thread Damien Zammit
Hi Samuel, On 29/3/20 11:19 am, Samuel Thibault wrote: > --- a/src/common_interface.c > +++ b/src/common_interface.c > @@ -290,11 +290,13 @@ pci_device_map_range(struct pci_device *dev, pciaddr_t > base, > > /* Make sure that there isn't already a mapping with the same base and > *

Re: [PATCH] rumpkernel dependencies

2020-03-28 Thread Damien Zammit
Hurd TODO for Damien: = - Fix libstore patch - Remove useless debugging eg: >> + mach_print("device open\n"); - Remove most of this header: >> +++ b/libmachdevrump/dev_hdr.h - Complete the following: > I see that most of the patch is actually coming from the

Re: [PATCH] rumpkernel dependencies

2020-03-28 Thread Damien Zammit
On 29/3/20 11:24 am, Samuel Thibault wrote: > Damien Zammit, le sam. 28 mars 2020 16:50:41 +1100, a ecrit: >> Apply these first to libpciaccess: >> upstreaming/libpciaccess/99-fix-pciconf-calls >> upstreaming/libpciaccess/99-region-probe >> upstreaming/libpciaccess/99-common-reuse-mapping > >

Re: [PATCH] rumpkernel dependencies

2020-03-28 Thread Damien Zammit
On 29/3/20 11:31 am, Samuel Thibault wrote: > Damien Zammit, le sam. 28 mars 2020 16:50:41 +1100, a ecrit: >> I could then push out my latest debian rumpkernel tree. > > I'd say yes, you can go ahead. > > I don't think you need to wait for libpciaccess patches? Sure all > the pieces are needed