PATCH: Hurd FTBFS with perl 5.22

2016-01-04 Thread Svante Signell
Hi, The following patch is sufficient to make Debian GNU/Hurd build again with the latest perl 5.22.1-1: Index: hurd-0.7/libdde-linux26/lib/src/kernel/timeconst.pl === --- hurd-0.7.orig/libdde-linux26/lib/src/kernel/timeconst.pl +++

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-04 Thread Svante Signell
On Mon, 2016-01-04 at 22:50 +0100, Samuel Thibault wrote: > Svante Signell, on Mon 04 Jan 2016 22:02:02 +0100, wrote: > > - @val = @{$canned_values{$hz}}; > > - if (!defined(@val)) { > > - @val = compute_values($hz); > > - } > > + @val = compute_values($hz); > > Don't we want to

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-04 Thread Samuel Thibault
Svante Signell, on Mon 04 Jan 2016 23:09:00 +0100, wrote: > On Mon, 2016-01-04 at 22:50 +0100, Samuel Thibault wrote: > > Svante Signell, on Mon 04 Jan 2016 22:02:02 +0100, wrote: > > > - @val = @{$canned_values{$hz}}; > > > - if (!defined(@val)) { > > > - @val = compute_values($hz); > > >

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-04 Thread Samuel Thibault
Svante Signell, on Mon 04 Jan 2016 22:02:02 +0100, wrote: > - @val = @{$canned_values{$hz}}; > - if (!defined(@val)) { > - @val = compute_values($hz); > - } > + @val = compute_values($hz); Don't we want to still try to use canned_values? Samuel

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-04 Thread Samuel Thibault
James Clarke, on Mon 04 Jan 2016 22:38:28 +, wrote: > > - if (!defined(@val)) { > > + if (!@val) { Applied, thanks! Samuel

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-04 Thread Svante Signell
On Tue, 2016-01-05 at 17:36 +1100, William ML Leslie wrote: > On 5 January 2016 at 16:56, Svante Signell wrote: > > BTW: Why does Hurd contain such crappy dependencies such as perl. Is this > > part > > of upstream or Debian specific? The Debian package does not have it:

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-04 Thread William ML Leslie
On 5 January 2016 at 16:56, Svante Signell wrote: > BTW: Why does Hurd contain such crappy dependencies such as perl. Is this part > of upstream or Debian specific? The Debian package does not have it: > apt-cache showsrc hurd | grep Build-Depends | grep -i perl > > Is

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-04 Thread Svante Signell
On Mon, 2016-01-04 at 22:38 +, James Clarke wrote: > On 4 Jan 2016, at 22:13, Samuel Thibault wrote: > > Svante Signell, on Mon 04 Jan 2016 23:09:00 +0100, wrote: > > It is indeed just !@val (this use of defined was deprecated in 5.6.1 and > raised warnings since

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-04 Thread James Clarke
On 4 Jan 2016, at 22:13, Samuel Thibault wrote: > Svante Signell, on Mon 04 Jan 2016 23:09:00 +0100, wrote: >> Obviously the !defined(@val) is >> no longer allowed, and I don't know how to rewrite that condition. > > Perhaps juste !@val? > I have no idea, I don't know