[PATCH 3/4] libmachdev: Introduce startup notification for clean rumpdisk shutdown

2020-07-28 Thread Damien Zammit
NB: Reboot still hangs on diskfs_S_startup_dosync() even though that times out and then rumpdisk shuts down cleanly. --- libmachdev/Makefile | 6 +-- libmachdev/ds_routines.c | 10 libmachdev/machdev-device_emul.h | 1 + libmachdev/machdev.h | 1 +

[PATCH 1/4] diskfs: Add RPC for fsys_init to bootstrap if present

2020-07-28 Thread Damien Zammit
--- libdiskfs/boot-start.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libdiskfs/boot-start.c b/libdiskfs/boot-start.c index 29b8acc6..fa59e1b2 100644 --- a/libdiskfs/boot-start.c +++ b/libdiskfs/boot-start.c @@ -518,7 +518,9 @@ diskfs_S_fsys_init (struct diskfs_control

[PATCH 2/4] diskfs: Don't deallocate if dotdot is null in fsys-getroot.c

2020-07-28 Thread Damien Zammit
--- libdiskfs/fsys-getroot.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libdiskfs/fsys-getroot.c b/libdiskfs/fsys-getroot.c index 735f359a..2c0d15dd 100644 --- a/libdiskfs/fsys-getroot.c +++ b/libdiskfs/fsys-getroot.c @@ -194,7 +194,8 @@ diskfs_S_fsys_getroot (struct

[PATCH 4/4] rumpdisk: Install as translator when bootstrapping

2020-07-28 Thread Damien Zammit
NB: Not sure why this seems to have no effect on /dev/rumpdisk Am I setting the translator on the wrong port? --- rumpdisk/main.c | 29 + 1 file changed, 29 insertions(+) diff --git a/rumpdisk/main.c b/rumpdisk/main.c index 27a8ea38..68fb8be2 100644 ---

Re: [PATCH] SMP initialization: detection and enumeration

2020-07-28 Thread Almudena Garcia
> @@ -170,6 +172,14 @@ void machine_init(void) > linux_init(); > #endif > > +#if NCPUS > 1 > + int smp_success = smp_init(); > + > + if(smp_success != 0) { > +printf("Error: no SMP found"); > +} > +#endif /* NCPUS > 1 */ > + > There's a bogus indent here. Tell your

Re: [PATCH] SMP initialization: detection and enumeration

2020-07-28 Thread Almudena Garcia
> 256 is a common default > (I know that's what FreeBSD uses for x86) as the APIC IDs are 8-bit, > and I think this should be 256 rather than 255 too I agree. It's a mistake. > Though I do > question what the point of mach_ncpus is if it isn't being used to > determine NCPUS. Currently,