URL:
http://savannah.gnu.org/bugs/?29809
Summary: creating a firmlink loop results in memory
exhaustion
Project: The GNU Hurd
Submitted by: teythoon
Submitted on: Thu 06 May 2010 05:09:09 PM GMT
Category: Hurd
Follow-up Comment #1, bug #29809 (project hurd):
As suggested by antrik in #hurd here is a log of the port usage of both
ext2fs and firmlink (both eat up more and more memory) measured once every
second using portinfo $PID | wc --lines:
r...@hurdbox:~# ps ax | egrep '(ext2fs|firmlink)'
root
Hey everyone :)
I just wanted to say hello and to inform you about two young pet
projects of mine, an installation wizard in the spirit of the OpenBSD
installer and a script to master live cds from existing systems.
I've created one live cd that is able to install a Debian GNU/Hurd
system. It
On Mon, 10 May 2010 00:20:43 +0200
Samuel Thibault samuel.thiba...@gnu.org wrote:
Justus Winter, le Sun 09 May 2010 00:01:12 +0200, a écrit :
Btw, I know about the plan to get the debian-installer running on
the Hurd and I don't want compete with it. But it always bugged me
that one needed
On Tue, 11 May 2010 19:19:01 +0200
Sergio Lopez sergio.lo...@sinrega.org wrote:
Hi,
I think short circuiting data_unlock requests in ext2fs (by allocating
the page in file_pager_read_page and returning it unlocked) could
improve file growing performance a bit.
I've tested it in qemu
On Wed, 12 May 2010 06:19:29 +0200
Justus Winter 4win...@informatik.uni-hamburg.de wrote:
And here are the results:
Benchmarking /home/teythoon/ext2fs.vanilla...
Running 'dd if=/dev/zero of=/mnt/sink bs=1M count=51'...
2.28 2.27 2.28 2.30 2.30 Average: 2.286
Running 'tar xf /tmp/ramdisk
On Wed, 12 May 2010 12:14:06 +0200
Sergio Lopez sergio.lo...@sinrega.org wrote:
Thanks for taking some time to test this. If possible, I'd like to see
the results of dd writting longer files to disk. Also, the
information that dd prints at the end of the proccess could be
useful too.
Okay, I
Hey Arne :)
On Sunday 09 May 2010 16:19:32 Arne Babenhauserheide wrote:
Am Sonntag, 9. Mai 2010, 00:01:12 schrieb Justus Winter:
I just wanted to say hello and to inform you about two young pet
projects of mine, an installation wizard in the spirit of the
OpenBSD installer
Hi Tanguy :)
In-Reply-To:
cajbrmlah5wgqy3_g6tmm9p1armmnd5nqr4t-xzhcb_7mvp9...@mail.gmail.com
Quoting Tanguy LE CARROUR (2012-01-18 10:19:14)
For sure, once it builds on Linux I have to try it on Hurd.
But the build process take longer in my qemu. And I'm used to use pbuild which
is also a bit of
Quoting Pierre Thierry (2012-04-12 11:47:23)
Hi all,
this year I applied for a slot in Google's Summer of Code on the
Hurd[1], to tackle virtualization à la Hurd. As I currently have no
other commitments during the summer, I will be able work on this
project between half-time and full-time,
Hi everyone :)
Quoting Thomas Schwinge (2013-06-01 11:00:40)
First, congratulations again for getting your applications accepted! In
no particular order: 陆岳 (Yue Lu) »Improve the GDB Port for GNU Hurd«,
http://www.google-melange.com/gsoc/proposal/review/google/gsoc2013/hacklu/1;
Hi Yue Lu,
Hi :)
I'm trying to setup pbuilder on one of my virtual Hurd
systems. Problem is that debootstrap eventually dies:
/var/cache/apt/archives/readline-common_6.2+dfsg-0.1_all.deb
/var/cache/apt/archives/xz-utils_5.1.1alpha+20120614-2_hurd-i386.deb
(Reading database ... 6919 files and directories
Quoting Samuel Thibault (2013-06-08 13:34:18)
Justus Winter, le Sat 08 Jun 2013 13:27:07 +0200, a écrit :
I'm trying to setup pbuilder on one of my virtual Hurd
systems. Problem is that debootstrap eventually dies:
I don't think pbuilder has ever been made to work on hurd-i386
Hi,
I cannot rebuild the hurd package (both the one from sid from
alioth). Before digging deeper into this, I just wanted to ask if I'm
missing something obvious here:
[...]
make -C libshouldbeinlibc all
make[3]: Entering directory
Quoting Richard Braun (2013-06-09 17:14:36)
On Sun, Jun 09, 2013 at 03:26:22PM +0200, Justus Winter wrote:
I cannot rebuild the hurd package (both the one from sid from
alioth). Before digging deeper into this, I just wanted to ask if I'm
missing something obvious here:
[...]
make
Quoting Svante Signell (2013-06-09 20:10:59)
On Sun, 2013-06-09 at 18:56 +0200, Svante Signell wrote:
On Sun, 2013-06-09 at 17:48 +0200, Justus Winter wrote
..
apt-get source --download-only eglibc=2.13-38
dget \
ftp://ftp.debian-ports.org/debian/pool-hurd-i386/main/e/eglibc/eglibc_2.13
Quoting Emilio Pozuelo Monfort (2013-06-10 16:28:06)
On 10/06/13 16:10, Justus Winter wrote:
Awesome, didn't know this one. Still I was hoping to get a git repo
since that way I could plug it into my package building solution.
The debian packaging with the upstream sources + patches
Quoting Richard Braun (2013-06-10 16:28:40)
On Mon, Jun 10, 2013 at 04:10:57PM +0200, Justus Winter wrote:
Awesome, didn't know this one. Still I was hoping to get a git repo
since that way I could plug it into my package building solution.
There are debian repositories for GNU Mach
Quoting Justus Winter (2013-06-01 21:12:36)
Copyright assignment. [...]
Will do that.
I did that, haven't heard anything yet. I'm not complaining, just
stating facts.
Weekly reports.
Check.
I setup a blog at https://teythoon.cryptobitch.de/
I read http://wiki.debian.org/PlanetDebian
Hi Samuel,
Quoting Justus Winter (2013-06-16 22:37:43)
Quoting Samuel Thibault (2013-06-16 22:33:16)
Hello,
Justus Winter, le Tue 11 Jun 2013 18:31:01 +0200, a écrit :
Samuel or anyone else in a position to do that, would you please add
https://teythoon.cryptobitch.de/rss.xml
Quoting Samuel Thibault (2013-06-18 22:43:33)
Hello,
AIUI, SoC has begun yesterday, we should probably settle for a weekly
meeting?
Agreed. Let's dudle it:
https://dudle.mafiasi.de/Hurd_GSoC_weekly_meeting/
Feel free to modify the poll, you can add more timeslots for
example. Times are
Quoting Thomas Schwinge (2013-06-20 12:52:20)
I propose the following scheme: effective now, GSoC students send a
weekly report at the end of each week (so, on Friday, or on the weekend
-- as an exception at the very latest one hour before the following
regular IRC meeting), and regular IRC
Hi,
I'd like to get some input. For context, please read Guillems message
http://lists.gnu.org/archive/html/bug-hurd/2006-02/msg00081.html and
Marcus critique
http://lists.gnu.org/archive/html/bug-hurd/2006-02/msg00082.html
Looking at his patch and having seen some mach message passing code in
Hi,
currently procfs doesn't allow one to alter the options at runtime
using fsys_set_options. This is necessary to make mount -oremount
work. I also noticed that fsys_get_options would only return the
translators name, but not its options, so I've implemented this as
well.
FWIW this is meant to
Do not exit using error (1, ..) but gracefully handle the error using
argp_error.
* procfs/main.c (argp_parser): Proper error handling.
---
procfs/main.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/procfs/main.c b/procfs/main.c
index 3a976cc..e7f8574 100644
Previously if strtol failed the previous configuration value would get
overwritten. Prevent this by storing the result in a temporary
variable and update the configuration if the argument was parsed
correctly and passed the sanity checks.
* procfs/main.c (argp_parser): Keep old configuration in
Make procfs translators handle fsys_set_options requests by pointing
netfs_runtime_argp to our argp struct.
* procfs/main.c (netfs_runtime_argp): New variable.
---
procfs/main.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/procfs/main.c b/procfs/main.c
index f472f04..6251c83 100644
Split the argument handling into a common part and one for
fsys_update_options. Handle the --update parameter; for procfs this is
a no-op.
* procfs/main.c (common_options): New variable.
(runtime_argp_parser): Handle --update.
(startup_argp): New variable.
(netfs_runtime_argp_): New variable.
---
Define a macro for the default value of each command line
parameter. This allows one to generate a minimal response to
fsys_get_options requests.
* procfs/main.c: New macro definitions for default values.
---
procfs/main.c | 17 -
1 file changed, 12 insertions(+), 5
Implement our own netfs_append_args function that provides the
appropriate command line flags if the current values differ from the
default values.
* procfs/main.c (netfs_append_args): New function.
---
procfs/main.c | 42 ++
1 file changed, 42
Formerly setting the options using fsys_set_options did not work
because runtime_argp.options was set to 0. This fixes remounting of
tmpfs translators.
* tmpfs/tmpfs.c (runtime_argp): Use options as option list.
---
tmpfs/tmpfs.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Do not exit using error (1, ..) but gracefully handle the error using
argp_error. Also fix a typo (the a user) while touching these lines.
* procfs/main.c (argp_parser): Proper error handling.
(argp_parser): Fix typo.
---
procfs/main.c | 12 ++--
1 file changed, 6 insertions(+), 6
Make procfs translators handle fsys_set_options requests by pointing
netfs_runtime_argp to our argp struct.
* procfs/main.c (netfs_runtime_argp): New variable.
---
procfs/main.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/procfs/main.c b/procfs/main.c
index 0892d36..1b19c01 100644
Previously if strtol failed the previous configuration value would get
overwritten. Prevent this by storing the result in a temporary
variable and update the configuration if the argument was parsed
correctly and passed the sanity checks.
* procfs/main.c (argp_parser): Keep old configuration in
Split the argument handling into a common part and one for
fsys_update_options. Handle the --update parameter; for procfs this is
a no-op.
* procfs/main.c (common_options): New variable.
(runtime_argp_parser): Handle --update.
(startup_argp): New variable.
(netfs_runtime_argp_): New variable.
---
Define a macro for the default value of each command line
parameter. This allows one to generate a minimal response to
fsys_get_options requests.
* procfs/main.c: New macro definitions for default values.
---
procfs/main.c | 17 -
1 file changed, 12 insertions(+), 5
Implement our own netfs_append_args function that provides the
appropriate command line flags if the current values differ from the
default values.
* procfs/main.c (netfs_append_args): New function.
---
procfs/main.c | 42 ++
1 file changed, 42
Hi :)
this is a patch series making our mount more compatible with Linux
mount. The most interesting one is patch 3, it fixes an issue with
file_name_lookup_carefully, but but I'm not sure whether I
accidentally broke something.
Justus
Add -n and --no-mtab arguments. As we do not write an mtab file, this
is a trivial patch that just ignores this argument to be more
compatible with Linux mount.
* utils/mount.c (argp_opts): Add -n and --no-mtab.
(parse_opt): Do nothing on 'n'.
---
utils/mount.c |5 +
1 file changed, 5
Add -f and --fake arguments. This makes our mount more compatible with
Linux mount.
* utils/mount.c (argp_opts): Add -f and --fake.
(do_mount): Fake the translator startup if --fake is given.
---
utils/mount.c | 29 -
1 file changed, 28 insertions(+), 1 deletion(-)
This fixes mount -oremount when just given the mountpoint, e. g.:
% mount -oremount,ro /tmp
* util/mount.c (main): Add a one-argument form for remount.
---
utils/mount.c | 29 +++--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/utils/mount.c
Quoting Samuel Thibault (2013-06-29 22:11:21)
Justus Winter, le Fri 28 Jun 2013 18:37:40 +0200, a écrit :
Do not exit using error (1, ..) but gracefully handle the error using
argp_error. Also fix a typo (the a user) while touching these lines.
* procfs/main.c (argp_parser): Proper error
Fix a compiler warning by dropping the const qualifier. It is not
appropriate to qualify pointers to dynamically allocated memory as
const.
* sutils/fstab.c (real_name): Drop const qualifier.
---
sutils/fstab.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sutils/fstab.c
--test-opts in combination with --all mounts only those filesystems
with options matching the given set of options.
Note that the semantic of the inverting no prefix differs from
--types: While --types=nonfs,ufs means neither nfs nor ufs,
--test-opts=nofoo,bar means not foo, but bar.
*
Linux' mount utility ignores mounted filesystems if mount --all is
invoked. This patch makes our mount do the same.
utils/mount.c (main): Ignore mounted filesystems if --all is given.
---
utils/mount.c |9 +
1 file changed, 9 insertions(+)
diff --git a/utils/mount.c b/utils/mount.c
The mount utility on both Linux and FreeBSD allows one to either
specify a whitelist or a blacklist of filesystem types to consider for
--all. Prefixing the list with no indicates that the list is a
blacklist. Furthermore, Linux' mount utility ignores a no prefix on
any entry in the given list.
Add missing import of alloca.h.
* libfshelp/set-options.c: Add missing import.
---
libfshelp/set-options.c |1 +
1 file changed, 1 insertion(+)
diff --git a/libfshelp/set-options.c b/libfshelp/set-options.c
index 13e4001..77cdba1 100644
--- a/libfshelp/set-options.c
+++
Hi,
we discussed in #hurd that I'd send my mtab prototype quite early so
that we can discuss the rpc procedure and the integration in lib*fs
and libfshelp. Please let me know what you think.
For testing purposes there's a mtab tool included in utils/mtab.c:
% find tmp
tmp
tmp/foo
tmp/foo/bar
%
@@ -0,0 +1,61 @@
+/* fsys_get_translator_info
+
+ Copyright (C) 2013 Free Software Foundation, Inc.
+
+ Written by Justus Winter 4win...@informatik.uni-hamburg.de
+
+ This file is part of the GNU Hurd.
+
+ The GNU Hurd is free software; you can redistribute it and/or modify
+ it under
Use libblkid to detect the filesystem type if auto is given as
type. Remove the translator localization from main, this is also done
in do_mount and any errors are propagated properly. This way auto is
handled correctly if given on the command line or used as filesystem
type in the fstab.
*
Quoting Justus Winter (2013-07-03 23:11:57)
Hi,
we discussed in #hurd that I'd send my mtab prototype quite early so
that we can discuss the rpc procedure [...]
Looking at libshouldbeinlibc/fsysops.c:fsys_get_readonly (fsys_t fsys, int
*readonly)
I'm thinking that this might
Hi,
this is a patch series with all the non-trivial changes I posted this
week. This obsoletes:
1372686414-25363-1-git-send-email-4win...@informatik.uni-hamburg.de
1372930812-22762-1-git-send-email-4win...@informatik.uni-hamburg.de
This also adds a umount utility that should implement all of
Linux' mount utility ignores mounted filesystems if mount --all is
invoked. This patch makes our mount do the same.
utils/mount.c (main): Ignore mounted filesystems if --all is given.
---
utils/mount.c |9 +
1 file changed, 9 insertions(+)
diff --git a/utils/mount.c b/utils/mount.c
Use libblkid to detect the filesystem type if auto is given as
type. Remove the translator localization from main, this is also done
in do_mount and any errors are propagated properly. This way auto is
handled correctly if given on the command line or used as filesystem
type in the fstab.
*
Previously it was not possible to add two mount entries with the same
device information to an fstab structure. This is easily fixed by
breaking the assumption, that there is only one possible mount entry
for the none device as used by many purely virtual file systems.
* utils/fstab.c
/match-options.c
@@ -0,0 +1,68 @@
+/* Common functionality for the --test-opts flag of mount and umount.
+
+ Copyright (C) 2013 Free Software Foundation, Inc.
+ Written by Justus Winter 4win...@informatik.uni-hamburg.de
+
+ This file is part of the GNU Hurd.
+
+ The GNU Hurd is free software
.
+ Written by Justus Winter 4win...@informatik.uni-hamburg.de
+
+ This file is part of the GNU Hurd.
+
+ The GNU Hurd is free software; you can redistribute it and/or
+ modify it under the terms of the GNU General Public License as
+ published by the Free Software Foundation; either version
The mount utility on both Linux and FreeBSD allows one to either
specify a whitelist or a blacklist of filesystem types to consider for
--all. Prefixing the list with no indicates that the list is a
blacklist. Furthermore, Linux' mount utility ignores a no prefix on
any entry in the given list.
Quoting Samuel Thibault (2013-07-04 22:55:51)
Justus Winter, le Thu 04 Jul 2013 18:45:35 +0200, a écrit :
Note that without a
mtab or /proc/mounts file the umount utility is not very useful,
Mmm? In theory it should easily be able to unmount anything by just
providing the mount point
Quoting Samuel Thibault (2013-07-04 23:53:38)
Justus Winter, le Thu 04 Jul 2013 23:30:49 +0200, a écrit :
Quoting Samuel Thibault (2013-07-04 22:55:51)
Justus Winter, le Thu 04 Jul 2013 18:45:35 +0200, a écrit :
Note that without a
mtab or /proc/mounts file the umount utility
Hi :),
Quoting Cyril Roelandt (2013-07-05 01:25:26)
Hello!
After seeing this patch from Justus Winter:
http://lists.gnu.org/archive/html/bug-hurd/2013-06/msg00120.html
I wrote a Coccinelle script that finds similar errors:
Coccinelle is quite awesome :) we should try to find port leaks
This patch adds a --verbose argument to swapon and swapoff to make it
more compatible with the corresponding Linux' utilities. Note that our
swapon is verbose by default and has a --quiet argument to make it
quiet, so a --verbose argument on it's own does nothing at all.
* sutils/swapon.c (main):
Quoting Cyril Roelandt (2013-07-05 10:35:18)
On 07/05/2013 09:33 AM, Justus Winter wrote:
In your patches the variable state is misspelled sate. How did that
happen? Your script doesn't seem to include the typo.
Because the variable is actually named sate in the code :) Look at
mboxfs
This is the same series as send in [0], but the umount patch has been
updated. Among minor stylistic changes it makes umount assume that a
given argument is the mount point if looking it up as device or mount
point in the mtab file fails. This makes the umount utility somewhat
useful even on
Linux' mount utility ignores mounted filesystems if mount --all is
invoked. This patch makes our mount do the same.
utils/mount.c (main): Ignore mounted filesystems if --all is given.
---
utils/mount.c |9 +
1 file changed, 9 insertions(+)
diff --git a/utils/mount.c b/utils/mount.c
Use libblkid to detect the filesystem type if auto is given as
type. Remove the translator localization from main, this is also done
in do_mount and any errors are propagated properly. This way auto is
handled correctly if given on the command line or used as filesystem
type in the fstab.
*
Previously it was not possible to add two mount entries with the same
device information to an fstab structure. This is easily fixed by
breaking the assumption, that there is only one possible mount entry
for the none device as used by many purely virtual file systems.
* utils/fstab.c
The mount utility on both Linux and FreeBSD allows one to either
specify a whitelist or a blacklist of filesystem types to consider for
--all. Prefixing the list with no indicates that the list is a
blacklist. Furthermore, Linux' mount utility ignores a no prefix on
any entry in the given list.
.
+ Written by Justus Winter 4win...@informatik.uni-hamburg.de
+
+ This file is part of the GNU Hurd.
+
+ The GNU Hurd is free software; you can redistribute it and/or
+ modify it under the terms of the GNU General Public License as
+ published by the Free Software Foundation; either version
/match-options.c
@@ -0,0 +1,68 @@
+/* Common functionality for the --test-opts flag of mount and umount.
+
+ Copyright (C) 2013 Free Software Foundation, Inc.
+ Written by Justus Winter 4win...@informatik.uni-hamburg.de
+
+ This file is part of the GNU Hurd.
+
+ The GNU Hurd is free software
Ignore the --nodev, --noexec and --nosuid arguments.
* procfs/main.c (argp_parser): Ignore some arguments for compatibility.
---
procfs/main.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/procfs/main.c b/procfs/main.c
index bcf9590..727fea6 100644
---
---
debian/hurd-udeb.install.in |1 +
debian/hurd.install.in |1 +
2 files changed, 2 insertions(+)
diff --git a/debian/hurd-udeb.install.in b/debian/hurd-udeb.install.in
index 4618f10..9b2601e 100644
--- a/debian/hurd-udeb.install.in
+++ b/debian/hurd-udeb.install.in
@@ -39,6 +39,7
/changelog
@@ -52,6 +52,7 @@ sysvinit (2.88dsf-42) UNRELEASED; urgency=low
[ Justus Winter ]
* mount-functions.sh: Hurd has a tmpfs translator now, remove workaround.
+ * mount-functions.sh: Add -ocompatible to procfs mounts on Hurd.
-- Roger Leigh rle...@debian.org Sat, 04 May 2013 13:13:51
/changelog
@@ -50,6 +50,9 @@ sysvinit (2.88dsf-42) UNRELEASED; urgency=low
* Redirect error output from 'initctl version', suppressing warnings when
upstart is installed but not running. Closes: #685779.
+ [ Justus Winter ]
+ * mount-functions.sh: Hurd has a tmpfs translator now, remove
Hi,
this is a patch series for the sysvinit package. Comments are
welcome. Patches seven and eight are somewhat questionable, but I'd
propose the first six for inclusion. Any hints how to send patches to
the sysvinit maintainers? Attached to a bug report maybe?
I uploaded patched sysvinit
insertions(+), 1 deletion(-)
diff --git a/debian/changelog b/debian/changelog
index 1ff8750..7d9aa05 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -53,6 +53,7 @@ sysvinit (2.88dsf-42) UNRELEASED; urgency=low
[ Justus Winter ]
* mount-functions.sh: Hurd has a tmpfs translator now
Temporary workaround until
http://lists.gnu.org/archive/html/bug-hurd/2006-02/msg00081.html is
addressed.
---
debian/changelog|5 +
debian/src/initscripts/etc/init.d/killprocs |5 +
debian/src/initscripts/etc/init.d/sendsigs |5 +
3 files
runsystem.sysv does some very early initialization of Hurd and execs
/sbin/init to start the system using sysvinit. Hurd uses the
alternatives system to choose which runsystem to use and traditionally
shipped a custom init solution. Add runsystem.sysv using
update-alternatives in
The concept of device ids simply does not apply to the Hurd
system. Note that fsck is still run, rootcheck refers to the check
whether the root device in /etc/fstab matches the actual device.
---
debian/changelog |2 ++
Fixes build on Hurd.
---
debian/changelog |2 ++
src/killall5.c |2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/debian/changelog b/debian/changelog
index e77bd4e..50944ca 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -60,6 +60,8 @@ sysvinit (2.88dsf-42)
This is essentially the same as
89f6476d8979174f395a1bf784486254464c349d but fixes the existing
/etc/inittab file in the postinstall script.
---
debian/changelog |1 +
debian/sysvinit.postinst |4
2 files changed, 5 insertions(+)
diff --git a/debian/changelog
Quoting Ivan Shmakov (2013-07-09 12:59:01)
Justus Winter 4win...@informatik.uni-hamburg.de writes:
This is essentially the same as
89f6476d8979174f395a1bf784486254464c349d but fixes the existing
/etc/inittab file in the postinstall script.
[…]
+ * sysvinit.postinst: Fix getty
Quoting Pino Toscano (2013-07-09 10:52:56)
Hi,
Alle martedì 9 luglio 2013, Justus Winter ha scritto:
Ignore the --nodev, --noexec and --nosuid arguments.
Why nodev? The only consumer of it seems to be sysvinit, which has been
patched to not pass nodev also on Hurd (in addition
Hi Thomas :)
Quoting Thomas Schwinge (2013-07-09 15:40:18)
Hi!
On Tue, 09 Jul 2013 15:00:00 +0200, Justus Winter
4win...@informatik.uni-hamburg.de wrote:
Quoting Pino Toscano (2013-07-09 10:52:56)
Alle martedì 9 luglio 2013, Justus Winter ha scritto:
Ignore the --nodev, --noexec
passive is not a zero terminated string but a char * combined with a
length. If passivelen == 0, passive may very well be not NULL, and
dereferencing that pointer might not be safe. At the very least the
consistency check is wrong. Fix that by checking passivelen instead of
passive.
*
Hi,
this is an updated and broken up version of my mtab prototype.
[PATCH 01/17] libdiskfs: fix consistency check
[PATCH 02/17] libnetfs: fix consistency check
These are bug fixes. Please have a look.
[PATCH 03/17] libdiskfs: track file name in struct peropen
[PATCH 04/17] libnetfs: track file
---
trans/symlink.c |8
1 file changed, 8 insertions(+)
diff --git a/trans/symlink.c b/trans/symlink.c
index 03b5100..5e9e09a 100644
--- a/trans/symlink.c
+++ b/trans/symlink.c
@@ -221,3 +221,11 @@ S_fsys_forward (mach_port_t server, mach_port_t requestor,
{
return EOPNOTSUPP;
---
hurd/fsys.defs |8
1 file changed, 8 insertions(+)
diff --git a/hurd/fsys.defs b/hurd/fsys.defs
index 979a6cf..4b649d9 100644
--- a/hurd/fsys.defs
+++ b/hurd/fsys.defs
@@ -127,3 +127,11 @@ routine fsys_get_options (
server: fsys_t;
RPT
out options:
passive is not a zero terminated string but a char * combined with a
length. If passivelen == 0, passive may very well be not NULL, and
dereferencing that pointer might not be safe. At the very least the
consistency check is wrong. Fix that by checking passivelen instead of
passive.
*
+++ b/libfshelp/translator-list.c
@@ -0,0 +1,143 @@
+/*
+ Copyright (C) 2013 Free Software Foundation
+ Written by Justus Winter 4win...@informatik.uni-hamburg.de
+
+ This file is part of the GNU Hurd.
+
+ This program is free software; you can redistribute it and/or
+ modify it under
---
trans/symlink.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/trans/symlink.c b/trans/symlink.c
index 5e9e09a..946c950 100644
--- a/trans/symlink.c
+++ b/trans/symlink.c
@@ -229,3 +229,10 @@ S_fsys_get_children (mach_port_t server,
{
return EOPNOTSUPP;
}
+
+error_t
---
libdiskfs/dir-lookup.c |5 +
libdiskfs/diskfs.h |3 +++
libdiskfs/fsys-getroot.c |3 ++-
libdiskfs/peropen-make.c |8
libdiskfs/peropen-rele.c |1 +
5 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/libdiskfs/dir-lookup.c
-get-source.c b/libdiskfs/fsys-get-source.c
new file mode 100644
index 000..e7e0e78
--- /dev/null
+++ b/libdiskfs/fsys-get-source.c
@@ -0,0 +1,35 @@
+/* fsys_get_source
+
+ Copyright (C) 2013 Free Software Foundation, Inc.
+
+ Written by Justus Winter 4win...@informatik.uni-hamburg.de
---
libnetfs/dir-lookup.c |5 +
libnetfs/fsys-getroot.c|6 +-
libnetfs/make-peropen.c|8
libnetfs/netfs.h |2 ++
libnetfs/release-peropen.c |1 +
5 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/libnetfs/dir-lookup.c
/fsys-get-source.c b/libnetfs/fsys-get-source.c
new file mode 100644
index 000..37bd0cc
--- /dev/null
+++ b/libnetfs/fsys-get-source.c
@@ -0,0 +1,35 @@
+/* fsys_get_source
+
+ Copyright (C) 2013 Free Software Foundation, Inc.
+
+ Written by Justus Winter 4win...@informatik.uni-hamburg.de
-children.c b/libtrivfs/fsys-get-children.c
new file mode 100644
index 000..aa9135f
--- /dev/null
+++ b/libtrivfs/fsys-get-children.c
@@ -0,0 +1,36 @@
+/* fsys_get_children
+
+ Copyright (C) 2013 Free Software Foundation, Inc.
+
+ Written by Justus Winter 4win...@informatik.uni-hamburg.de
000..9d4c4b3
--- /dev/null
+++ b/libdiskfs/fsys-get-children.c
@@ -0,0 +1,51 @@
+/* fsys_get_children
+
+ Copyright (C) 2013 Free Software Foundation, Inc.
+
+ Written by Justus Winter 4win...@informatik.uni-hamburg.de
+
+ This file is part of the GNU Hurd.
+
+ The GNU Hurd is free software
-children.c
@@ -0,0 +1,53 @@
+/* fsys_get_children
+
+ Copyright (C) 2013 Free Software Foundation, Inc.
+
+ Written by Justus Winter 4win...@informatik.uni-hamburg.de
+
+ This file is part of the GNU Hurd.
+
+ The GNU Hurd is free software; you can redistribute it and/or modify
+ it under
): %: %.o
diff --git a/trans/mtab.c b/trans/mtab.c
new file mode 100644
index 000..f47d03d
--- /dev/null
+++ b/trans/mtab.c
@@ -0,0 +1,541 @@
+/* This is an mtab translator.
+
+ Copyright (C) 2013 Free Software Foundation, Inc.
+
+ Written by Justus Winter 4win...@informatik.uni-hamburg.de
--git a/libtrivfs/fsys-get-source.c b/libtrivfs/fsys-get-source.c
new file mode 100644
index 000..9b6933e
--- /dev/null
+++ b/libtrivfs/fsys-get-source.c
@@ -0,0 +1,34 @@
+/* fsys_get_source
+
+ Copyright (C) 2013 Free Software Foundation, Inc.
+
+ Written by Justus Winter 4win
1 - 100 of 1392 matches
Mail list logo
