Richard Braun, on Wed 17 Aug 2016 14:55:35 +0200, wrote:
> On Wed, Aug 17, 2016 at 10:50:56AM +0200, Samuel Thibault wrote:
> > Mmm. This is a clobber, so it's supposed to indicate what is written,
> > not what is read :) But I agree with the "move" rationale, let's be safe
> > (it doesn't really
On Wed, Aug 17, 2016 at 10:50:56AM +0200, Samuel Thibault wrote:
> Mmm. This is a clobber, so it's supposed to indicate what is written,
> not what is read :) But I agree with the "move" rationale, let's be safe
> (it doesn't really matter here, there's a memory compiler barrier at the
> function
Richard Braun, on Wed 17 Aug 2016 10:43:46 +0200, wrote:
> On Wed, Aug 17, 2016 at 08:46:34AM +0200, Samuel Thibault wrote:
> > - Are we sure that the direction flag is cleared on entry of the assembly
> > snippets?
>
> Yes, gcc makes sure it's cleared on entry. See [1] for reference.
Ok :)
> >
Richard Braun, on Wed 17 Aug 2016 10:46:10 +0200, wrote:
> On Wed, Aug 17, 2016 at 08:53:51AM +0200, Samuel Thibault wrote:
> > - also, in strstr, is it really better to use strncmp instead of strcmp?
>
> If I understand correctly, strcmp wouldn't behave right since it
> compares the terminating
On Wed, Aug 17, 2016 at 08:53:51AM +0200, Samuel Thibault wrote:
> - also, in strstr, is it really better to use strncmp instead of strcmp?
If I understand correctly, strcmp wouldn't behave right since it
compares the terminating null byte.
--
Richard Braun
On Wed, Aug 17, 2016 at 08:46:34AM +0200, Samuel Thibault wrote:
> - Are we sure that the direction flag is cleared on entry of the assembly
> snippets?
Yes, gcc makes sure it's cleared on entry. See [1] for reference.
> - I don't think the memcmp, strlen and strcmp snippets need a memory
Samuel Thibault, on Wed 17 Aug 2016 08:46:34 +0200, wrote:
> - Are we sure that the direction flag is cleared on entry of the assembly
> snippets?
>
> - I don't think the memcmp, strlen and strcmp snippets need a memory clobber?
>
> - the ecx trick in strlen is nice :)
>
> - should we really
Richard Braun, on Fri 12 Aug 2016 21:29:09 +0200, wrote:
> I can take care of this when I have time.
Thanks!
- Are we sure that the direction flag is cleared on entry of the assembly
snippets?
- I don't think the memcmp, strlen and strcmp snippets need a memory clobber?
- the ecx trick in
On Fri, Aug 12, 2016 at 09:16:02PM +0200, Richard Braun wrote:
> Note that it's not that "simple" since we'd like implementations that
> aren't naive, i.e. assembly with rep instructions. In particular, it
> makes a huge difference in virtualized guests compared to C-based ones
> because of
On Fri, Aug 12, 2016 at 07:57:48PM +0200, Samuel Thibault wrote:
> It becomes more and more clear that we shouldn't steal functions from
> glibc into gnumach, it poses cross-building issues from Linux.
>
> Could somebody contribute, or steal from a BSD the following functions,
> to be included in
Hello,
It becomes more and more clear that we shouldn't steal functions from
glibc into gnumach, it poses cross-building issues from Linux.
Could somebody contribute, or steal from a BSD the following functions,
to be included in gnumach/kern/strings.c?
- memcmp
- memcpy
- memmove
- strchr
-
11 matches
Mail list logo
