Re: Simple contribution please?

2016-08-17 Thread Samuel Thibault
Richard Braun, on Wed 17 Aug 2016 14:55:35 +0200, wrote: > On Wed, Aug 17, 2016 at 10:50:56AM +0200, Samuel Thibault wrote: > > Mmm. This is a clobber, so it's supposed to indicate what is written, > > not what is read :) But I agree with the "move" rationale, let's be safe > > (it doesn't really

Re: rump pci drivers backend

2016-08-17 Thread Samuel Thibault
Olaf Buddenhagen, on Sat 30 Jul 2016 03:47:10 +0200, wrote: > On Fri, Jul 29, 2016 at 06:30:09PM +, Luca wrote: > > > I need a way to translate logical addresses to physical, > > Is this for DMA or something along these lines? If so, the interface for > allocating "contiguous memory" that

Re: Simple contribution please?

2016-08-17 Thread Richard Braun
On Wed, Aug 17, 2016 at 10:50:56AM +0200, Samuel Thibault wrote: > Mmm. This is a clobber, so it's supposed to indicate what is written, > not what is read :) But I agree with the "move" rationale, let's be safe > (it doesn't really matter here, there's a memory compiler barrier at the > function

To be talked about at ghm?

2016-08-17 Thread Samuel Thibault
Hello, On friday, I'll present the latest news of the Hurd. What should I talk about? :) Samuel

[PATCH] Re: Hurd shutdown problems

2016-08-17 Thread Brent W. Baccala
Aloha - OK, I seem to have gotten a handle on this thing now. First, there's a missing mutex unlock in mach_defpager. I'm attaching two patches. One fixes the debug printfs in mach_defpager/default_pager.c, which obviously haven't been compiled for a while. Use %p and %lx instead of %x to

Re: Simple contribution please?

2016-08-17 Thread Richard Braun
On Wed, Aug 17, 2016 at 08:46:34AM +0200, Samuel Thibault wrote: > - Are we sure that the direction flag is cleared on entry of the assembly > snippets? Yes, gcc makes sure it's cleared on entry. See [1] for reference. > - I don't think the memcmp, strlen and strcmp snippets need a memory

Re: Simple contribution please?

2016-08-17 Thread Samuel Thibault
Samuel Thibault, on Wed 17 Aug 2016 08:46:34 +0200, wrote: > - Are we sure that the direction flag is cleared on entry of the assembly > snippets? > > - I don't think the memcmp, strlen and strcmp snippets need a memory clobber? > > - the ecx trick in strlen is nice :) > > - should we really

Re: Simple contribution please?

2016-08-17 Thread Samuel Thibault
Richard Braun, on Fri 12 Aug 2016 21:29:09 +0200, wrote: > I can take care of this when I have time. Thanks! - Are we sure that the direction flag is cleared on entry of the assembly snippets? - I don't think the memcmp, strlen and strcmp snippets need a memory clobber? - the ecx trick in

Re: Simple contribution please?

2016-08-17 Thread Richard Braun
On Wed, Aug 17, 2016 at 08:53:51AM +0200, Samuel Thibault wrote: > - also, in strstr, is it really better to use strncmp instead of strcmp? If I understand correctly, strcmp wouldn't behave right since it compares the terminating null byte. -- Richard Braun

Re: Simple contribution please?

2016-08-17 Thread Samuel Thibault
Richard Braun, on Wed 17 Aug 2016 10:43:46 +0200, wrote: > On Wed, Aug 17, 2016 at 08:46:34AM +0200, Samuel Thibault wrote: > > - Are we sure that the direction flag is cleared on entry of the assembly > > snippets? > > Yes, gcc makes sure it's cleared on entry. See [1] for reference. Ok :) > >

Re: Simple contribution please?

2016-08-17 Thread Samuel Thibault
Richard Braun, on Wed 17 Aug 2016 10:46:10 +0200, wrote: > On Wed, Aug 17, 2016 at 08:53:51AM +0200, Samuel Thibault wrote: > > - also, in strstr, is it really better to use strncmp instead of strcmp? > > If I understand correctly, strcmp wouldn't behave right since it > compares the terminating