[PATCH 1/4] lwip: poll(): return EIO when POLLERR is set

2018-08-11 Thread Joan Lledó
Needed to properly support poll in glibc (_hurd_select). * lwip/io-ops.c (lwip_io_select_common): If POLLERR is set, return EIO. --- lwip/io-ops.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lwip/io-ops.c b/lwip/io-ops.c index 636c26f7..1429bc55 100644 --- a/lwip/io-ops.c +++

[PATCH 4/4] lwip: Fix a buffer overflow and clear compiler warnings

2018-08-11 Thread Joan Lledó
GCC 8 new warning -Wstringop-truncation detected some buffer overflows. * lwip/options.c (parse_opt): Fix the buffer overflow. * lwip/pfinet-ops.c (dev_ifconf): Likewise. --- lwip/options.c| 2 +- lwip/pfinet-ops.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 3/4] lwip: return EINTR when a select() IPC thread is cancelled

2018-08-11 Thread Joan Lledó
Needed to properly support poll in glibc (_hurd_select). * lwip/io-ops.c (lwip_io_select_common): Detect when the current RPC is cancelled by checking the reply port. --- lwip/io-ops.c | 8 1 file changed, 8 insertions(+) diff --git a/lwip/io-ops.c b/lwip/io-ops.c index

[PATCH 2/4] lwip: refactor main demuxer to avoid code duplication

2018-08-11 Thread Joan Lledó
* lwip/main.c (lwip_demuxer): Refactored. --- lwip/main.c | 42 +++--- 1 file changed, 11 insertions(+), 31 deletions(-) diff --git a/lwip/main.c b/lwip/main.c index 9f7eb9b2..4dfbe143 100644 --- a/lwip/main.c +++ b/lwip/main.c @@ -99,6 +99,7 @@ int

Re: Patches: lwip translator

2018-08-11 Thread Joan Lledó
> But could you write the proper ChangeLog entries to explain not only why > the change but also what change is made? See git log and the GNU Coding > Style. The idea is that they help a *lot* when having to dig back what > happened to a given function, to the use of a macro, etc. Of course,