Re: [PATCH 2/3] utils/vmstat: Use gnumach.defs from gnumach
Hi, On Mon, May 13, 2013 at 6:10 PM, Richard Braun rbr...@sceen.net wrote: Sorry for reacting late but I don't see the point of that change. Using already generated system headers is the intent here. The fact they were generated doesn't matter at all, they are the interface reference that applications (and even the Hurd itself) must use. So is mach/gnumach.h supposed to be generated at some point in the gnumach install? That doesn't happen during my build from the Savannah sources; it only provides mach/gnumach.defs. Am I missing a step somewhere? Thanks. David
Re: [PATCH 2/3] utils/vmstat: Use gnumach.defs from gnumach
On Tue, May 14, 2013 at 10:49:19AM -0400, David Michael wrote: So is mach/gnumach.h supposed to be generated at some point in the gnumach install? That doesn't happen during my build from the Savannah sources; it only provides mach/gnumach.defs. Am I missing a step somewhere? System headers are provided by glibc (and by the libc0.3-dev package on Debian GNU/Hurd). -- Richard Braun
Re: [PATCH 2/3] utils/vmstat: Use gnumach.defs from gnumach
On Wed, May 01, 2013 at 09:10:34PM -0400, David Michael wrote: The gnumach installation provides the include file mach/gnumach.defs instead of mach/gnumach.h. This runs the defs file through MIG and builds the result for vmstat. Sorry for reacting late but I don't see the point of that change. Using already generated system headers is the intent here. The fact they were generated doesn't matter at all, they are the interface reference that applications (and even the Hurd itself) must use. -- Richard Braun
Re: [PATCH 2/3] utils/vmstat: Use gnumach.defs from gnumach
David Michael, le Wed 01 May 2013 21:10:34 -0400, a écrit : The gnumach installation provides the include file mach/gnumach.defs instead of mach/gnumach.h. This runs the defs file through MIG and builds the result for vmstat. Applied, thanks! Please take care when building patches to avoid whitespace changes. I had to fix the patch before being able to git am it. Also, if you consider writing more involved patches (i.e. which will have some copyright), we will need a copyright assignment from you. Samuel
Re: [PATCH 2/3] utils/vmstat: Use gnumach.defs from gnumach
Hi, On Sun, May 5, 2013 at 5:32 PM, Samuel Thibault samuel.thiba...@gnu.org wrote: Also, if you consider writing more involved patches (i.e. which will have some copyright), we will need a copyright assignment from you. That may happen as I continue working with the system. The wiki[1] just links to contact us with regard to obtaining the relevant forms. If you can direct me to the necessary resources (I suppose for both Mach and Hurd?), I'll make sure that issue is resolved before sending future changes. Thanks. David [1] https://www.gnu.org/software/hurd/contributing/copyright_assignment.html
