Re: [PATCH v2 1/2 gnumach] tests: Add VERBOSE=true param for logging failed tests in full

2026-01-23 Thread Damien Zammit
Hi,

On 1/24/26 3:00 AM, Samuel Thibault wrote:
> Better recognize V=1 which is the standard verbosity variable for
> automake.
>
According to the automake manual for its test framework:

 > The output from failed tests is collected in the test-suite.log file. 
If the variable ‘VERBOSE’ is set, this file is output after the summary.

So this change may be dropped and the CI script just works.

Thanks,

Damien





Re: [PATCH v2 1/2 gnumach] tests: Add VERBOSE=true param for logging failed tests in full

2026-01-23 Thread Samuel Thibault
Hello,

Damien Zammit, le ven. 23 janv. 2026 06:32:29 +, a ecrit:
> ---
>  tests/user-qemu.mk | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tests/user-qemu.mk b/tests/user-qemu.mk
> index 11ff82d5..c37e4e01 100644
> --- a/tests/user-qemu.mk
> +++ b/tests/user-qemu.mk
> @@ -233,6 +233,11 @@ USER_TESTS_CLEAN = $(subst tests/,clean-,$(USER_TESTS))
>  
>  run-%: tests/test-%
>   $^
> + RESULT=$?
> + if [ $RESULT -neq 0 ]

I don't think -neq is a standard comparison option?

> && [ "$VERBOSE" == "true" ]; then

Better recognize V=1 which is the standard verbosity variable for
automake.

Samuel