Re: [PATCH 0/3] GNU inetutils telnet client fixes

2022-07-07 Thread Simon Josefsson via Bug reports for the GNU Internet utilities
Erik Auerswald writes: > Hi, > > On 27.02.22 17:32, Erik Auerswald wrote: >> [...] >> [I have not yet received and answer from the FSF regarding the copyright >> assignment paperwork I have sent.] > > I have just received confirmation that the copyright assignment > has been processed and

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

2022-07-07 Thread Simon Josefsson via Bug reports for the GNU Internet utilities
Thanks for preparing these, I should have read through all posts before started working on them separately... so this patch no longer applies as is. Would you like to re-review these, to see if anything more is still needed after I applied some changes? Maybe it is just the NEWS entries. Btw,

Re: [PATCH 2/3] telnet: Fix TTYPE subnegotiation off-by-one error.

2022-07-07 Thread Simon Josefsson via Bug reports for the GNU Internet utilities
Erik Auerswald writes: > Fix off-by-one error in Terminal-Type option subnegotiation if the TERM > variable has exactly 44 bytes. In this case the SE byte (end of > subnegotiation parameters) was replaced by a NUL byte. This concerns > the CVE-2019-0053 fixes. Reported by Erik Auerswald in >

Re: Bug in telnet from inetutils-2.2: Insufficient buffer space for longish DISPLAY names

2022-07-07 Thread Simon Josefsson via Bug reports for the GNU Internet utilities
Erik Auerswald writes: > I have attached the output of "git format-patch origin" after locally > committing the patch for this issue and adding a NEWS entry. Please let > me know if this looks OK. Did I miss anything? Looks good to me, thank you!

Re: Supported TLDs

2022-07-07 Thread Marco d'Itri
On Jul 08, Simon Josefsson wrote: > I don't know the history of inetutils' fork of (g)whois, is there any > hope in getting these code-bases merged now? Maybe enough water has > passed under the bridges... I see no reasons at this point to tie whois to inetnutils development, since inetutils

Re: Supported TLDs

2022-07-07 Thread Simon Josefsson via Bug reports for the GNU Internet utilities
Chris Reveles writes: > Hello, > > > I hope 2022 is already up to a good start over there. I am doing some > research and I noticed certain TLDs such as .art and .eth are not resolving > properly from the *whois* command, are such domains on the map to be > supported? Thanks for the report -- I

Re: Heap-based Buffer Overflow in logger

2022-07-07 Thread Simon Josefsson via Bug reports for the GNU Internet utilities
AiDai writes: > 0x60c0003f is located 1 bytes to the left of 120-byte region Nice catch! Reproducing it is easy: jas@latte:~/src/inetutils$ valgrind src/logger -s '' ... ==339979== Invalid read of size 1 ==339979==at 0x10AA71: send_to_syslog (logger.c:329) ==339979==by 0x10A5CD:

Re: NULL Pointer Dereference in unsetcmd() at inetutils/telnet/commands.c:1227

2022-07-07 Thread Simon Josefsson via Bug reports for the GNU Internet utilities
Erik Auerswald writes: >> This happens when the "unset" command is used with a single space as >> argument, because the "Setlist" contains entries for empty lines that use >> a single space as key, but the setlist.handler is 0 and the setlist.charp >> is NULL: >> >> {" ", "", 0, NULL}, >>

Re: NULL Pointer Dereference in setcmd () at commands.c:1152

2022-07-07 Thread Simon Josefsson via Bug reports for the GNU Internet utilities
Erik Auerswald writes: >> A NULL Pointer Dereference was discovered in setcmd () at >> commands.c:1152. The vulnerability causes a segmentation fault and >> application crash. ... > The attached patch "inetutils-telnet-set_null_deref_fix.patch" fixes this > by rejecting a set argument with

Re: NULL Pointer Dereference in unsetcmd() at inetutils/telnet/commands.c:1227

2022-07-07 Thread Simon Josefsson via Bug reports for the GNU Internet utilities
Erik Auerswald writes: >> A NULL Pointer Dereference was discovered in unsetcmd() at >> inetutils/telnet/commands.c:1227. The vulnerability causes a segmentation >> fault and application crash. ... > The attached patch fixes this: Thank you again. Committed as follows:

Re: NULL Pointer Dereference in help()

2022-07-07 Thread Simon Josefsson via Bug reports for the GNU Internet utilities
Erik Auerswald writes: > On Thu, Dec 23, 2021 at 09:15:59PM +0800, AiDai wrote: >> Line 1: # NULL Pointer Dereference in help() at >> inetutils/telnet/commands.c:3094 > > Thanks for fuzzing GNU inetutils! Hi AiDai and Erik. Thanks for the report, debugging and patch! I installed your fixes

Re: [Bug][Patch] Buffer overflow in function makeargv() in telnet/commands.c

2022-07-07 Thread Simon Josefsson via Bug reports for the GNU Internet utilities
Erik Auerswald writes: > The attached patch fixes this. Hi Erik. Wonderful, what a master-piece of a bug report! Patch installed here: https://git.savannah.gnu.org/gitweb/?p=inetutils.git;a=commitdiff;h=f0c2abdbb720d8396061b75cc47d69edab012864 Since the crash was easy to reproduce, I added

Re: Memory leak in ifconfig

2022-07-07 Thread Simon Josefsson via Bug reports for the GNU Internet utilities
AiDai writes: > Direct leak of 64 byte(s) in 1 object(s) allocated from: > #0 0x494bdd in malloc > (/root/disk2/fuzzing/inetutils/fuzz/bin/ifconfig+0x494bdd) > #1 0x4e0330 in linux_if_nameindex > /root/disk2/fuzzing/inetutils/inetutils/ifconfig/./system/linux.c:948:11 > #2 0x4cbfd5

Re: inetutils-2.2 released [stable]

2022-07-07 Thread Simon Josefsson via Bug reports for the GNU Internet utilities
Michael Brunnbauer writes: > Hello Simon, > > it seems to me that the bug which the test code tries to trigger never got > fixed? > > https://sourceware.org/bugzilla/show_bug.cgi?id=11053 Hi. Looks like work on that bug was done shortly after your email, and the last release, and gnulib has