Re: Gnulib & bootstrap updates

2024-05-08 Thread Guillem Jover
Hi! On Mon, 2024-05-06 at 18:12:53 +0200, Simon Josefsson via Bug reports for the GNU Internet utilities wrote: > I have updated inetutils to latest gnulib (to get the u_* syntax-check > fixes, and the new faster gnulib-tool.py) and refreshed the bootstrap > scripts, please test and report if

Re: [BUG][PATCH] Someone described a remote DoS Vulnerability in telnetd (dereference NULL pointer ---> SEGV)

2022-09-07 Thread Guillem Jover
[ Resending with To trimmed. ] Hi! On Tue, 2022-08-30 at 22:57:51 +0200, Guillem Jover wrote: > On Sun, 2022-08-28 at 14:40:44 +0200, Erik Auerswald wrote: > > On Sat, Aug 27, 2022 at 07:37:15PM +0200, Erik Auerswald wrote: > > > someone has described a remote DoS vulnerabi

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

2022-09-03 Thread Guillem Jover
[ Removed Erik from To, as last time my mail was rejected by the mail server, and might then not get delivered by mailman as duplicate. ] Hi! On Sat, 2022-09-03 at 19:07:52 +0200, Erik Auerswald wrote: > AFAIK the other fuzzer-based crash reports have already been addressed > before the

Re: [BUG][PATCH] Someone described a remote DoS Vulnerability in telnetd (dereference NULL pointer ---> SEGV)

2022-08-30 Thread Guillem Jover
Hi! On Sun, 2022-08-28 at 14:40:44 +0200, Erik Auerswald wrote: > On Sat, Aug 27, 2022 at 07:37:15PM +0200, Erik Auerswald wrote: > > someone has described a remote DoS vulnerability in > > many telnetd implementations that I just happened to > > stumble over: > > > >

Re: telnetd security vulnerability CVE-2020-10188

2020-04-11 Thread Guillem Jover
On Sat, 2020-04-11 at 13:03:34 -0400, Alfred M. Szmidt wrote: >> Thank you for your bug report, please specify which inetutils versions >> you are refering to in pristine condition without any patches. You >> mention an assert, which assert exactly? > >The inetutils version in

Re: telnetd security vulnerability CVE-2020-10188

2020-04-10 Thread Guillem Jover
[ For some reason, I've not received the message from the list, and just happened to notice it from the web archive, so reconstructing the reply from there… ] On Fri, 2020-04-10 at 15:04:20 -0400, Alfred M. Szmidt wrote: > On Wed, 2020-04-08 at 13:41:58 +0200, Guillem Jover wrote: >

telnetd security vulnerability CVE-2020-10188

2020-04-08 Thread Guillem Jover
Hi! I've been notified of a security vulnerability in inetutils telnetd, which was reported initially against netkit-telnet, but that one has been fixed in Debian for a very long time (around two decades ago [N]). But the code inherited from the BSDs seems to still be around in inetutils. I've

Re: [bug-inetutils] bug: inetd does not map IPv6 to IPv4

2018-01-05 Thread Guillem Jover
Hi! On Thu, 2018-01-04 at 12:36:36 +0100, Ferruccio Fantozzi wrote: > I think I found a problem in the way inetd maps IPv4/IPv6 connections. > > When protocol in inetd.conf is set as > 'tcp': inetd accepts IPv4 connections only > 'tcp4': same as above > 'tcp6only': inetd accepts IPv6 connections

Re: [bug-inetutils] Buffer overflow for gnu inetutils telnetd

2017-07-11 Thread Guillem Jover
r the report! Here's a patch fixing the issue, which was obvious by just looking at the code indicated by the warning. Thanks, Guillem From c4f1bc8e2e9e6303a33e1babfffafef9aa628c49 Mon Sep 17 00:00:00 2001 From: Guillem Jover <guil...@hadrons.org> Date: Tue, 11 Jul 2017 12:22:41 +0200 Subjec

[bug-inetutils] [PATCH] ftp: Fix typo

2015-06-05 Thread Guillem Jover
--- ftp/cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ftp/cmds.c b/ftp/cmds.c index c12f24c..f9731dc 100644 --- a/ftp/cmds.c +++ b/ftp/cmds.c @@ -363,7 +363,7 @@ setpeer (int argc, char **argv) unix_server = 0; if (overbose !strncmp

[bug-inetutils] syslogd vulnerable to CVE-2014-3634?

2014-10-03 Thread Guillem Jover
Hi! I just stumbled over this on http://seclists.org/oss-sec/2014/q4/79, and from a cursory glance it appears as if inetutils' syslogd is also vulnerable? There's a patch there that seems would apply w/o much effort. I think this would be a good excuse to do a release, with a nice timing now

Re: [bug-inetutils] New release?

2013-05-10 Thread Guillem Jover
Heya, On Tue, 2013-05-07 at 19:14:33 +0200, Guillem Jover wrote: There's quite some work accumulated in master since the 1.9.1 release (around 280 commits, with lots of fixes and improvements), I'd like to upload a new version to Debian (and preferably not a git snapshot), could we got

[bug-inetutils] [PATCH] Cleanup automake variables

2013-01-13 Thread Guillem Jover
Hi, Here's the patch cleaning up the automake variables a bit, originally sent some time ago [0]. It moves the global ones to the top of the file as they affect all following rules. Splits long lines into ones not over 80 chars. Switches INCLUDES to AM_CPPFLAGS. Refactors common flags into global

[bug-inetutils] [PATCH] ping: Abort on sendto () error

2013-01-13 Thread Guillem Jover
* ping/libping.c (ping_xmit): Return -1 instead of calling perror () on sendto () error. * ping/ping6.c (ping_xmit): Likewise. (send_echo): Error out instead of continuing sending packets. * ping/ping.c (send_echo): Likewise. --- ping/libping.c | 2 +- ping/ping.c| 8 +++- ping/ping6.c

Re: [bug-inetutils] Present release goals

2011-10-24 Thread Guillem Jover
Hi! On Wed, 2011-10-12 at 19:44:36 +0200, Mats Erik Andersson wrote: Thus I propose we only do the last polishing for a release in a close future, followed by a small set of new goals for a next release, which could take place fairly rapidly, still calling it a major release. I've some

[bug-inetutils] [PATCH] Re-include stddef.h needed for NULL

2011-10-24 Thread Guillem Jover
Partially reverts 1647134d6cac7ffcb11dcf576826b1bb079467c5. * libicmp/icmp_timestamp.c: Include stddef.h. --- libicmp/icmp_timestamp.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/libicmp/icmp_timestamp.c b/libicmp/icmp_timestamp.c index 8c0020b..e04fdad 100644 ---

[bug-inetutils] [PATCH] build: Add a sed script to normalize git tags

2011-10-24 Thread Guillem Jover
* configure.ac (AC_INIT): Use a sed script to normalize tag names on git-version-gen. --- configure.ac |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 85eeb2f..d9304aa 100644 --- a/configure.ac +++ b/configure.ac @@ -20,7 +20,9 @@

Re: [bug-inetutils] Present release goals

2011-10-24 Thread Guillem Jover
On Sat, 2011-10-15 at 08:22:54 -0400, Alfred M. Szmidt wrote: * The problem with rpl_ioctl() and GNUlib for GNU/kFreeBSD [1] must be resolved. It is beyond my understanding why Simon is not attending to this problem, be it that he prefers GNU/Hurd. We only

[bug-inetutils] [PATCH RFC] Improve dependencies and automake variables

2011-10-24 Thread Guillem Jover
this is settled. thanks, guillem commit eb0f804b827b7a2cb963cb06f888c97fa3ef8794 Author: Guillem Jover guil...@hadrons.org Date: Wed Oct 19 18:25:41 2011 +0200 Improve dependencies and automake variables diff --git a/ftp/Makefile.am b/ftp/Makefile.am index 7cb69f4..7c92e06 100644 --- a/ftp

[bug-inetutils] [PATCH] Use AC_CONFIG_HEADERS instead of AM_CONFIG_HEADER

2011-10-24 Thread Guillem Jover
Commit 12c920a3545ea1f18a20d1a2f46f01b0f744b300, with updated bootstrap script broke the build, as the new script is checking for AC_CONFIG_HEADERS. * configure.ac: Use AC_CONFIG_HEADERS instead of deprecated AM_CONFIG_HEADER. --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1

Re: [bug-inetutils] Re: KR prototypes in ftp/extern.h

2010-12-09 Thread Guillem Jover
Hi! On Sun, 2010-11-28 at 13:51:27 -0500, Alfred M. Szmidt wrote: --- a/ftp/extern.h +++ b/ftp/extern.h @@ -119,7 +119,7 @@ void reset (int, char **); void restart (int, char **); void rmthelp (int, char **); void rmtstatus (int, char **); Any

Re: [bug-inetutils] KR prototypes in ftp/extern.h

2010-11-23 Thread Guillem Jover
Hi! On Fri, 2010-11-19 at 12:43:22 +0100, Simon Josefsson wrote: Mike Frysinger vap...@gentoo.org writes: --- a/ftp/extern.h +++ b/ftp/extern.h @@ -119,7 +119,7 @@ void reset (int, char **); void restart (int, char **); void rmthelp (int, char **); void rmtstatus (int, char **);

Re: [bug-inetutils] On hardcoded pid-files.

2010-11-20 Thread Guillem Jover
On Thu, 2010-11-18 at 12:25:49 -0500, Alfred M. Szmidt wrote: Personally, I'd like to get the whole PID file cruft removed... ftpd, inetd, and what not should return the proper PID via other means. Uh? What other means? The pid needs to be stored somewhere anyway to be

Re: [bug-inetutils] [PATCH] inetd: Listen on connections for tcpmux services

2010-11-17 Thread Guillem Jover
Hi! On Sat, 2010-11-13 at 11:30:26 +0100, Mats Erik Andersson wrote: måndag den 6 september 2010 klockan 11:20 skrev Guillem Jover detta: diff --git a/src/inetd.c b/src/inetd.c index 354ae1d..1c51a51 100644 --- a/src/inetd.c +++ b/src/inetd.c @@ -1161,10 +1161,8 @@ nextconfig (const

Re: [bug-inetutils] Build failure of telnetd in GNU/kFreeBSD.

2010-11-17 Thread Guillem Jover
Hi! On Tue, 2010-11-02 at 23:53:06 +0100, Mats Erik Andersson wrote: I did a test run in GNU/kFreeBSD and came only as far as a compile failure of telnetd/telnetd.o: make: Entering directory `/tmp/inetutils/telnetd' CC telnetd.o In file included from telnetd.h:47,

Re: [bug-inetutils] Two errors in FreeBSD and GNU/kFreeBSD.

2010-11-17 Thread Guillem Jover
Hi! On Wed, 2010-11-03 at 09:42:43 +0100, Mats Erik Andersson wrote: Two minor errors: one at compile time and one at execution time. The latter affects only FreeBSD to my knowledge. From 77fdbe116be59ff19ab23b62db90bcfa534e Mon Sep 17 00:00:00 2001 From: Mats Erik Andersson

Re: [bug-inetutils] [RFC] [PATCH] inetd: Change protocol semantics in inetd.conf

2010-11-17 Thread Guillem Jover
On Mon, 2010-10-18 at 12:47:34 -0400, Alfred M. Szmidt wrote: Applied. Thanks! You applied a modified version of my patch, which introcued few issues. diff --git a/src/inetd.c b/src/inetd.c index 9a43271..0f09386 100644 --- a/src/inetd.c +++ b/src/inetd.c @@ -1001,9 +1002,8 @@

Re: [bug-inetutils] On hardcoded pid-files.

2010-11-17 Thread Guillem Jover
On Fri, 2010-11-05 at 12:45:27 -0400, Alfred M. Szmidt wrote: Personally, I'd like to get the whole PID file cruft removed... ftpd, inetd, and what not should return the proper PID via other means. Uh? What other means? The pid needs to be stored somewhere anyway to be able to control the

Re: [bug-inetutils] [patches] Making Inetutils compilable on OpenBSD.

2010-10-18 Thread Guillem Jover
Hi! On Mon, 2010-10-18 at 16:25:54 +0200, Giuseppe Scrivano wrote: Mats Erik Andersson mats.anders...@gisladisker.se writes: 0002-src-rexec.c- ... : Missing casts to struct sockaddr. why do you need these casts? Because those functions expect 'struct sockaddr' while they are fed

Re: [bug-inetutils] [RFC] [PATCH] inetd: Change protocol semantics in inetd.conf

2010-10-18 Thread Guillem Jover
On Fri, 2010-10-08 at 15:11:11 +0300, Sergey Poznyakoff wrote: I'd like to know if my current approach is acceptable for upstreaming In my opinion, yes, it is. The solution I've implemented is to make tcp and udp IPv4 only, which is what it should be (for now, for compatibility

[bug-inetutils] [PATCH] inetd: Fix segfault when no arguments are provided

2010-09-06 Thread Guillem Jover
* src/inetd.c (getconfigent): If se_argc == 1 inject the normalized se_server name into se_argv[0]. --- src/inetd.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/src/inetd.c b/src/inetd.c index 6fe9adf..354ae1d 100644 --- a/src/inetd.c +++ b/src/inetd.c

[bug-inetutils] [PATCH] inetd: Listen on connections for tcpmux services

2010-09-06 Thread Guillem Jover
* src/inetd.c (nextconfig): Call expand_enter instead of enter for tcpmux services. (fix_tcpmux): Likewise. --- src/inetd.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/inetd.c b/src/inetd.c index 354ae1d..1c51a51 100644 --- a/src/inetd.c +++ b/src/inetd.c @@

[bug-inetutils] [PATCH] Do not check for unused `opie' library

2010-09-06 Thread Guillem Jover
* configure.ac: Remove opie AC_CHECK_LIB check. --- configure.ac |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 80a85b6..528a9b4 100644 --- a/configure.ac +++ b/configure.ac @@ -142,7 +142,6 @@ gl_INIT AC_CHECK_LIB(nsl, inet_ntoa)

Re: [bug-inetutils] [patches 1,2,3] Making tftp/tftpd IPv6-capable.

2010-09-05 Thread Guillem Jover
Hi! On Thu, 2010-08-19 at 10:39:04 +0200, Mats Erik Andersson wrote: diff --git a/libinetutils/sockaddr_aux.c b/libinetutils/sockaddr_aux.c new file mode 100644 index 000..f882f6e --- /dev/null +++ b/libinetutils/sockaddr_aux.c @@ -0,0 +1,98 @@ [...] +/* A collection of helpers

Re: [bug-inetutils] Re: GNU inetutils 1.7 breaks Ubuntu GNU/Linux boot

2010-01-27 Thread Guillem Jover
Hi! On Tue, 2010-01-26 at 19:33:19 +0100, Ludovic Courtès wrote: Inetutils’ ifconfig lacks ‘up’ and ‘down’ for instance: $ sudo ifconfig eth0 down ifconfig: can not resolve `down': Unknown host Exactly, these and several other compatibility options [0] are a long known (well I thought

[bug-inetutils] [PATCH] Tighten mode for set-uid ping binaries

2009-12-05 Thread Guillem Jover
There's no reason to allow the group write-access, even if it's root. * ping/Makefile.am (SUIDMODE): Change mode to `4755'. --- ping/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ping/Makefile.am b/ping/Makefile.am index ec275f6..88b1481 100644 ---

[bug-inetutils] [PATCH 1/2] Split syslogd configuration file loading into a new function

2009-12-05 Thread Guillem Jover
* syslogd/syslogd.c (load_conffile): New function declaration. (init): Move configuration file loading into ... (load_conffile): ... here. New function definition. --- syslogd/syslogd.c | 111 + 1 files changed, 61

[bug-inetutils] [PATCH 2/2] Add support for syslogd configuration files directory

2009-12-05 Thread Guillem Jover
This allows external programs to drop a configuration file in the directory and avoid the need to edit the main configuraion file. * doc/inetutils.texi: Document new -D and --rcdir syslogd options. * paths (PATH_LOGCONFD): New variable. * syslogd/Makefile.am

Re: [bug-inetutils] [PATCH] Use `test -e' instead of `test -r' when testing paths

2009-12-05 Thread Guillem Jover
On Fri, 2009-12-04 at 06:27:23 -0500, Alfred M. Szmidt wrote: While testing paths, ./configure uses test -r to check for those who are not provided by system headers. However, this does not work for root-only files. On hurd-i386 for instance, /dev/klog is only root readable, so

Re: [bug-inetutils] [PATCH] Use socklen_t instead of size_t to fix warnings on 64 bit builds

2009-12-05 Thread Guillem Jover
On Fri, 2009-12-04 at 09:38:05 +0100, Giuseppe Scrivano wrote: The patch looks fine. If you want, I can install it. BTW, when applying patches in git on behalf of someone else, it's useful to preserve the authorship of the patch by either using “git commit --author 'Foo Bar f...@mail'” when

Re: [bug-inetutils] Re: inetutils release...

2009-12-05 Thread Guillem Jover
On Sat, 2009-12-05 at 06:55:37 -0500, Alfred M. Szmidt wrote: Just so that I remeber not release before pending patches have been pushed: - Guillem, call AM_SILENT_RULES; in my queue. It seems you edited this one a bit (da47c16b53c84a9), the reason why I made it conditional on the macro

Re: [bug-inetutils] inetutils release...

2009-12-03 Thread Guillem Jover
Hi! On Thu, 2009-12-03 at 04:50:19 -0500, Alfred M. Szmidt wrote: Does anyone have any thing to commit before I make a release? Could you revert commit fed208adedb4b336135f5f82f0a1430e4d25a4d1 where you removed the man pages? This is a regression I don't want to introduce in the Debian

Re: [bug-inetutils] inetutils release...

2009-12-03 Thread Guillem Jover
On Thu, 2009-12-03 at 13:38:41 -0500, Alfred M. Szmidt wrote: Does anyone have any thing to commit before I make a release? Actually, I've few patches I've been meaning to send, so if it can wait I'll start sending them now. Could you revert commit

Re: [bug-inetutils] [PATCH] Fix compiler warnings

2009-12-03 Thread Guillem Jover
Hi! On Thu, 2009-12-03 at 16:38:37 +0100, Giuseppe Scrivano wrote: This patch fixes any warning reported by gcc 4.3.4 (I haven't yet tried with newer versions). All of them are trivial changes but given the patch size, I think it is better to postpone it after the release. Any comment?

[bug-inetutils] [PATCH] Use socklen_t instead of size_t to fix warnings on 64 bit builds

2009-12-03 Thread Guillem Jover
* ftp/ftp.c (hookup, initconn): Change `len' type from size_t to socklen_t. (dataconn): Change `fromlen' type from size_t to socklen_t. * ftpd/server_mode.c (server_mode): Change `addrlen' type from size_t to socklen_t. * ping/libping.c (ping_recv): Change `fromlen' type from size_t to socklen_t.

[bug-inetutils] [PATCH] Use time_t with time() to fix warning on 64 bit builds

2009-12-03 Thread Guillem Jover
* uucpd/uucpd.c (dologin): New `time_t' variable to use with time(), copy its contents to `ll.ll_time' afterwards. --- uucpd/uucpd.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/uucpd/uucpd.c b/uucpd/uucpd.c index 34f833b..5388d0f 100644 --- a/uucpd/uucpd.c +++

[bug-inetutils] [PATCH] Make the build silent by default with newer automake

2009-12-03 Thread Guillem Jover
This allows seeing warnings more easily and can be disabled globally either with `configure --disable-silent-rules' or on each build with `make V=1', in case the full arguments to the commands is needed, like in debugging situations. * configure.ac (AM_SILENT_RULES): If available, enable the

Re: [bug-inetutils] [PATCH] Mark unused function arguments with ARG_UNUSED

2008-04-14 Thread Guillem Jover
On Mon, 2008-04-14 at 19:20:47 +0530, Debarshi Ray wrote: * syslogd/syslogd.c (init): Add ARG_UNUSED attribute to SIGNO argument. (domark): Likewise. Remove now unneeded no-op SIGNO statement. What about using __attribute__ ((unused)) instead? ARG_UNUSED will

[bug-inetutils] [PATCH] Fix man page warnings

2008-02-20 Thread Guillem Jover
Fixes for problems uncovered when using 'man --warnings=all'. 2008-02-21 Guillem Jover [EMAIL PROTECTED] * inetd/inetd.8: Remove blank lines. * telnet/telnet.1: Change a '.B' to '.Ic'. * telnetd/telnetd.8: Change '\*(lq' to '\*(Lq' and '\*(rq' to '\*(Rq'. Add

Re: [bug-inetutils] Missing MAINTAINERCLEANFILES entry.

2007-03-29 Thread Guillem Jover
On Fri, 2007-03-30 at 01:20:10 +0530, Debarshi 'Rishi' Ray wrote: The ping/Makefile.am does not mention Makefile.in in the MAINTAINERCLEANFILES. Here (http://glug-nith.org/~rishi/download/src/ping-Makefile.diff) is a 'diff -uNp' on ping/Makefile.am: I think those two patches are wrong. From

[bug-inetutils] [patch] Fix typo in configure.ac ifreq member check

2007-03-08 Thread Guillem Jover
Hi, Here's a patch I got for the inetutils package in Debian. This was causing a build failure on GNU/kFreeBSD systems. regards, guillem 2007-03-08 Petr Salinger [EMAIL PROTECTED] * configure.ac (IU_CHECK_MEMBERS): Fix typo 'stuct' - 'struct'. Index: configure.ac

[bug-inetutils] [patch] Do not link against unused libz

2006-10-21 Thread Guillem Jover
Hi, This patch is part of an effort in Debian to reduce unneded dependencies in packages by reducing unneeded linked libraries. 2006-10-21 Guillem Jover [EMAIL PROTECTED] * configure.ac (AC_CHECK_LIB): Remove check for unused libz. Index: configure.ac

[bug-inetutils] [patch] syslogd leaks FILE variables when returning from init

2006-10-21 Thread Guillem Jover
. 2006-10-21 Guillem Jover [EMAIL PROTECTED] * syslogd/init.c (init): Free cf before returning due to not enough memory errors. Index: syslogd/syslogd.c === RCS file: /sources/inetutils/inetutils/syslogd/syslogd.c,v

[bug-inetutils] [patch] in ftpd passing NULL to LOGCMD

2006-10-21 Thread Guillem Jover
Hi, Another one coming from the Coverity reports. 2006-10-21 Guillem Jover [EMAIL PROTECTED] * ftpd/ftpd.c (store): Do not overwrite `name' with gunique's return value, to avoid passing NULL to LOGCMD. Index: ftpd/ftpd.c

[bug-inetutils] [patch] Fix possible segfault in localhost

2006-10-21 Thread Guillem Jover
Hi, More stuff from Coverity. In this case if gethostbyname gets passed a NULL due to gethostname failing and bug being 0, the former would segfault. The change is essentially a missing else, the other changes are indentation fixups. 2006-10-21 Guillem Jover [EMAIL PROTECTED

[bug-inetutils] [patch] fix busy loop when inetd does not listen for any service

2006-06-19 Thread Guillem Jover
Hi, This patch fixes a busy loop when inetd does not have any service, due the use of the non-portable sigpause. It has been applied in the debian package for some time now. 2006-01-10 Guillem Jover [EMAIL PROTECTED] * inetd/inet.c (main): Use sigsuspend on POSIX systems, otherwise

[bug-inetutils] [patch] logger and ifconfig missing to link against gnulib

2006-06-19 Thread Guillem Jover
Hi, Here's another patch to fix logger and ifconfig not building, they are missing linking against gnulib. The ChangeLog entry is the same for both dirs. 2006-03-24 Guillem Jover [EMAIL PROTECTED] * Makefile.am (LDADD): Link against gnulib. --- logger/Makefile.am 2005-10-11 14:29