Re: Gnulib & bootstrap updates

2024-05-08 Thread Guillem Jover
Hi! On Mon, 2024-05-06 at 18:12:53 +0200, Simon Josefsson via Bug reports for the GNU Internet utilities wrote: > I have updated inetutils to latest gnulib (to get the u_* syntax-check > fixes, and the new faster gnulib-tool.py) and refreshed the bootstrap > scripts, please test and report if som

Re: [BUG][PATCH] Someone described a remote DoS Vulnerability in telnetd (dereference NULL pointer ---> SEGV)

2022-09-07 Thread Guillem Jover
[ Resending with To trimmed. ] Hi! On Tue, 2022-08-30 at 22:57:51 +0200, Guillem Jover wrote: > On Sun, 2022-08-28 at 14:40:44 +0200, Erik Auerswald wrote: > > On Sat, Aug 27, 2022 at 07:37:15PM +0200, Erik Auerswald wrote: > > > someone has described a remote DoS vulnerabi

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

2022-09-03 Thread Guillem Jover
[ Removed Erik from To, as last time my mail was rejected by the mail server, and might then not get delivered by mailman as duplicate. ] Hi! On Sat, 2022-09-03 at 19:07:52 +0200, Erik Auerswald wrote: > AFAIK the other fuzzer-based crash reports have already been addressed > before the release

Re: [BUG][PATCH] Someone described a remote DoS Vulnerability in telnetd (dereference NULL pointer ---> SEGV)

2022-08-30 Thread Guillem Jover
Hi! On Sun, 2022-08-28 at 14:40:44 +0200, Erik Auerswald wrote: > On Sat, Aug 27, 2022 at 07:37:15PM +0200, Erik Auerswald wrote: > > someone has described a remote DoS vulnerability in > > many telnetd implementations that I just happened to > > stumble over: > > > > https://pierrekim.github.io/

Re: telnetd security vulnerability CVE-2020-10188

2020-04-11 Thread Guillem Jover
On Sat, 2020-04-11 at 13:03:34 -0400, Alfred M. Szmidt wrote: >> Thank you for your bug report, please specify which inetutils versions >> you are refering to in pristine condition without any patches. You >> mention an assert, which assert exactly? > >The inetutils version in Deb

Re: telnetd security vulnerability CVE-2020-10188

2020-04-10 Thread Guillem Jover
[ For some reason, I've not received the message from the list, and just happened to notice it from the web archive, so reconstructing the reply from there… ] On Fri, 2020-04-10 at 15:04:20 -0400, Alfred M. Szmidt wrote: > On Wed, 2020-04-08 at 13:41:58 +0200, Guillem Jover wrote:

telnetd security vulnerability CVE-2020-10188

2020-04-08 Thread Guillem Jover
Hi! I've been notified of a security vulnerability in inetutils telnetd, which was reported initially against netkit-telnet, but that one has been fixed in Debian for a very long time (around two decades ago [N]). But the code inherited from the BSDs seems to still be around in inetutils. I've not

Re: [bug-inetutils] bug: inetd does not map IPv6 to IPv4

2018-01-05 Thread Guillem Jover
Hi! On Thu, 2018-01-04 at 12:36:36 +0100, Ferruccio Fantozzi wrote: > I think I found a problem in the way inetd maps IPv4/IPv6 connections. > > When protocol in inetd.conf is set as > 'tcp': inetd accepts IPv4 connections only > 'tcp4': same as above > 'tcp6only': inetd accepts IPv6 connections

Re: [bug-inetutils] Buffer overflow for gnu inetutils telnetd

2017-07-11 Thread Guillem Jover
Thanks Chris for the report! Here's a patch fixing the issue, which was obvious by just looking at the code indicated by the warning. Thanks, Guillem From c4f1bc8e2e9e6303a33e1babfffafef9aa628c49 Mon Sep 17 00:00:00 2001 From: Guillem Jover Date: Tue, 11 Jul 2017 12:22:41 +0200 Subject: [PATC

[bug-inetutils] [PATCH] ftp: Fix typo

2015-06-05 Thread Guillem Jover
--- ftp/cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ftp/cmds.c b/ftp/cmds.c index c12f24c..f9731dc 100644 --- a/ftp/cmds.c +++ b/ftp/cmds.c @@ -363,7 +363,7 @@ setpeer (int argc, char **argv) unix_server = 0; if (overbose && !strncmp (reply_stri

Re: [bug-inetutils] 1.9.3 regression: ifconfig called without any option doesn't show status of all interfaces

2015-05-20 Thread Guillem Jover
Hey! On Tue, 2015-05-19 at 20:39:20 +0200, Mats Erik Andersson wrote: > Tuesday den 19 May 2015 klockan 08:15 skrev Alfred M. Szmidt detta: > > We should make a bug fix release to fix this issue for upstream. I'll > > do it. > > I want to include a fix needed by FreeBSD 11 for our ifconfig. > Th

[bug-inetutils] syslogd vulnerable to CVE-2014-3634?

2014-10-03 Thread Guillem Jover
Hi! I just stumbled over this on , and from a cursory glance it appears as if inetutils' syslogd is also vulnerable? There's a patch there that seems would apply w/o much effort. I think this would be a good excuse to do a release, with a nice timing now th

[bug-inetutils] Issues with git-version-gen output

2013-12-22 Thread Guillem Jover
Hi! I've just uploaded a git snapshot to Debian, but I found the current git-version-gen output, as setup in configure.ac, to be problematic. See this transcript: # Up-to-date master, current Debian snapshot $ git describe inetutils-1_9_1_100-18-gbbc1c28 $ build-aux/git-version-gen .tarb

Re: [bug-inetutils] New release?

2013-05-10 Thread Guillem Jover
Heya, On Tue, 2013-05-07 at 19:14:33 +0200, Guillem Jover wrote: > There's quite some work accumulated in master since the 1.9.1 release > (around 280 commits, with lots of fixes and improvements), I'd like to > upload a new version to Debian (and preferably not a git snapshot

[bug-inetutils] New release?

2013-05-07 Thread Guillem Jover
Hi! There's quite some work accumulated in master since the 1.9.1 release (around 280 commits, with lots of fixes and improvements), I'd like to upload a new version to Debian (and preferably not a git snapshot), could we got a release going on? Thanks, Guillem

Re: [bug-inetutils] [PATCH] Cleanup automake variables

2013-01-28 Thread Guillem Jover
On Fri, 2013-01-25 at 10:19:17 +0100, Mats Erik Andersson wrote: > Accepted as stated with a single exception: The use of PATHDEF_LOGCONFD > is a Debian-specific extension. [...] The patching of > "src/inetd.c" is still all your responsibility. Sorry about that, it was not intentional, I just happ

[bug-inetutils] [PATCH] ping: Abort on sendto () error

2013-01-13 Thread Guillem Jover
* ping/libping.c (ping_xmit): Return -1 instead of calling perror () on sendto () error. * ping/ping6.c (ping_xmit): Likewise. (send_echo): Error out instead of continuing sending packets. * ping/ping.c (send_echo): Likewise. --- ping/libping.c | 2 +- ping/ping.c| 8 +++- ping/ping6.c

[bug-inetutils] [PATCH] Cleanup automake variables

2013-01-13 Thread Guillem Jover
Hi, Here's the patch cleaning up the automake variables a bit, originally sent some time ago [0]. It moves the global ones to the top of the file as they affect all following rules. Splits long lines into ones not over 80 chars. Switches INCLUDES to AM_CPPFLAGS. Refactors common flags into global

Re: [bug-inetutils] Broken with aclocal-1.13.1.

2013-01-05 Thread Guillem Jover
On Sat, 2013-01-05 at 14:14:13 +0100, Mats Erik Andersson wrote: > Removing AM_C_PROTOTYPES from "configure.ac" repairs the > bootstrap sufficiently to succeed, but leaves many complaints > on INCLUDES versus AM_CPPFLAGS. I sent a patch long time ago to switch away from the obsolete INCLUDES direc

Re: [bug-inetutils] inetutils vs. Inetutils vs. ...

2012-03-16 Thread Guillem Jover
On Thu, 2012-03-15 at 15:17:09 -0400, Alfred M. Szmidt wrote: > I remeber asking this ages ago, should we write: > > GNU inetutils > > or > > GNU Inetutils > > ? At least AC_INIT says the project name is “GNU inetutils”. regards, guillem

Re: [bug-inetutils] Overriding SUID installs.

2012-02-01 Thread Guillem Jover
On Thu, 2012-02-02 at 00:53:40 +0100, Mats Erik Andersson wrote: > would the change below make sense, allowing vendors and builders > to override a strong SUID assignment? > -SUIDMODE = -o root -m 4775 > +SUIDMODE ?= -o root -m 4775 That's not really needed, one can already override it through th

Re: [bug-inetutils] Lib dependencies in "src/".

2012-01-28 Thread Guillem Jover
provide a ChangeLog entry later on. thanks, guillem commit 798776bd8ce3435d3129953d0a257fa43b0dde4b Author: Guillem Jover Date: Wed Oct 19 18:25:41 2011 +0200 Remove unneeded shared library dependencies diff --git a/src/Makefile.am b/src/Makefile.am index 2666597..729dfc0 100644 --- a/sr

Re: [bug-inetutils] Readline code

2011-11-20 Thread Guillem Jover
On Sat, 2011-11-19 at 12:21:48 +0100, Mats Erik Andersson wrote: > The new TELNET server is verified on GNU/OpenSolaris, but still > shows the unrelated "TERM='TERM=linux'" error! That's probably due to the value of login_invocation in telnetd/telnetd.c. regards, guillem

[bug-inetutils] [PATCH] Use AC_CONFIG_HEADERS instead of AM_CONFIG_HEADER

2011-10-24 Thread Guillem Jover
Commit 12c920a3545ea1f18a20d1a2f46f01b0f744b300, with updated bootstrap script broke the build, as the new script is checking for AC_CONFIG_HEADERS. * configure.ac: Use AC_CONFIG_HEADERS instead of deprecated AM_CONFIG_HEADER. --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deleti

[bug-inetutils] [PATCH RFC] Improve dependencies and automake variables

2011-10-24 Thread Guillem Jover
ce this is settled. thanks, guillem commit eb0f804b827b7a2cb963cb06f888c97fa3ef8794 Author: Guillem Jover Date: Wed Oct 19 18:25:41 2011 +0200 Improve dependencies and automake variables diff --git a/ftp/Makefile.am b/ftp/Makefile.am index 7cb69f4..7c92e06 100644 --- a/ftp/Makefile.am

Re: [bug-inetutils] Present release goals

2011-10-24 Thread Guillem Jover
On Sat, 2011-10-15 at 08:22:54 -0400, Alfred M. Szmidt wrote: >* The problem with rpl_ioctl() and GNUlib for GNU/kFreeBSD > [1] must be resolved. It is beyond my understanding why > Simon is not attending to this problem, be it that he > prefers GNU/Hurd. > > We

[bug-inetutils] [PATCH] Update .gitignore files

2011-10-24 Thread Guillem Jover
* .gitignore: Updated by boostrap. * doc/.gitignore: Likewise. * tests/.gitignore: Add addrpeek. --- .gitignore |3 ++- doc/.gitignore |4 ++-- tests/.gitignore |1 + 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index 1b19fff..a17d837 1

[bug-inetutils] [PATCH] Re-include needed for NULL

2011-10-24 Thread Guillem Jover
Partially reverts 1647134d6cac7ffcb11dcf576826b1bb079467c5. * libicmp/icmp_timestamp.c: Include . --- libicmp/icmp_timestamp.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/libicmp/icmp_timestamp.c b/libicmp/icmp_timestamp.c index 8c0020b..e04fdad 100644 --- a/libicmp/

[bug-inetutils] [PATCH] build: Add a sed script to normalize git tags

2011-10-24 Thread Guillem Jover
* configure.ac (AC_INIT): Use a sed script to normalize tag names on git-version-gen. --- configure.ac |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 85eeb2f..d9304aa 100644 --- a/configure.ac +++ b/configure.ac @@ -20,7 +20,9 @@ AC

Re: [bug-inetutils] Present release goals

2011-10-24 Thread Guillem Jover
Hi! On Wed, 2011-10-12 at 19:44:36 +0200, Mats Erik Andersson wrote: > Thus I propose we only do the last polishing for a release > in a close future, followed by a small set of new goals for > a next release, which could take place fairly rapidly, still > calling it a major release. I've some qu

Re: [bug-inetutils] Re: K&R prototypes in ftp/extern.h

2010-12-09 Thread Guillem Jover
Hi! On Sun, 2010-11-28 at 13:51:27 -0500, Alfred M. Szmidt wrote: >>> > --- a/ftp/extern.h >>> > +++ b/ftp/extern.h >>> > @@ -119,7 +119,7 @@ void reset (int, char **); >>> > void restart (int, char **); >>> > void rmthelp (int, char **); >>> > void rmtstatus (int, char

Re: [bug-inetutils] K&R prototypes in ftp/extern.h

2010-11-23 Thread Guillem Jover
Hi! On Fri, 2010-11-19 at 12:43:22 +0100, Simon Josefsson wrote: > Mike Frysinger writes: > > --- a/ftp/extern.h > > +++ b/ftp/extern.h > > @@ -119,7 +119,7 @@ void reset (int, char **); > > void restart (int, char **); > > void rmthelp (int, char **); > > void rmtstatus (int, char **); > > A

Re: [bug-inetutils] On hardcoded pid-files.

2010-11-20 Thread Guillem Jover
On Thu, 2010-11-18 at 12:25:49 -0500, Alfred M. Szmidt wrote: >> > Personally, I'd like to get the whole PID file cruft removed... ftpd, >> > inetd, and what not should return the proper PID via other means. >> >> Uh? What other means? The pid needs to be stored somewhere anyway t

Re: [bug-inetutils] On hardcoded pid-files.

2010-11-17 Thread Guillem Jover
On Fri, 2010-11-05 at 12:45:27 -0400, Alfred M. Szmidt wrote: > Personally, I'd like to get the whole PID file cruft removed... ftpd, > inetd, and what not should return the proper PID via other means. Uh? What other means? The pid needs to be stored somewhere anyway to be able to control the dae

Re: [bug-inetutils] [RFC] [PATCH] inetd: Change protocol semantics in inetd.conf

2010-11-17 Thread Guillem Jover
On Mon, 2010-10-18 at 12:47:34 -0400, Alfred M. Szmidt wrote: > Applied. Thanks! You applied a modified version of my patch, which introcued few issues. > diff --git a/src/inetd.c b/src/inetd.c > index 9a43271..0f09386 100644 > --- a/src/inetd.c > +++ b/src/inetd.c > @@ -1001,9 +1002,8 @@ getcon

Re: [bug-inetutils] Two errors in FreeBSD and GNU/kFreeBSD.

2010-11-17 Thread Guillem Jover
Hi! On Wed, 2010-11-03 at 09:42:43 +0100, Mats Erik Andersson wrote: > Two minor errors: one at compile time and one > at execution time. The latter affects only > FreeBSD to my knowledge. > From 77fdbe116be59ff19ab23b62db90bcfa534e Mon Sep 17 00:00:00 2001 > From: Mats Erik Andersson > Date

Re: [bug-inetutils] Build failure of telnetd in GNU/kFreeBSD.

2010-11-17 Thread Guillem Jover
Hi! On Tue, 2010-11-02 at 23:53:06 +0100, Mats Erik Andersson wrote: > I did a test run in GNU/kFreeBSD and came only as far > as a compile failure of telnetd/telnetd.o: >make: Entering directory `/tmp/inetutils/telnetd' > CC telnetd.o >In file included from telnetd.h:47, >

Re: [bug-inetutils] [PATCH] inetd: Listen on connections for tcpmux services

2010-11-17 Thread Guillem Jover
Hi! On Sat, 2010-11-13 at 11:30:26 +0100, Mats Erik Andersson wrote: > måndag den 6 september 2010 klockan 11:20 skrev Guillem Jover detta: > > diff --git a/src/inetd.c b/src/inetd.c > > index 354ae1d..1c51a51 100644 > > --- a/src/inetd.c > > +++ b/src/inet

Re: [bug-inetutils] [RFC] [PATCH] inetd: Change protocol semantics in inetd.conf

2010-10-18 Thread Guillem Jover
On Fri, 2010-10-08 at 15:11:11 +0300, Sergey Poznyakoff wrote: > > I'd like to know if my current approach is acceptable for > > upstreaming > > In my opinion, yes, it is. > > > The solution I've implemented is to make tcp and udp IPv4 only, which > > is what it should be (for now, for compatibil

Re: [bug-inetutils] [patches] Making Inetutils compilable on OpenBSD.

2010-10-18 Thread Guillem Jover
Hi! On Mon, 2010-10-18 at 16:25:54 +0200, Giuseppe Scrivano wrote: > Mats Erik Andersson writes: > > > 0002-src-rexec.c- ... : Missing casts to "struct sockaddr". > > why do you need these casts? Because those functions expect 'struct sockaddr' while they are fed 'struct sockaddr_in'. regar

[bug-inetutils] [RFC] [PATCH] inetd: Change protocol semantics in inetd.conf

2010-10-08 Thread Guillem Jover
v6 only and adding tcp46/udp46 for IPv4 mapped addresses. Attached is the current patch I've applied to inetutils 1.8-1 in experimental. thanks, guillem >From ee6ea58645a4db63f6ccad40566b37b23279797e Mon Sep 17 00:00:00 2001 From: Guillem Jover Date: Mon, 6 Sep 2010 10:52:27 +0200 Subject: [

Re: [bug-inetutils] [PATCH] Make `tftpd' IPv6-compatible

2010-09-07 Thread Guillem Jover
Hi! On Tue, 2010-09-07 at 18:05:37 +0200, Ludovic Courtès wrote: > The attached patch makes ‘tftpd’ IPv6-compatible. As a side effect, it > makes it usable (!) on current GNU/Linux when a client connects via an > address other than the loopback address (FROM is always AF_INET6 on my > machine.) >

Re: [bug-inetutils] [patches 1,2,3] Making tftp/tftpd IPv6-capable.

2010-09-07 Thread Guillem Jover
t; söndag den 5 september 2010 klockan 23:05 skrev Guillem Jover detta: > > On Thu, 2010-08-19 at 10:39:04 +0200, Mats Erik Andersson wrote: > > > diff --git a/libinetutils/sockaddr_aux.c b/libinetutils/sockaddr_aux.c > > > new file mode 100644 > > > index 000..f88

[bug-inetutils] [PATCH] Do not check for unused `opie' library

2010-09-06 Thread Guillem Jover
* configure.ac: Remove opie AC_CHECK_LIB check. --- configure.ac |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 80a85b6..528a9b4 100644 --- a/configure.ac +++ b/configure.ac @@ -142,7 +142,6 @@ gl_INIT AC_CHECK_LIB(nsl, inet_ntoa) AC_CH

[bug-inetutils] [PATCH] inetd: Listen on connections for tcpmux services

2010-09-06 Thread Guillem Jover
* src/inetd.c (nextconfig): Call expand_enter instead of enter for tcpmux services. (fix_tcpmux): Likewise. --- src/inetd.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/inetd.c b/src/inetd.c index 354ae1d..1c51a51 100644 --- a/src/inetd.c +++ b/src/inetd.c @@ -

[bug-inetutils] [PATCH] inetd: Fix segfault when no arguments are provided

2010-09-06 Thread Guillem Jover
* src/inetd.c (getconfigent): If se_argc == 1 inject the normalized se_server name into se_argv[0]. --- src/inetd.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/src/inetd.c b/src/inetd.c index 6fe9adf..354ae1d 100644 --- a/src/inetd.c +++ b/src/inetd.c @@

Re: [bug-inetutils] [patches 1,2,3] Making tftp/tftpd IPv6-capable.

2010-09-05 Thread Guillem Jover
Hi! On Thu, 2010-08-19 at 10:39:04 +0200, Mats Erik Andersson wrote: > diff --git a/libinetutils/sockaddr_aux.c b/libinetutils/sockaddr_aux.c > new file mode 100644 > index 000..f882f6e > --- /dev/null > +++ b/libinetutils/sockaddr_aux.c > @@ -0,0 +1,98 @@ [...] > +/* A collection of helpers i

Re: [bug-inetutils] Re: GNU inetutils 1.7 breaks Ubuntu GNU/Linux boot

2010-01-27 Thread Guillem Jover
Hi! On Tue, 2010-01-26 at 19:33:19 +0100, Ludovic Courtès wrote: > Inetutils’ ifconfig lacks ‘up’ and ‘down’ for instance: > > $ sudo ifconfig eth0 down > ifconfig: can not resolve `down': Unknown host Exactly, these and several other compatibility options [0] are a long known (well I though

Re: [bug-inetutils] Re: inetutils release...

2009-12-05 Thread Guillem Jover
On Sat, 2009-12-05 at 06:55:37 -0500, Alfred M. Szmidt wrote: > Just so that I remeber not release before pending patches have been > pushed: > > - Guillem, call AM_SILENT_RULES; in my queue. It seems you edited this one a bit (da47c16b53c84a9), the reason why I made it conditional on the macro e

Re: [bug-inetutils] [PATCH] Use socklen_t instead of size_t to fix warnings on 64 bit builds

2009-12-05 Thread Guillem Jover
On Fri, 2009-12-04 at 09:38:05 +0100, Giuseppe Scrivano wrote: > The patch looks fine. If you want, I can install it. BTW, when applying patches in git on behalf of someone else, it's useful to preserve the authorship of the patch by either using “git commit --author 'Foo Bar '” when applying the

Re: [bug-inetutils] [PATCH] Use `test -e' instead of `test -r' when testing paths

2009-12-05 Thread Guillem Jover
On Fri, 2009-12-04 at 06:27:23 -0500, Alfred M. Szmidt wrote: >While testing paths, ./configure uses test -r to check for those who >are not provided by system headers. However, this does not work for >root-only files. On hurd-i386 for instance, /dev/klog is only root >readable, s

[bug-inetutils] [PATCH 2/2] Add support for syslogd configuration files directory

2009-12-05 Thread Guillem Jover
This allows external programs to drop a configuration file in the directory and avoid the need to edit the main configuraion file. * doc/inetutils.texi: Document new -D and --rcdir syslogd options. * paths (PATH_LOGCONFD): New variable. * syslogd/Makefile.am (AM_CPP

[bug-inetutils] [PATCH 1/2] Split syslogd configuration file loading into a new function

2009-12-05 Thread Guillem Jover
* syslogd/syslogd.c (load_conffile): New function declaration. (init): Move configuration file loading into ... (load_conffile): ... here. New function definition. --- syslogd/syslogd.c | 111 + 1 files changed, 61 insert

[bug-inetutils] [PATCH] Tighten mode for set-uid ping binaries

2009-12-05 Thread Guillem Jover
There's no reason to allow the group write-access, even if it's root. * ping/Makefile.am (SUIDMODE): Change mode to `4755'. --- ping/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ping/Makefile.am b/ping/Makefile.am index ec275f6..88b1481 100644 ---

[bug-inetutils] [PATCH] Fix race condition making syslogd exit with non-zero status

2009-12-05 Thread Guillem Jover
There's a race condition when the parent sets up the SIGALRM and the child tries to notify its parent the initialization has finished, causing it to exit with a non-zero status. We setup our own SIGTERM handler before calling waitdaemon instead. * syslogd/syslogd.c (doexit): New function d

[bug-inetutils] [PATCH] Remove unneeded check for libbsd

2009-12-05 Thread Guillem Jover
The rest of the code to replace the revoke function was removed in commit 3f8ccc2a111b6b292f2a8c4a17ce91e322aea664, remove the remaning bits. * configure.ac: Remove libbsd check. --- configure.ac |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/configure.ac b/confi

[bug-inetutils] [PATCH] Do not segfault on lines without a new line character

2009-12-05 Thread Guillem Jover
* hostname/hostname.c (parse_file): Remove initial getline. Change `while { }' to `do { } while'. Move getline in the loop to the beginning. --- hostname/hostname.c | 15 ++- 1 files changed, 6 insertions(+), 9 deletions(-) diff --git a/hostname/hostname.c b

[bug-inetutils] [PATCH] Use `test -e' instead of `test -r' when testing paths

2009-12-03 Thread Guillem Jover
From: Samuel Thibault While testing paths, ./configure uses test -r to check for those who are not provided by system headers. However, this does not work for root-only files. On hurd-i386 for instance, /dev/klog is only root readable, so the test fails, and thus inetutils-syslogd doesn't fill

[bug-inetutils] [PATCH] Make the build silent by default with newer automake

2009-12-03 Thread Guillem Jover
This allows seeing warnings more easily and can be disabled globally either with `configure --disable-silent-rules' or on each build with `make V=1', in case the full arguments to the commands is needed, like in debugging situations. * configure.ac (AM_SILENT_RULES): If available, enable the silen

[bug-inetutils] [PATCH] Use time_t with time() to fix warning on 64 bit builds

2009-12-03 Thread Guillem Jover
* uucpd/uucpd.c (dologin): New `time_t' variable to use with time(), copy its contents to `ll.ll_time' afterwards. --- uucpd/uucpd.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/uucpd/uucpd.c b/uucpd/uucpd.c index 34f833b..5388d0f 100644 --- a/uucpd/uucpd.c +++ b/uuc

[bug-inetutils] [PATCH] Use a temporary `struct timeval' for gettimeofday

2009-12-03 Thread Guillem Jover
The utmp structures match the on-disk format, and need to have the same size independent of the wordsize of the machine. So we use timeval for gettimeofday and copy the results to avoid any damage to the variables. * ftpd/logwtmp.c (logwtmp) [_HAVE_UT_TV]: Use a `struct timeval' variable to get th

[bug-inetutils] [PATCH] Use socklen_t instead of size_t to fix warnings on 64 bit builds

2009-12-03 Thread Guillem Jover
* ftp/ftp.c (hookup, initconn): Change `len' type from size_t to socklen_t. (dataconn): Change `fromlen' type from size_t to socklen_t. * ftpd/server_mode.c (server_mode): Change `addrlen' type from size_t to socklen_t. * ping/libping.c (ping_recv): Change `fromlen' type from size_t to socklen_t. *

Re: [bug-inetutils] [PATCH] Fix compiler warnings

2009-12-03 Thread Guillem Jover
Hi! On Thu, 2009-12-03 at 16:38:37 +0100, Giuseppe Scrivano wrote: > This patch fixes any warning reported by gcc 4.3.4 (I haven't yet tried > with newer versions). All of them are trivial changes but given the > patch size, I think it is better to postpone it after the release. > > Any comment?

Re: [bug-inetutils] inetutils release...

2009-12-03 Thread Guillem Jover
On Thu, 2009-12-03 at 13:38:41 -0500, Alfred M. Szmidt wrote: >> Does anyone have any thing to commit before I make a release? Actually, I've few patches I've been meaning to send, so if it can wait I'll start sending them now. >Could you revert commit fed208adedb4b336135f5f82f0a1430e4d25

Re: [bug-inetutils] inetutils release...

2009-12-03 Thread Guillem Jover
Hi! On Thu, 2009-12-03 at 04:50:19 -0500, Alfred M. Szmidt wrote: > Does anyone have any thing to commit before I make a release? Could you revert commit fed208adedb4b336135f5f82f0a1430e4d25a4d1 where you removed the man pages? This is a regression I don't want to introduce in the Debian packages

Re: [bug-inetutils] Re: [SCM] GNU Inetutils branch, master, updated. release_1_5-220-gd3080c5

2009-11-14 Thread Guillem Jover
On Fri, 2009-11-13 at 17:37:09 +0100, Simon Josefsson wrote: > "Alfred M. Szmidt" writes: > >index c7d78f8..6cfdbb9 100644 > >--- a/hostname/Makefile.am > >+++ b/cfg.mk > > > > Is that really current? I sense something immensly strange... > > It seems to be an artifact of how savanna

Re: [bug-inetutils] ping: -c 0 vs. -c 3 as default..

2009-04-29 Thread Guillem Jover
On Tue, 2009-04-28 at 13:30:39 -0400, Jeff Bailey wrote: > On Tue, Apr 28, 2009 at 12:58 PM, Alfred M. Szmidt wrote: > > And I don't think I've ever liked the change, and I'm happy it has > > been reverted now, so I think I'll be packaging a git snapshot for > > Debian pretty soon. > > > > I

Re: [bug-inetutils] ping: -c 0 vs. -c 3 as default..

2009-04-27 Thread Guillem Jover
Hi, On Mon, 2009-04-27 at 07:33:42 -0400, Alfred M. Szmidt wrote: > Does anyone rember why we changed the default behaviour for ping from > -c3 to -c0? > > I'd like tto write a very short rationale for it.. Cause I always > forget why we changed it.. Your initial reasons (to change from -c0 to -

Re: [bug-inetutils] ping

2008-06-03 Thread Guillem Jover
Hi, On Wed, 2008-06-04 at 03:28:05 +0530, Debarshi Ray wrote: > Could be possible without adding the --multiple switch. Here is a > possible approach: This is the same way fping works. It also has some other interesting options, like specifying a range of IPs through a netmask or start/end IP, re

Re: [bug-inetutils] [PATCH] Mark unused function arguments with ARG_UNUSED

2008-04-14 Thread Guillem Jover
On Mon, 2008-04-14 at 19:20:47 +0530, Debarshi Ray wrote: > > * syslogd/syslogd.c (init): Add ARG_UNUSED attribute to SIGNO > > argument. > > (domark): Likewise. Remove now unneeded no-op SIGNO statement. > > What about using "__attribute__ ((unused))" instead? ARG_UNUSED

[bug-inetutils] [PATCH] Mark unused function arguments with ARG_UNUSED

2008-02-21 Thread Guillem Jover
2008-02-22 Guillem Jover <[EMAIL PROTECTED]> * syslogd/syslogd.c (init): Add ARG_UNUSED attribute to SIGNO argument. (domark): Likewise. Remove now unneeded no-op SIGNO statement. --- syslogd/syslogd.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)

[bug-inetutils] [PATCH] Fix man page warnings

2008-02-20 Thread Guillem Jover
Fixes for problems uncovered when using 'man --warnings=all'. 2008-02-21 Guillem Jover <[EMAIL PROTECTED]> * inetd/inetd.8: Remove blank lines. * telnet/telnet.1: Change a '.B' to '.Ic'. * telnetd/telnetd.8: Change '\*(lq'

Re: [bug-inetutils] Missing MAINTAINERCLEANFILES entry.

2007-03-29 Thread Guillem Jover
On Fri, 2007-03-30 at 01:20:10 +0530, Debarshi 'Rishi' Ray wrote: > The ping/Makefile.am does not mention Makefile.in in the > MAINTAINERCLEANFILES. Here > (http://glug-nith.org/~rishi/download/src/ping-Makefile.diff) is a > 'diff -uNp' on ping/Makefile.am: I think those two patches are wrong. Fro

[bug-inetutils] [patch] Fix typo in configure.ac ifreq member check

2007-03-08 Thread Guillem Jover
Hi, Here's a patch I got for the inetutils package in Debian. This was causing a build failure on GNU/kFreeBSD systems. regards, guillem 2007-03-08 Petr Salinger <[EMAIL PROTECTED]> * configure.ac (IU_CHECK_MEMBERS): Fix typo 'stuct' -> 'struct'. Index: configure.ac ===

[bug-inetutils] Fwd: Bug#395218: inetutils: xmalloc return val implicitly converted to int

2006-10-25 Thread Guillem Jover
Hi, I got another patch from Dann. - Forwarded message from dann frazier <[EMAIL PROTECTED]> - Date: Wed, 25 Oct 2006 10:59:21 -0600 From: dann frazier <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Reply-To: dann frazier <[EMAIL PROTECTED]>, [EMAIL PROTECTED] Subject: Bug#395218: inetutils:

[bug-inetutils] Fwd: Bug#395216: inetutils: getpass return implicitly converted to int

2006-10-25 Thread Guillem Jover
Hi, I got this bug report with a patch from Dann Frazier in Debian. - Forwarded message from dann frazier <[EMAIL PROTECTED]> - Date: Wed, 25 Oct 2006 10:57:58 -0600 From: dann frazier <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Reply-To: dann frazier <[EMAIL PROTECTED]>, [EMAIL PROTECTED]

[bug-inetutils] [patch] Fix possible segfault in localhost

2006-10-21 Thread Guillem Jover
Hi, More stuff from Coverity. In this case if gethostbyname gets passed a NULL due to gethostname failing and bug being 0, the former would segfault. The change is essentially a missing "else", the other changes are indentation fixups. 2006-10-21 Guillem Jover <[EM

[bug-inetutils] [patch] in ftpd passing NULL to LOGCMD

2006-10-21 Thread Guillem Jover
Hi, Another one coming from the Coverity reports. 2006-10-21 Guillem Jover <[EMAIL PROTECTED]> * ftpd/ftpd.c (store): Do not overwrite `name' with gunique's return value, to avoid passing NULL to LOGCMD. In

[bug-inetutils] [patch] syslogd leaks FILE variables when returning from init

2006-10-21 Thread Guillem Jover
hough. 2006-10-21 Guillem Jover <[EMAIL PROTECTED]> * syslogd/init.c (init): Free cf before returning due to not enough memory errors. Index: syslogd/syslogd.c === RCS file: /sources/inetutils/inetutils/syslogd/

[bug-inetutils] [patch] Fix typos in inetd manpage

2006-10-21 Thread Guillem Jover
Hi, This one fixes some typos in the inetd manpage. 2006-10-21 Stephen Liebbe <[EMAIL PROTECTED]> * inetd/inetd.8: Fix typos. Index: inetd/inetd.8 === RCS file: /sources/inetutils/inetutils/inetd/inetd.8,v retrieving re

[bug-inetutils] [patch] Do not link against unused libz

2006-10-21 Thread Guillem Jover
Hi, This patch is part of an effort in Debian to reduce unneded dependencies in packages by reducing unneeded linked libraries. 2006-10-21 Guillem Jover <[EMAIL PROTECTED]> * configure.ac (AC_CHECK_LIB): Remove check for unused libz. Index: config

[bug-inetutils] [patch] enable reading /dev/klog on the Hurd

2006-06-19 Thread Guillem Jover
Hi, This patch enables syslogd to read /dev/klog on the Hurd (and probably other systems), as there that variable does not come from confpaths.h. 2006-03-24 Samuel Thibault <[EMAIL PROTECTED]> * Makefile.am (INCLUDES): Add PATHDEF_KLOG. --- syslogd/Makefile.am 2005-10-11 14:29:12.00

[bug-inetutils] [patch] logger and ifconfig missing to link against gnulib

2006-06-19 Thread Guillem Jover
Hi, Here's another patch to fix logger and ifconfig not building, they are missing linking against gnulib. The ChangeLog entry is the same for both dirs. 2006-03-24 Guillem Jover <[EMAIL PROTECTED]> * Makefile.am (LDADD): Link against gnulib. --- logger/Makefile.am 20

[bug-inetutils] [patch] fix implicit and invalid casts from pointer to int

2006-06-19 Thread Guillem Jover
Hi, This patch fixes implicit and invalid casts from pointer to int that will cause problems on 64 bit arches. ftp/ChangeLog 2006-03-24 Dann Frazier <[EMAIL PROTECTED]> * main.c [HAVE_LIBREADLINE]: Include 'readline/readline.h'. --- ftp/main.c 2002-04-29 14:40:30.0 -0600 ++

[bug-inetutils] [patch] fix busy loop when inetd does not listen for any service

2006-06-19 Thread Guillem Jover
Hi, This patch fixes a busy loop when inetd does not have any service, due the use of the non-portable sigpause. It has been applied in the debian package for some time now. 2006-01-10 Guillem Jover <[EMAIL PROTECTED]> * inetd/inet.c (main): Use sigsuspend on POSIX systems, oth

[bug-inetutils] [patch] fix implicit and invalid casts from pointer to int

2006-04-19 Thread Guillem Jover
Hi, This patch fixes implicit and invalid casts from pointer to int that will cause problems on 64 bit arches. ftp/ChangeLog 2006-03-24 Dann Frazier <[EMAIL PROTECTED]> * main.c [HAVE_LIBREADLINE]: Include 'readline/readline.h'. --- ftp/main.c 2002-04-29 14:40:30.0 -0600 ++

[bug-inetutils] [patch] enable reading /dev/klog on the Hurd

2006-04-19 Thread Guillem Jover
Hi, This patch enables syslogd to read /dev/klog on the Hurd (and probably other systems), as there that variable does not come from confpaths.h. 2006-03-24 Samuel Thibault <[EMAIL PROTECTED]> * Makefile.am (INCLUDES): Add PATHDEF_KLOG. --- syslogd/Makefile.am 2005-10-11 14:29:12.00

[bug-inetutils] [patch] logger and ifconfig missing to link against gnulib

2006-04-19 Thread Guillem Jover
Hi, Here's another patch to fix logger and ifconfig not building, they are missing linking against gnulib. The ChangeLog entry is the same for both dirs. 2006-03-24 Guillem Jover <[EMAIL PROTECTED]> * Makefile.am (LDADD): Link against gnulib. --- logger/Makefile.am 20

[bug-inetutils] [patch] fix busy loop when inetd does not listen for any service

2006-04-19 Thread Guillem Jover
e now. 2006-01-10 Guillem Jover <[EMAIL PROTECTED]> * inetd/inet.c (main): Use sigsuspend on POSIX systems, otherwise sigpause with sysv semantics waits for no signal. diff -aur inetutils-1.4.3+20060110/inetd/inetd.c inetutils-1.4.3+20060110.new/inetd/inetd.c --- inet