Re: memset_explicit: Fix compilation error on some OpenSolaris derivatives

2024-04-24 Thread Collin Funk
Hi Simon, On 4/24/24 6:22 AM, Simon Josefsson wrote: > I think this was fairly common before. If there had been a 'make > syntax-check' rule for this, we would have caught it! I have removed > use of HAVE_CONFIG_H and fixed telnetd.h in Inetutils now, thanks. Thanks! It showed up from some othe

Re: memset_explicit: Fix compilation error on some OpenSolaris derivatives

2024-04-24 Thread Simon Josefsson via Bug reports for the GNU Internet utilities
Collin Funk writes: > Hi Paul, > > On 4/23/24 11:22 PM, Paul Eggert wrote: >> Why is telnetd.h including config.h? Only a top-level C file should >> include config.h, and it should so so at the start. > > I don't disagree. Most of those lines are 20 years old, so I assume it > wasn't a problem th