Hi Simon,
On 4/24/24 6:22 AM, Simon Josefsson wrote:
> I think this was fairly common before. If there had been a 'make
> syntax-check' rule for this, we would have caught it! I have removed
> use of HAVE_CONFIG_H and fixed telnetd.h in Inetutils now, thanks.
Thanks! It showed up from some
Erik Auerswald writes:
> I have done that in the attached patch.
>
> I plan to push the changes in a couple of days, unless I receive negative
> feedback.
Looks great, thank you.
/Simon
signature.asc
Description: PGP signature
Hi,
On Wed, Apr 24, 2024 at 06:11:23PM +0200, Erik Auerswald wrote:
> On Wed, Apr 24, 2024 at 02:55:41PM +0200, Simon Josefsson wrote:
> > Erik Auerswald writes:
> > >
> > > while "ifconfig -A" now accepts CIDR notation, it does not reject
> > > prefix length values outside of [0,32]. Also,
Hi Simon,
On Wed, Apr 24, 2024 at 02:55:41PM +0200, Simon Josefsson wrote:
> Erik Auerswald writes:
> >
> > while "ifconfig -A" now accepts CIDR notation, it does not reject
> > prefix length values outside of [0,32]. Also, with a prefix length
> > of 0, undefined begavior is invoked, and at
Collin Funk writes:
> Hi Paul,
>
> On 4/23/24 11:22 PM, Paul Eggert wrote:
>> Why is telnetd.h including config.h? Only a top-level C file should
>> include config.h, and it should so so at the start.
>
> I don't disagree. Most of those lines are 20 years old, so I assume it
> wasn't a problem
Erik Auerswald writes:
> Hi,
>
> while "ifconfig -A" now accepts CIDR notation, it does not reject prefix
> length values outside of [0,32]. Also, with a prefix length of 0,
> undefined begavior is invoked, and at least on x86_64 a wrong netmask
> is computed.
>
> I think the attached patch
