Re: [libtool 2.2] testsuite: 19 64 failed [Solaris AMD64]

2008-03-06 Thread Peter O'Gorman
Ralf Wildenhues wrote:

> This should be $LD -r here, no?  AFAICS this failure happens inside the
> low max_cmd_len test.  This looks like a regression caused by the patch
> that removed _LT_SYS_DYNAMIC_LINKER from _LT_LANG_GCJ_CONFIG.  (If that
> turns out to be true, I am glad we did not make this change for the
> other tags).  This did not show up on GNU/Linux because there
> --whole-archive is used.
> 
> Case in point:
> $ ./libtool --tag=GCJ --config|grep ^LD
> LD="/usr/bin/ld"
> LD=""
>

Fixed with attached patch. Committed as obvious.

Thanks for pointing me in the right direction.

Peter
-- 
Peter O'Gorman
http://pogma.com
2008-03-07  Peter O'Gorman  <[EMAIL PROTECTED]>

	* libltdl/m4/libtool.m4 (_LT_LANG_GCJ_CONFIG): Need to set LD.
	Reported by Nelson H. F. Beebe.

Index: libltdl/m4/libtool.m4
===
RCS file: /sources/libtool/libtool/libltdl/m4/libtool.m4,v
retrieving revision 1.140
diff -u -r1.140 libtool.m4
--- libltdl/m4/libtool.m4	7 Mar 2008 06:14:26 -	1.140
+++ libltdl/m4/libtool.m4	7 Mar 2008 06:37:46 -
@@ -6815,6 +6815,7 @@
 CC=${GCJ-"gcj"}
 compiler=$CC
 _LT_TAGVAR(compiler, $1)=$CC
+_LT_TAGVAR(LD, $1)="$LD"
 _LT_CC_BASENAME([$compiler])
 
 # GCJ did not exist at the time GCC didn't implicitly link libc in.
___
Bug-libtool mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/bug-libtool


Re: [libtool 2.2] testsuite: 19 64 failed [Solaris AMD64]

2008-03-06 Thread Ralf Wildenhues
Hello Peter,

* Peter O'Gorman wrote on Thu, Mar 06, 2008 at 06:36:22AM CET:
> 
> I admit that I don't understand the failures like this one yet.
> 
> Nelson H. F. Beebe wrote:
> >> /convenience.at:265: $LIBTOOL --tag=GCJ --mode=link $GCJ $GCJFLAGS 
> >> $LDFLAGS -o liba12.la liba1.la liba2.la -rpath /notexist
> >> stderr:
> >> stdout:
> >> libtool: link: gcj -shared -Wl,-z -Wl,text -Wl,-h -Wl,liba12.so.0 -o 
> >> .libs/liba12.so.0.0.0  -Wl,-z -Wl,allextract ./.libs/liba1.a 
> >> ./.libs/liba2.a -Wl,-z -Wl,defaultextract
> 
> $GCJ is properly expanded to 'gcj' here.
> 
> >> /convenience.at:267: $LIBTOOL --tag=GCJ --mode=link $GCJ $GCJFLAGS 
> >> $LDFLAGS -o liba123.la A3.lo liba1.la liba2.la -rpath /notexist
> >> stderr:
> >> /local/build/bare/libtool-2.2/tests/testsuite.dir/64/libtool: line 7084: 
> >> -r: command not found
> >> stdout:
> >> libtool: link:  -r -o .libs/liba123.la-1.o .libs/A3.o 
> 
> But here it is the empty string!

This should be $LD -r here, no?  AFAICS this failure happens inside the
low max_cmd_len test.  This looks like a regression caused by the patch
that removed _LT_SYS_DYNAMIC_LINKER from _LT_LANG_GCJ_CONFIG.  (If that
turns out to be true, I am glad we did not make this change for the
other tags).  This did not show up on GNU/Linux because there
--whole-archive is used.

Case in point:
$ ./libtool --tag=GCJ --config|grep ^LD
LD="/usr/bin/ld"
LD=""

Cheers,
Ralf


___
Bug-libtool mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/bug-libtool


Re: [libtool 2.2] testsuite: 19 64 failed [Solaris AMD64]

2008-03-05 Thread Peter O'Gorman
Nelson H. F. Beebe wrote:

Hi Nelson,
I admit that I don't understand the failures like this one yet.

>> /convenience.at:265: $LIBTOOL --tag=GCJ --mode=link $GCJ $GCJFLAGS $LDFLAGS 
>> -o liba12.la liba1.la liba2.la -rpath /notexist
>> stderr:
>> stdout:
>> libtool: link: gcj -shared -Wl,-z -Wl,text -Wl,-h -Wl,liba12.so.0 -o 
>> .libs/liba12.so.0.0.0  -Wl,-z -Wl,allextract ./.libs/liba1.a ./.libs/liba2.a 
>> -Wl,-z -Wl,defaultextract

$GCJ is properly expanded to 'gcj' here.


>> /convenience.at:267: $LIBTOOL --tag=GCJ --mode=link $GCJ $GCJFLAGS $LDFLAGS 
>> -o liba123.la A3.lo liba1.la liba2.la -rpath /notexist
>> stderr:
>> /local/build/bare/libtool-2.2/tests/testsuite.dir/64/libtool: line 7084: -r: 
>> command not found
>> stdout:
>> libtool: link:  -r -o .libs/liba123.la-1.o .libs/A3.o 

But here it is the empty string!

I'll look at it tomorrow. Thanks.

Peter


___
Bug-libtool mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/bug-libtool