Re: Issue 1513 in lilypond: Figured bass extenders do not line up

2011-02-21 Thread lilypond


Comment #6 on issue 1513 by reinhold...@gmail.com: Figured bass extenders  
do not line up

http://code.google.com/p/lilypond/issues/detail?id=1513

It is a bug, but certainly not critical.


___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: Issue 1513 in lilypond: Figured bass extenders do not line up

2011-02-21 Thread lilypond

Updates:
Labels: -Priority-Critical -Regression Priority-Medium

Comment #7 on issue 1513 by philehol...@googlemail.com: Figured bass  
extenders do not line up

http://code.google.com/p/lilypond/issues/detail?id=1513

Given Keith's image of the misaligned extender after a line break in 2.12,  
implying that the fact these lines up in 2.12 was co-incidence, and the  
general agreement that this is not good practice, changing this to a normal  
bug, not a regression.



___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: Issue 1513 in lilypond: Figured bass extenders do not line up

2011-02-20 Thread lilypond


Comment #4 on issue 1513 by k-ohara5...@oco.net: Figured bass extenders do  
not line up

http://code.google.com/p/lilypond/issues/detail?id=1513

I am surprised that the extender line broke at all.  This construction  
seems to be a leftover from temporarily turning off extenders to reprint  
the natural after a line break.


Putting the line break back in, we see that ver 2.12.3 does not align the  
extenders.  It seems the alignment was accidental.


If we follow the advice of the manual, and have the FiguredBass timing  
match that of the note columns above, we get a continuous extender line.

\new FiguredBass \figuremode{
  _!2 \ext _!2 \ext % --remove this \ext to repeat natural (if line  
breaks here)

  _!4 \ext _!4 \ext _!2 |
}

The change in alignment is similar to closed issue 1438.

Attachments:
1513_stable.png  1.0 KB
1513_corrected.png  961 bytes


___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: Issue 1513 in lilypond: Figured bass extenders do not line up

2011-02-20 Thread lilypond


Comment #5 on issue 1513 by carl.d.s...@gmail.com: Figured bass extenders  
do not line up

http://code.google.com/p/lilypond/issues/detail?id=1513

Keith's comment above would certainly indicate to me that this should not  
be critical.


It might even be invalid, because the sample code doesn't follow the NR  
recommended practice.



___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: Issue 1513 in lilypond: Figured bass extenders do not line up

2011-02-19 Thread lilypond


Comment #2 on issue 1513 by reinhold...@gmail.com: Figured bass extenders  
do not line up

http://code.google.com/p/lilypond/issues/detail?id=1513

That patch is needed to ensure that all extenders stop at the same  
horizontal position (independent of the figure's actuall width). Other wise  
the extender of a 4+ figure would be longer thant the extender of a 5  
figure. If they appear at the same time, this looks awfull.


Unfortunately, I have not yet found the perfect solution to the problem.  
The above mentioned patch makes all hidden figures (i.e. the right edge of  
the extender) behave like they have a figure 0, thus forcing them to end  
at the same position. Unfortunately, this messes up the Y extent/position  
if the extender does not come from a digit.


What I would really need is a way to make the right edge of the extender  
behave as if it has the Y extent of the original figure and the X extent of  
a single digit (in all cases, even if the figure is something completely  
different). Unfortunately, the engraver only sets the text property as  
markup (which is then processed by ly:text-interface::print), so I don't  
have access to the X and Y extent yet.


And in Figured_bass_continuation::print, where I have access to the extent,  
I don't know how to deal with the custom alignment of the figures (i.e. 4+,  
#5 and 6 exactly align the digits, but are then shifted by the widht of the  
#; Longer digits, e.g. 12 are then left aligned the resulting grob. So I  
can't take the left/right edge or the center of the markup, there).


So, I'm really at loss here how to properly make the extenders stop at the  
same position without messing up the Y position...



___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: Issue 1513 in lilypond: Figured bass extenders do not line up

2011-02-19 Thread lilypond


Comment #3 on issue 1513 by philehol...@googlemail.com: Figured bass  
extenders do not line up

http://code.google.com/p/lilypond/issues/detail?id=1513

In the example given, why is it necessary to break the extender line?   
Would it not mean the same with a continuous extender?



___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: Issue 1513 in lilypond: Figured bass extenders do not line up

2011-02-17 Thread lilypond


Comment #1 on issue 1513 by percival.music.ca: Figured bass extenders do  
not line up

http://code.google.com/p/lilypond/issues/detail?id=1513

git bisect.  I don't understand the issue, so I'm not in a position to say  
whether this was a good change or not.  (it's a one-line patch, though!)



736a3513783c7411eb9feeab2d98363da9dc7ec5 is the first bad commit
commit 736a3513783c7411eb9feeab2d98363da9dc7ec5
Author: Reinhold Kainhofer reinh...@kainhofer.com
Date:   Wed Nov 24 16:50:23 2010 +0100

FiguredBass: Extenders for figs of different width should stop at same  
position

...



___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond


Issue 1513 in lilypond: Figured bass extenders do not line up

2011-02-13 Thread lilypond

Status: Accepted
Owner: 
Labels: Type-Defect Priority-Critical Regression

New issue 1513 by philehol...@googlemail.com: Figured bass extenders do not  
line up

http://code.google.com/p/lilypond/issues/detail?id=1513

Reported by Mats Bengtsson:

The following example shows a regression compared to version 2.12. It
produces two extender lines that were vertically aligned in 2.12 but are
not aligned in version 2.13.49. I'm not sure if it worked by incident or
if it was intended behavior in 2.12, and I can hardly recall why I used
this specific construct when typesetting the piece two years back.

\version 2.13.49

ext = {
   \once \set useBassFigureExtenders = ##t
}

\score{

\new Staff \relative c' {
 \clef bass
 c2 c, ~ | % \break
 c4 c c2 |
   }
\new FiguredBass \figuremode{
_!1 \ext |
_!2 \ext _!2 |
   }
 
}



Attachments:
2.12.3.png  2.5 KB
2.13.49.png  1.9 KB


___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond