Re: Bug in pattern rule parsing: how to handle?

2008-10-26 Thread Philip Guenther
On Sun, Oct 26, 2008 at 4:14 PM, Paul Smith <[EMAIL PROTECTED]> wrote: ... > Correct, although IMO just because it has a _possible_ reasonable > interpretation isn't enough to overcome all the reasons why we shouldn't > allow it :-) I agree. I just thought of another reason to dislike it: %.a %

Re: Bug in pattern rule parsing: how to handle?

2008-10-26 Thread Paul Smith
On Sun, 2008-10-26 at 15:32 -0700, Philip Guenther wrote: > Just to be clear, the problem with mixing a pattern with a normal > target is what happens when there's a pattern prerequisite, right? I > mean, the example you gave at least has a sensical _possible_ > interpretation, but this: >foo

Re: Bug in pattern rule parsing: how to handle?

2008-10-26 Thread Paul Smith
On Sun, 2008-10-26 at 23:15 +0100, Sam Ravnborg wrote: > Can you give me a more precise pointer where we have this issue > so I can get it fixed. I guess it is Makefile.build... If you mean in the Linux kernel there are two places: Makefile:1601: *** mixed implicit and normal rules. Sto

Re: Bug in pattern rule parsing: how to handle?

2008-10-26 Thread Philip Guenther
On Sun, Oct 26, 2008 at 2:48 PM, Paul Smith <[EMAIL PROTECTED]> wrote: ... > Here's the issue: if you write a rule like this: > >foo %.c: ; @: oops > > it actually works! This, I believe, should be illegal. Just to be clear, the problem with mixing a pattern with a normal target is what h

Re: Bug in pattern rule parsing: how to handle?

2008-10-26 Thread Sam Ravnborg
On Sun, Oct 26, 2008 at 05:48:11PM -0400, Paul Smith wrote: > Hi all; > > While working on some changes to 2nd expansion etc. to try to reduce > total heap usage in GNU make, I've discovered that there is a bug in the > current makefile parsing. My new version doesn't have this bug (or, > more pr

[bug #24655] shell_var.length isn't set causing duplicates from target_environment.

2008-10-26 Thread Knut St. Osmundsen
URL: Summary: shell_var.length isn't set causing duplicates from target_environment. Project: make Submitted by: bird_tori Submitted on: Sun 26 Oct 2008 11:02:30 PM CET Severity: 3 -

Bug in pattern rule parsing: how to handle?

2008-10-26 Thread Paul Smith
Hi all; While working on some changes to 2nd expansion etc. to try to reduce total heap usage in GNU make, I've discovered that there is a bug in the current makefile parsing. My new version doesn't have this bug (or, more precisely, it contains the opposite bug) and I've noticed at least two dif