Re: Should make handle non-blocking jobserver and use socket pair instead?

2019-09-03 Thread Paul Smith
On Thu, 2019-08-15 at 17:26 +0300, Juha-Matti Tilli wrote: > GNU make expects the jobserver to be blocking, whereas a program > based on an event-loop architecture should really be using non- > blocking file descriptors. Well, GNU make invented the jobserver concept, and GNU make is not an

Re: gmake-4.2.90 patch

2019-09-03 Thread Paul Smith
On Tue, 2019-09-03 at 10:27 -0400, Dmitry Goncharov wrote: > /* Define to 1 if you can safely include both and . */ > /* #undef TIME_WITH_SYS_TIME */ This is the reason for your problem. On my system, this is defined. What version of GNU/Linux are you using? What this undefined value means is

Re: gmake-4.2.90 regression (error message missing)

2019-09-03 Thread Paul Smith
On Tue, 2019-09-03 at 10:54 -0400, Dmitry Goncharov wrote: > You were planning to use stat, right? Are you planning to stat the > interperter specified in shebang as well? > Some of the races can be avoided by opening the file before > posix_spawn and then using fstat on the fd. > Alternatively

Re: gmake-4.2.90 regression (error message missing)

2019-09-03 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
You were planning to use stat, right? Are you planning to stat the interperter specified in shebang as well? Some of the races can be avoided by opening the file before posix_spawn and then using fstat on the fd. Alternatively that posix_spawn check from configure.ac can be executed at runtime to

Re: gmake-4.2.90 patch

2019-09-03 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
Sure, Paul. Here is the error message on redhat. /usr/bin/gcc -DHAVE_CONFIG_H -Isrc -I../src -Ilib -I../lib -DLIBDIR=\"/usr/local/lib\" -DINCLUDEDIR=\"/usr/local/include\" -DLOCALEDIR=\"/usr/local/share/locale\"-m64 -g -O0 -MT src/file.o -MD -MP -MF $depbase.Tpo -c -o src/file.o

Re: GNU make 4.2.90 release candidate available

2019-09-03 Thread Paul Smith
On Wed, 2019-08-28 at 17:35 -0400, Dennis Clarke wrote: > > This also disables every extension over C, especially POSIX. > > Is this a *bad* thing or a *good* thing ? What is the actual language > dialect that GNU Make wishes to be compliant with is the real question. Like all GNU software, it

Re: GNU make 4.2.90 release candidate available

2019-09-03 Thread Paul Smith
On Tue, 2019-09-03 at 10:25 +0200, Robert Pluim wrote: > The good news is that this affects only building from git, the > pre-release tarball builds fine with just './configure', and passes > all but one test from 'make check'. Yes, I do rely on GCC (and GNU make) when performing maintainer

Re: [bug #56701] Do not allow -j without a number

2019-09-03 Thread Robert Pluim
> On Mon, 26 Aug 2019 08:35:15 -0400 (EDT), "Paul D. Smith" > said: Paul> Update of bug #56701 (project make): Paul> Item Group: Bug => Enhancement Paul> ___ Paul>

Re: GNU make 4.2.90 release candidate available

2019-09-03 Thread Robert Pluim
> On Mon, 02 Sep 2019 12:28:52 -0400, Paul Smith said: Paul> My first guess is that this another of a series of unpleasantnesses Paul> caused by clang trying to "pretend" to be GCC, and failing. Paul> I understand why the Clang devs do this: they want to take advantage of