Re: [PATCH v2] Add '--shuffle' argument support

2022-02-18 Thread Eli Zaretskii
> From: Sergei Trofimovich > Date: Fri, 18 Feb 2022 23:50:09 + > Cc: Sergei Trofimovich > > * Makefile.am (make_SRCS): Add src/shuf.h and src/shuf.c file references. > * builddos.bat: Add shuf.o into build script. > * doc/make.1: Add '--shuffle' option description. > * doc/make.texi: Add

Re: [PATCH] RFC: add --shuffle[=seed] argument support

2022-02-18 Thread Sergei Trofimovich
On Sun, 6 Feb 2022 09:34:22 + Sergei Trofimovich wrote: > On Sat, 05 Feb 2022 18:39:41 -0500 > Paul Smith wrote: > > > Nice work! > > > > On Sat, 2022-02-05 at 22:04 +, Sergei Trofimovich wrote: > > > Some high level TODOs: > > > > For this amount of change it's likely that

[PATCH v2] Add '--shuffle' argument support

2022-02-18 Thread Sergei Trofimovich
From: Sergei Trofimovich The idea of the change is to introduce non-deterministic ordering into goal and prerequisite traversal to imitate non-deterministic ordering of 'make -j g1 g2 g3' mode. The implementation is to introduce second order into each dependency chain: 1. existing order is

[PATCH] Fix src/function.c build failure on gcc-12.

2022-02-18 Thread Sergei Trofimovich
From: Sergei Trofimovich Upcoming gcc-12 detects possible buffer overflow for 1 byte: src/function.c: In function 'func_call': src/function.c:2781:24: error: '__builtin___sprintf_chk' may write a terminating nul past the end of the destination [-Werror=format-overflow=8] 2781 |

Re: Make losing jobserver tokens on Windows

2022-02-18 Thread Eli Zaretskii
> From: Paul Smith > Date: Fri, 18 Feb 2022 10:04:08 -0500 > > I am not aware of any issues like this. However, I recommend that you > try using the Visual Studio build of GNU make and see if that works > better. I'm not very familiar with the Cygwin version of GNU make; > it's not maintained

Re: Make losing jobserver tokens on Windows

2022-02-18 Thread Paul Smith
On Fri, 2022-02-18 at 10:18 +0100, Magnus Ihse Bursie wrote: > make[2]: INTERNAL: Exiting with 1 jobserver tokens available; should > be 24! > > This effectively turns the highly parallelized builds into > single-threaded builds, and is absolutely detrimental for > performance. :-( On the flip

Re: Make losing jobserver tokens on Windows

2022-02-18 Thread Eli Zaretskii
> Date: Fri, 18 Feb 2022 10:18:24 +0100 > From: Magnus Ihse Bursie > > So, my first question is: Is this a known problem? Are there any > workarounds/fixes to get around it? Not that I know of, no. Search of the bug database also doesn't seem to bring up anything like that. > Otherwise: Any

Make losing jobserver tokens on Windows

2022-02-18 Thread Magnus Ihse Bursie
Hi, I'm working for Oracle on the OpenJDK build team. We're using GNU make exclusively to build the JDK on all supported platforms. For Windows, we (typically) use the Cygwin version. We have had a long-standing issue with make losing jobserver tokens on Windows. Most runs end with