Re: [PATCH] Fix src/function.c build failure on gcc-12.

2022-02-21 Thread Paul Smith
On Mon, 2022-02-21 at 08:59 +, Edward Welbourne wrote: > and that's assuming a 32-bit int; the signed range is from - > 2,147,483,647 to 2,147,483,648.  However, may I suggest the following > (which I know included in the GPL'd cfengine sources at some point): This computation is already

Re: Make losing jobserver tokens on Windows

2022-02-21 Thread Paul Smith
On Mon, 2022-02-21 at 15:56 +0100, Magnus Ihse Bursie wrote: > I'm trying to built it from source right now (and it does not seem > complicated), but even so, an official binary makes sure I'm not > introducing any issues from my local build environment. There is no such thing as an "official

Re: Make losing jobserver tokens on Windows

2022-02-21 Thread Eli Zaretskii
> Date: Mon, 21 Feb 2022 15:56:37 +0100 > From: Magnus Ihse Bursie > > > I am not aware of any issues like this. However, I recommend that you > > try using the Visual Studio build of GNU make and see if that works > > better. I'm not very familiar with the Cygwin version of GNU make; > > it's

Re: Make losing jobserver tokens on Windows

2022-02-21 Thread Edward Welbourne
>> I believe that the goal of the Cygwin port is to implement a POSIX >> layer on top of Windows, so I'm assuming that when you compile GNU >> make with Cygwin it uses the POSIX implementation of the jobserver. >> This implementation relies on certain POSIX behaviors of pipes and >> signals and

Re: Make losing jobserver tokens on Windows

2022-02-21 Thread Magnus Ihse Bursie
On 2022-02-18 16:04, Paul Smith wrote: On Fri, 2022-02-18 at 10:18 +0100, Magnus Ihse Bursie wrote: make[2]: INTERNAL: Exiting with 1 jobserver tokens available; should be 24! This effectively turns the highly parallelized builds into single-threaded builds, and is absolutely detrimental for

Re: [PATCH] Fix src/function.c build failure on gcc-12.

2022-02-21 Thread Paul Smith
On Mon, 2022-02-21 at 08:59 +, Edward Welbourne wrote: > and that's assuming a 32-bit int; the signed range is from - > 2,147,483,647 to 2,147,483,648.  However, may I suggest the following > (which I know included in the GPL'd cfengine sources at some point): This computation is already

Re: [PATCH] Fix src/function.c build failure on gcc-12.

2022-02-21 Thread Edward Welbourne
Sergei Trofimovich (19 February 2022 00:48) reports: > Upcoming gcc-12 detects possible buffer overflow for 1 byte: [snip] > Unlikely numbers like '-1234567890' including null terminator take 12 > bytes of storage. and that's assuming a 32-bit int; the signed range is from -2,147,483,647 to