Re: [PATCH] Fix some temp file issues

2022-10-08 Thread Eli Zaretskii
> Date: Sat, 8 Oct 2022 21:23:53 -0700 > Cc: bug-make@gnu.org > From: Paul Eggert > > On 2022-10-08 21:19, Eli Zaretskii wrote: > > I meant the "b" part, not the "+" part. On systems where that changes > > the bytestream written to the file, the change might require a > > suitable change where

Re: [PATCH] Fix some temp file issues

2022-10-08 Thread Paul Eggert
On 2022-10-08 21:19, Eli Zaretskii wrote: I meant the "b" part, not the "+" part. On systems where that changes the bytestream written to the file, the change might require a suitable change where we read that stuff. If I understand things correctly the code was formerly using tmpfile which

Re: [PATCH] Fix some temp file issues

2022-10-08 Thread Eli Zaretskii
> Date: Sat, 8 Oct 2022 15:22:50 -0700 > Cc: bug-make@gnu.org > From: Paul Eggert > > On 2022-10-08 00:14, Eli Zaretskii wrote: > >> tmpfile uses "wb+" (POSIX requires this) and we should be consistent in > >> all the paths that create temporary FILE *. The attached patch adds a > >> comment

Re: [PATCH] Fix some temp file issues

2022-10-08 Thread Paul Eggert
On 2022-10-08 00:14, Eli Zaretskii wrote: tmpfile uses "wb+" (POSIX requires this) and we should be consistent in all the paths that create temporary FILE *. The attached patch adds a comment about this. I don't remember: where is this temporary file read? It's read by a different process

[bug #63185] configure fails to detect getloadavg declaration on sun and aix.

2022-10-08 Thread Dmitry Goncharov
Follow-up Comment #1, bug #63185 (project make): The latest configure from 4.3.90 fails to detect getloadavg declaration on sun and aix. ../src/job.c: In function ▒load_too_high▒: ../src/job.c:2103:7: warning: implicit declaration of function ▒getloadavg▒ [-Wimplicit-function-declaration]

[bug #63185] configure fails to detect getloadavg declaration on sun and aix.

2022-10-08 Thread Dmitry Goncharov
URL: Summary: configure fails to detect getloadavg declaration on sun and aix. Project: make Submitter: dgoncharov Submitted: Sat 08 Oct 2022 08:26:14 PM UTC Severity: 3 -

Re: [PATCH] Fix some temp file issues

2022-10-08 Thread Eli Zaretskii
> Date: Fri, 7 Oct 2022 21:37:24 -0700 > Cc: bug-make@gnu.org > From: Paul Eggert > > > I'd appreciate a more high-level description of the idea of the > > change, in addition to the gory details. > > I gave it a shot in the attached patch, which is an improved version of > the previous patch.