Re: [PATCH] Use UTF-8 active code page for Windows host.

2023-05-17 Thread Eli Zaretskii
> From: Paul Smith > Cc: bug-make@gnu.org > Date: Wed, 17 May 2023 18:04:55 -0400 > > To remind: the purpose of these is to provide a makefile-based way to > _develop_ GNU Make itself, on platforms where we can't run ./configure > to get an automake-generated makefile. > > If you need to build

Re: [PATCH] Use UTF-8 active code page for Windows host.

2023-05-17 Thread Costas Argyris
No; those makefiles can only work with GNU Make. You can easily tell by looking at them since they use make functions like call, etc. all over the place, plus pattern rules and all sorts of fancy things :). I see - thanks for pointing that out (I don't have much experience with Makefiles as you

Re: [PATCH] Use UTF-8 active code page for Windows host.

2023-05-17 Thread Paul Smith
On Wed, 2023-05-17 at 22:55 +0100, Costas Argyris wrote: > From a quick search there appear to be many ways > to do this, but some of them are GNU Make-specific, > and I believe these Makefiles (Basic.mk and those > included by it) have to work with any Make, not just > GNU Make. No; those

Re: [PATCH] Use UTF-8 active code page for Windows host.

2023-05-17 Thread Costas Argyris
Actually I think windres should be optional here too, even if it is just for being consistent across all build approaches. If you agree, please let me know of what would be a good portable way to check if windres is on the path from within a Makefile (mk/Windows32.mk I guess). >From a quick

Re: [PATCH] Use UTF-8 active code page for Windows host.

2023-05-17 Thread Costas Argyris
Here is the patch with the Basic.mk.template and mk/Windows32.mk changes.I tried to keep most of the changes in the Windows-specific file, but something had to happen in the general one as well, as far as I could tell. I deliberately sent only the changes relevant to the Basic.mk approach

Re: [PATCH] Use UTF-8 active code page for Windows host.

2023-05-17 Thread Paul Smith
On Wed, 2023-05-17 at 12:47 +0100, Costas Argyris wrote: > However, when trying to prepare the new patch I realized that > Basic.mk is an untracked file which is listed in .gitignore, so how > would you like me to show you these latest changes? The file to be changed is Basic.mk.template Sorry I

Re: [PATCH] Use UTF-8 active code page for Windows host.

2023-05-17 Thread Costas Argyris
I side-stepped this issue by copying .\WinRel\gnumake.exe to the top-level folder and running this instead: .\gnumake.exe -f Basic.mk TOOLCHAIN={msvc(default),gcc} which worked. I implemented the changes in Basic.mk and mk\Windows32.mk (which is being sourced by Basic.mk) and they seem to be