[PATCH 5/6] Fix GCC compile warning for "format-signedness"

2023-06-09 Thread Torbjörn SVENSSON
Contributed by STMicroelectronics Signed-off-by: Torbjörn SVENSSON --- src/job.c | 2 +- src/w32/subproc/sub_proc.c | 6 +++--- src/w32/w32os.c| 8 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/job.c b/src/job.c index f7f97010..1c66090c

[PATCH 6/6] Fix GCC compile warning for "bad-function-cast"

2023-06-09 Thread Torbjörn SVENSSON
Contributed by STMicroelectronics Signed-off-by: Torbjörn SVENSSON --- src/function.c | 2 +- src/os.h | 5 + src/w32/compat/posixfcn.c | 3 ++- src/w32/subproc/sub_proc.c | 4 ++-- src/w32/w32os.c| 20 +++- 5 files changed, 25

Re: [bug #64288] The flag --no-print-directory becomes effective too early

2023-06-09 Thread Paul Smith
Just to note you can still post comments to bugs in Savannah, and they will be sent out to the list like any other bug, even if they're closed. But discussing on the mailing list directly is fine too! On Fri, 2023-06-09 at 23:46 +0900, Masahiro Yamada wrote: > On Fri, Jun 9, 2023 at 9:39 PM Paul

Re: [PATCH 1/6] Fix GCC compile warning for "declaration-after-statement"

2023-06-09 Thread Torbjorn SVENSSON
On 2023-06-09 16:53, Martin Dorey wrote: Primed by our earlier discussion, I wondered "How does that fix the bad-function-cast warning?", before belatedly noticing the Subject. This particular patch does not address the bad cast, it's addressed in patch 6 of the series.

Re: [PATCH 1/6] Fix GCC compile warning for "declaration-after-statement"

2023-06-09 Thread Martin Dorey
Primed by our earlier discussion, I wondered "How does that fix the bad-function-cast warning?", before belatedly noticing the Subject. From: bug-make-bounces+martin.dorey=hds@gnu.org on behalf of Torbjörn SVENSSON Sent: Friday, June 9, 2023 07:39 To:

Re: [bug #64288] The flag --no-print-directory becomes effective too early

2023-06-09 Thread Masahiro Yamada
On Fri, Jun 9, 2023 at 9:39 PM Paul D. Smith wrote: > > Update of bug #64288 (project make): > > Status:None => Not A Bug > Open/Closed:Open => Closed > > ___ > >

Re: Unable to cross build for Windows

2023-06-09 Thread Torbjorn SVENSSON
On 2023-06-09 09:11, Eli Zaretskii wrote: From: Martin Dorey CC: "bug-make@gnu.org" Date: Fri, 9 Jun 2023 06:32:28 + msip_labels: #include intptr_t _get_osfhandle(int); typedef void* HANDLE; HANDLE fn() {   return (HANDLE)_get_osfhandle(0); }

[PATCH 2/6] Fix GCC compile warning for "format-security"

2023-06-09 Thread Torbjörn SVENSSON
Contributed by STMicroelectronics Signed-off-by: Torbjörn SVENSSON --- src/job.c| 2 +- src/main.c | 4 ++-- src/w32/subproc/w32err.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/job.c b/src/job.c index 34ef9b80..f7f97010 100644 ---

[bug #64288] The flag --no-print-directory becomes effective too early

2023-06-09 Thread Paul D. Smith
Update of bug #64288 (project make): Status:None => Not A Bug Open/Closed:Open => Closed ___ Follow-up Comment #1: This behavior is

Re: Unable to cross build for Windows

2023-06-09 Thread Paul Smith
On Fri, 2023-06-09 at 14:16 +0200, Torbjorn SVENSSON wrote: > The only thing left, that I don't know how to handle, is the use of > O() where the 3rd parameter is not a string literal. > > src/job.c: In function 'create_batch_file': > src/job.c:365:3: error: format not a string literal and no

[PATCH 3/6] Fix GCC compile warning for "discarded-qualifiers"

2023-06-09 Thread Torbjörn SVENSSON
Contributed by STMicroelectronics Signed-off-by: Torbjörn SVENSSON --- src/w32/compat/posixfcn.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/w32/compat/posixfcn.c b/src/w32/compat/posixfcn.c index a89c0657..1af66b79 100644 --- a/src/w32/compat/posixfcn.c +++

[PATCH 1/6] Fix GCC compile warning for "declaration-after-statement"

2023-06-09 Thread Torbjörn SVENSSON
Contributed by STMicroelectronics Signed-off-by: Torbjörn SVENSSON --- src/w32/w32os.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/w32/w32os.c b/src/w32/w32os.c index 33828010..015b685e 100644 --- a/src/w32/w32os.c +++ b/src/w32/w32os.c @@ -35,6 +35,7 @@

[PATCH 4/6] Fix GCC compile warning for "unused-parameter"

2023-06-09 Thread Torbjörn SVENSSON
Contributed by STMicroelectronics Signed-off-by: Torbjörn SVENSSON --- src/w32/compat/posixfcn.c | 2 +- src/w32/w32os.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/w32/compat/posixfcn.c b/src/w32/compat/posixfcn.c index 1af66b79..72fe5f2e 100644

[PATCH 0/6] Fix compilation errors in maintainer mode

2023-06-09 Thread Torbjörn SVENSSON
Hi, This patch series addresses all the errors that GCC 7.3 emits when cross building for Windows in maintainer mode. Kind regards, Torbjörn

Re: Unable to cross build for Windows

2023-06-09 Thread Torbjorn SVENSSON
On 2023-06-09 14:44, Paul Smith wrote: On Fri, 2023-06-09 at 14:16 +0200, Torbjorn SVENSSON wrote: The only thing left, that I don't know how to handle, is the use of O() where the 3rd parameter is not a string literal. src/job.c: In function 'create_batch_file': src/job.c:365:3: error:

[bug #64288] The flag --no-print-directory becomes effective too early

2023-06-09 Thread Masahiro Yamada
URL: Summary: The flag --no-print-directory becomes effective too early Group: make Submitter: masahiroy Submitted: Fri 09 Jun 2023 08:15:30 AM UTC Severity: 3 - Normal

Pattern rules without recipe

2023-06-09 Thread Frank Heckenbach
Another thing that surprised me which I assume is working as designed, but I think should be spelled out clearer in the manual: % cat Makefile MAKEFLAGS += --no-builtin-rules .PHONY: %.a %.b %.c %.a: ; @echo $@ %.b: %.a; @echo $@ %.c: %.a % make x.b x.a x.b % make x.c make: *** No rule to make

Re: Order-only prerequisites

2023-06-09 Thread Frank Heckenbach
Henrik Carlqvist wrote: > On Wed, 07 Jun 2023 08:29:15 +0200 > > As I said, a way to specify in which order recipes are invoked > > (here, a before b) if they are invoked, without influencing whether > > they are invoked (only a, only b or a and b, as given on the command > > line). > > So you

Re: Unable to cross build for Windows

2023-06-09 Thread Eli Zaretskii
> From: Martin Dorey > CC: "bug-make@gnu.org" > Date: Fri, 9 Jun 2023 06:32:28 + > msip_labels: > > #include > > intptr_t _get_osfhandle(int); > typedef void* HANDLE; > > HANDLE fn() { >   return (HANDLE)_get_osfhandle(0); > } > martind@sirius:~/tmp/svensson-2023-06-08$ gcc -c

Re: Unable to cross build for Windows

2023-06-09 Thread Martin Dorey
> in some MinGW64 header files? Easily eliminated: martind@sirius:~/tmp/svensson-2023-06-08$ cat make.c #include intptr_t _get_osfhandle(int); typedef void* HANDLE; HANDLE fn() {   return (HANDLE)_get_osfhandle(0); } martind@sirius:~/tmp/svensson-2023-06-08$ gcc -c -Wbad-function-cast make.c