On Sun, 21 Jan 2024 14:45:00 -0500
Dmitry Goncharov wrote:
> i bet, the purpose of having (*ep)[nl] == '=' check before strncmp was
> to relieve make from running strncmp unless the variables have the
> same length.
Yes, that is also my guess. Unfortunately, it could give a segfault if
(*ep)[nl]
On Tue, Jan 16, 2024 at 1:21 PM Henrik Carlqvist wrote:
>
> On Tue, 16 Jan 2024 06:59:30 +
> MIAOW Miao wrote:
> > if ((*ep)[nl] == '=' && strncmp (*ep, v->name, nl) == 0)
>
> Looking at that line, the rather obvious fix would be to change it to:
>
> if (strncmp (*ep, v->name, nl) == 0 &&
On Sun, Jan 21, 2024 at 11:17 AM Paul Smith wrote:
> I think you wrote that wrong: I think you mean "otherwise +:= behaves
> the same as +="... ?
You are right.
Let us clarify the goal of these enhancements?
i assumed that the goal of these enhancements was to allow code like
hello+:=$(world)
On Sat, 2024-01-20 at 22:18 -0500, Dmitry Goncharov wrote:
> > Either we could follow the example of "+=" and say that the assignment
> > type in "+:=" only takes effect if the variable doesn't already have a
> > type but if it does that type is preserved, so in the above example FOO
> > would
Hi Martin and Paul,
Thanks for your detailed explanation. I have no further concerns now.
Have a great day ahead!
Best regards,
Haoxin
Paul Smith 于2024年1月21日周日 23:24写道：
> On Sun, 2024-01-21 at 12:00 +0800, Haoxin Tu wrote:
> > May I know if you are planning to propose a fix for it? I checked
On Sun, 2024-01-21 at 12:00 +0800, Haoxin Tu wrote:
> May I know if you are planning to propose a fix for it? I checked the
> implementations of other `make` versions a bit further, and as far as
> I can tell, the issue exists from the older make-4.0.90 (2014-9-30)
> to the newest version of make
