RE: [PATCH] Refactor and merge child_execute_job() code, new attempt

2014-03-10 Thread Pavel Fedin
should be reverted, since we decided to keep the CLOSE_ON_EXEC() macro. Of course, i've just forgot about the comment. :) Ok, i'm waiting for the change to be committed in order to proceed with Cygwin specifics. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center

[PATCH] Refactor and merge child_execute_job() code, new attempt

2014-03-05 Thread Pavel Fedin
Hello, Paul! Sorry for so long delay, i'm really quite busy, however i have found some time to get back to this. Please review the new version. This is actually a repost. I have posted this message a week ago and got no response. I suggest it fell into old thread, so you have missed it.

Re: [PATCH] Refactor and merge child_execute_job() code

2014-02-26 Thread Pavel Fedin
Hello, Paul! Sorry for so long delay, i'm really quite busy, however i have found some time to get back to this. Please review the new version. Monday, February 3, 2014, 0:30:26 you wrote: I prefer the macro form as well; please keep it that way. Done. Also, I'm not sure I like the

Re: [PATCH] Refactor and merge child_execute_job() code

2014-02-03 Thread Pavel Fedin
Hello, Paul! I have read your suggestions and i think i can implement them. But, sorry, not earlier than weekend. Starting to be extremely busy... -- С уважением, Pavel mailto:pavel_fe...@mail.ru ___ Bug-make mailing

[PATCH] Refactor and merge child_execute_job() code

2014-01-29 Thread Pavel Fedin
Hello! This is my long-promised refactor. After this it's much easier to apply runtime selection between spawn() and fork() on Cygwin, because all differences are now consolidated in two functions: child_execute_process() and exec_command(). Insome critical POSIX-specific

[PATCH] Refactor and merge child_execute_job() code - small update

2014-01-29 Thread Pavel Fedin
Ooops, sorry. It's really too late here, so i'm a bit impatient. Forgot to regenerate .diff after last-minute change. Better use this version. In it return type of child_execute_job() is changed from int to pid_t, as it should be. -- С уважением, Pavel

RE: [PATCH] Fix output-sync option on EMX - updated

2014-01-17 Thread Pavel Fedin
, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make

RE: [PATCH] Fix output-sync option on EMX - updated

2014-01-15 Thread Pavel Fedin
, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make

[PATCH] Fix output-sync option on EMX - updated

2014-01-14 Thread Pavel Fedin
=-DNO_OUTPUT_SYNC to configure. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia make-fix-output-sync-emx.diff Description: Binary data ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug

Re: win32 compilation of make 4.0 source code

2014-01-13 Thread Pavel Fedin
Title: Re: win32 compilation of make 4.0 source code Hello, Mark. Monday, January 13, 2014, 17:57:20 you wrote: Is the resulting file supposed to executed under Cygwin ? No. If you build Make natively for Windows, this results in native Windows version. Cygwin is actually quite a

Missing po files in GIT

2014-01-13 Thread Pavel Fedin
Hello! I am trying to rebuild GIT version of Make, however .po files are missing in the repository. Is this intentional ? I have copied them over from my 4.0-2 archive. But where are they originally stored ? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia

[PATCH] Fix output-sync option on EMX

2014-01-13 Thread Pavel Fedin
Hello! This is part of my spawn-patch for Make. The purpose of this piece is to add missing support for output-sync option to spawn()-based flavors (currently only EMX). Tested together with the rest of spawn-patch under Cygwin, works fine. Kind regards, Pavel Fedin Expert Engineer Samsung

RE: win32 compilation of make 4.0 source code‏

2014-01-13 Thread Pavel Fedin
this Makefile, you need Cygwin or MinGW32 environment. Native Windows version of Make executes commands via cmd.exe, which of course does not understand commonly used UNIX stuff. Well, some commands are emulated by Make itself in such a case, but only a very small number. Kind regards, Pavel Fedin

[BUG] GNU Make - bad default .LIBPATTERNS on Windows/Cygwin

2014-01-10 Thread Pavel Fedin
it check something like $(HOST) set by makefile ? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make

Re: Issue with building make with mingw32 compilers.

2013-11-29 Thread Pavel Fedin
Hello, Eli. Saturday, November 23, 2013, 12:00:49 you wrote: and that means that I need to use --host=i586-mingw32msvc when building make. Why does the prefix end with msvc? The MSVC compiler is not involved in this build or in the target system, so the prefix sounds wrong. May be

VMS port

2013-11-25 Thread Pavel Fedin
Hello! I am restarting work on spawn-patch for Cygwin. Actually, i have the very first version working, but want to try to do some face-lift and get rid of some #ifdef's. My first question is: is VMS port maintained, or dead long ago ? Kind regards, Pavel Fedin Expert Engineer Samsung

RE: VMS port

2013-11-25 Thread Pavel Fedin
the complete 'child' structure, i have checked it but it seems to ignore these new members. So i've got one more question - may be this fragment should become completely generic ? Just with some note that VMS code should also implement handling for it. Kind regards, Pavel Fedin Expert Engineer

Some more refactor suggestions

2013-11-25 Thread Pavel Fedin
itself with some other process which needs to inherit all internal file descriptors. So, the code can be further simplified. Any thoughts / pros / contras ? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia ___ Bug-make

RE: make check under Cygwin

2013-10-03 Thread Pavel Fedin
at my spawn patch on weekend. I remember about env-variable agreement. :) Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make

RE: make check under Cygwin (3.99.93)

2013-10-01 Thread Pavel Fedin
, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make

RE: make check under Cygwin

2013-09-25 Thread Pavel Fedin
, which is a much worse alternative. Just a reminder. I have followed your suggestion and fixed this a month ago. Please try this: http://lists.gnu.org/archive/html/bug-make/2013-08/msg00031.html Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia

RE: [PATCH] Use spawn() in GNU Make on Cygwin, updated

2013-09-01 Thread Pavel Fedin
is not interested in solving this because they say absolutely the same phrase about POSIX and all that. And, in fact, their phrase weights much more, because they already own the computing world. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia

RE: [PATCH] Use spawn() in GNU Make on Cygwin, updated

2013-08-21 Thread Pavel Fedin
. Eli, what about my other work (abspath fix) ? I don't see it in GIT log, and also i see no feedback, so... May be you just don't want to accept anything, and i'm just annoying you ? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia

Re: [PATCH] Use spawn() in GNU Make on Cygwin, updated

2013-08-16 Thread Pavel Fedin
Hello, Paul. Friday, August 16, 2013, 22:18:31 you wrote: Presumably make works at least 99% correctly on Windows using spawn*(). I don't doubt at all that the patch actually works great with most uses of make in Cygwin. However, I would rather be 100% correct and slower than 99% correct

[PATCH 1/2] Fix abspath on Cygwin/MSYS with DOS paths enabled

2013-08-09 Thread Pavel Fedin
HAVE_DOS_PATHS enabled on Cygwin, with this change configure hint can be removed. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia make-3.82.90-1-fix-dos-paths-compatibility.diff Description: Binary data ___ Bug-make

RE: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-07 Thread Pavel Fedin
want to try to build pure Windows version and make sure that it at least doesn't become worse. I need some time to test it and to approve the patch for submission here at Samsung. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia

RE: [PATCH] Use spawn() in GNU Make on Cygwin, updated

2013-08-07 Thread Pavel Fedin
, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make

RE: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-07 Thread Pavel Fedin
. Sorry for not providing a .diff, but this is one-line fix, and approving it is IMHO too much overhead. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org

RE: [PATCH] Use spawn() in GNU Make on Cygwin, updated

2013-08-06 Thread Pavel Fedin
don't care about what someone other than you think, can you accept last chunk of the patch for now (variable rename) ? This would decrease size of speedup patch which i will have to maintain. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia

RE: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-06 Thread Pavel Fedin
Hello! In that case, we need to fix 'abspath', not disable this feature. Ok. If you don't mind, i can try new approach on this. Will it be OK ? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia ___ Bug-make

RE: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-06 Thread Pavel Fedin
it would be possible to determine whether e.g. /foo/bar is an absolute path of DOS-style relative one. Will this solution be OK ? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia ___ Bug-make mailing list Bug-make

[PATCH] Use spawn() in GNU Make on Cygwin, updated

2013-08-05 Thread Pavel Fedin
is not in your system PATH. Cygwin's spawnvpe() screws up badly in such situation. The new patch is attached. I have tested building Cygwin source, works fine. Please test. If OK, i can retry pushing it upstream. -- Kind regards, Pavel Fedin make-3.82.90-1-use-spawn-on-cygwin.diff Description: Binary

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-05 Thread Pavel Fedin
Hello, Eli. Monday, August 5, 2013, 18:44:17 you wrote: I don't yet understand why you have a problem in the first place. It sounds like the single issue is with the 'abspath' function, is that correct? Yes, correct. 2 Christopher Faylor: ac_cv_dos_paths=no configure works just fine

RE: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-04 Thread Pavel Fedin
and Yes on MinGW ? IMHO it's a little bit inconvenient that you have to use config.cache trick in order to build a fully working Make for Cygwin, and this is not documented anywhere. First time, when i didn't know about this, i've got a problem. Kind regards, Pavel Fedin Expert Engineer Samsung

[PATCH1/2] Use spawn() on Cygwin

2013-07-30 Thread Pavel Fedin
Hello! Please take this patch, Cygwin team told that they would like to integrate with upstream. I have already posted it some time ago but got no reply. The patch significantly improves performance of Make under Cygwin. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research

[PATCH 2/2] Do not use DOS paths on Cygwin

2013-07-30 Thread Pavel Fedin
team about __MSYS__ definition. MSys is close to Cygwin, so perhaps this should also be removed. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia make-3.82.90-1-no-dos-paths-on-cygwin.diff Description: Binary data