Re: [PATCH] Add the --nice argument to make

2019-09-17 Thread Andreas Schwab
On Sep 16 2019, Palmer Dabbelt wrote: > @@ -1483,6 +1494,15 @@ main (int argc, char **argv, char **envp) >arg_job_slots = env_slots; >} > > + /* Nice ourselves, if requested. */ > + if (arg_nice) > +{ > +#ifdef HAVE_UNISTD_H > + if (nice(0) == nice(arg_nice)) It is

Re: [PATCH] Add the --nice argument to make

2019-09-17 Thread Eli Zaretskii
> Date: Mon, 16 Sep 2019 18:08:23 -0700 > From: Palmer Dabbelt > Cc: Palmer Dabbelt > > +#ifdef HAVE_UNISTD_H > + if (nice(0) == nice(arg_nice)) > +#endif This is not portable enough, because having unistd.h doesn't yet mean you have 'nice'. E.g., MinGW, which produces native MS-Windows

Re: [PATCH] Add the --nice argument to make

2019-09-16 Thread Philip Guenther
On Mon, Sep 16, 2019 at 4:17 PM Palmer Dabbelt wrote: > I call make quite regularly, and I almost always want to invoke it with > at least a bit of nice to avoid it eating my whole machine. Since I can > stick "-j$(nproc)" in my shell's default MAKEFLAGS I frequently end up > being lazy and

[PATCH] Add the --nice argument to make

2019-09-16 Thread Palmer Dabbelt
I call make quite regularly, and I almost always want to invoke it with at least a bit of nice to avoid it eating my whole machine. Since I can stick "-j$(nproc)" in my shell's default MAKEFLAGS I frequently end up being lazy and just typing "make", which I then have to kill in order to re-run as