[bug #33134] spurious error when stdout is already closed

2013-09-14 Thread Paul D. Smith
Update of bug #33134 (project make): Status:None => Fixed Assigned to:None => psmith Open/Closed:Open => Closed Fixed Release:

[bug #33134] spurious error when stdout is already closed

2011-04-21 Thread David Boyce
Follow-up Comment #2, bug #33134 (project make): My original one-line patch had two mistakes, which may be a record! In the course of work for enhancement #33138 I made a macro: #define STREAM_OK(strm) ((fcntl(fileno((strm)), F_GETFD) != -1) || (errno != EBADF)) whose logic would be much better

Re: [bug #33134] spurious error when stdout is already closed

2011-04-21 Thread David Boyce
On Thu, Apr 21, 2011 at 11:29 AM, Philip Guenther wrote: > On Thu, Apr 21, 2011 at 3:50 AM, David Boyce wrote: >> All quite true and admirably researched but this is not a >> standards-lawyering exercise, it's a software-engineering issue. > > Why are you closing stdout instead of redirecting it

Re: [bug #33134] spurious error when stdout is already closed

2011-04-21 Thread Philip Guenther
On Thu, Apr 21, 2011 at 3:50 AM, David Boyce wrote: > All quite true and admirably researched but this is not a > standards-lawyering exercise, it's a software-engineering issue. Why are you closing stdout instead of redirecting it to /dev/null? Philip Guenther

[bug #33134] spurious error when stdout is already closed

2011-04-21 Thread David Boyce
Follow-up Comment #1, bug #33134 (project make): Note that there is a thread on the bug-make mailing list discussing this in some detail: http://lists.gnu.org/archive/html/bug-make/2011-04/msg00077.html ___ Reply to this item at:

Re: [bug #33134] spurious error when stdout is already closed

2011-04-21 Thread David Boyce
On Thu, Apr 21, 2011 at 1:48 AM, Philip Guenther wrote: [...] All quite true and admirably researched but this is not a standards-lawyering exercise, it's a software-engineering issue. I can't remember how many installers I've run which, when cancelled, finish by saying "ERROR - the software is

Re: [bug #33134] spurious error when stdout is already closed

2011-04-20 Thread Philip Guenther
On Wed, Apr 20, 2011 at 9:31 PM, David Boyce wrote: > On Thu, Apr 21, 2011 at 12:00 AM, Philip Guenther wrote: >> Why is that a mistake? >> >> It appears you're saying that make should complain about failures to >> write to stdout for reasons like EIO, ENOSPC,  and EOVERFLOW, but >> *not* for EBA

RE: [bug #33134] spurious error when stdout is already closed

2011-04-20 Thread Martin Dorey
o:bug-make-bounces+mdorey=bluearc@gnu.org] On Behalf Of David Boyce Sent: Wednesday, April 20, 2011 21:32 To: Philip Guenther Cc: bug-make Subject: Re: [bug #33134] spurious error when stdout is already closed On Thu, Apr 21, 2011 at 12:00 AM, Philip Guenther wrote: > Why is that a mistake?

Re: [bug #33134] spurious error when stdout is already closed

2011-04-20 Thread David Boyce
On Thu, Apr 21, 2011 at 12:00 AM, Philip Guenther wrote: > Why is that a mistake? > > It appears you're saying that make should complain about failures to > write to stdout for reasons like EIO, ENOSPC,  and EOVERFLOW, but > *not* for EBADF. I think you're still not getting my point here. I do no

Re: [bug #33134] spurious error when stdout is already closed

2011-04-20 Thread Philip Guenther
On Wed, Apr 20, 2011 at 7:36 PM, David Boyce wrote: > On Wed, Apr 20, 2011 at 9:58 PM, Philip Guenther wrote: >> Could you explain why you think that's spurious?  Make wanted to write >> "date" to stdout and the write failed.  Seems legit to me. ... > Basically in a (sensible and nicely documente

Re: [bug #33134] spurious error when stdout is already closed

2011-04-20 Thread David Boyce
On Wed, Apr 20, 2011 at 9:58 PM, Philip Guenther wrote: > Could you explain why you think that's spurious?  Make wanted to write > "date" to stdout and the write failed.  Seems legit to me. That's actually not what generates the error message. I'm not sure why it doesn't happen the way you say, b

Re: [bug #33134] spurious error when stdout is already closed

2011-04-20 Thread Philip Guenther
On Wed, Apr 20, 2011 at 6:03 PM, David Boyce wrote: ... > Ironically, make's attempt to be super-duper careful about catching write > errors to stdout (in the close_stdout function) results in a spurious error > message when the user has already closed stdout: > > % cat makefile > .PHONY: all > al

[bug #33134] spurious error when stdout is already closed

2011-04-20 Thread David Boyce
URL: Summary: spurious error when stdout is already closed Project: make Submitted by: boyski Submitted on: Thu 21 Apr 2011 01:03:09 AM GMT Severity: 3 - Normal Item Grou