[bug #57242] Non-recursive command passes invalid jobserver file descriptors

Follow-up Comment #15, bug #57242 (project make): Note the FIFO support has been added to the current GCC master. May I please ask about the next Make release, is it planned any time soon? ___ Reply to this item at:

[bug #57242] Non-recursive command passes invalid jobserver file descriptors

Follow-up Comment #14, bug #57242 (project make): > One note: an ideal implementation would look for the _last_ instance of --jobserver-auth in MAKEFLAGS, not the first instance. In the current code in Git, if we are using anonymous pipes and we invoke a sub-process which is not considered to be

[bug #57242] Non-recursive command passes invalid jobserver file descriptors

Follow-up Comment #13, bug #57242 (project make): OK; I guess if it's the old style anonymous pipe you do something different? One note: an ideal implementation would look for the _last_ instance of --jobserver-auth in MAKEFLAGS, not the first instance. In the current code in Git, if we are

[bug #57242] Non-recursive command passes invalid jobserver file descriptors

Follow-up Comment #12, bug #57242 (project make): [comment #11 comment #11:] > I don't see how that patch can work. There has to be some code somewhere to open the named pipe...?? No. It works by preserving the MAKEFLAGS env. variable as we call make subprocess from lto-wrapper (where the

[bug #57242] Non-recursive command passes invalid jobserver file descriptors

Follow-up Comment #11, bug #57242 (project make): I don't see how that patch can work. There has to be some code somewhere to open the named pipe...?? ___ Reply to this item at:

[bug #57242] Non-recursive command passes invalid jobserver file descriptors

Follow-up Comment #10, bug #57242 (project make): Btw. I've just sent a patch for GCC that supports it: https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599313.html ___ Reply to this item at:

[bug #57242] Non-recursive command passes invalid jobserver file descriptors

Follow-up Comment #9, bug #57242 (project make): [comment #8 comment #8:] > This should be resolved in the next release of GNU make which uses named pipes for the jobserver. Oh, great, thanks a lot for it. We (GCC) have been waiting for the feature for a long time. When can we expect a new make

[bug #57242] Non-recursive command passes invalid jobserver file descriptors

Update of bug #57242 (project make): Status:None => Fixed Assigned to:None => psmith Open/Closed:Open => Closed Fixed Release:

[bug #57242] Non-recursive command passes invalid jobserver file descriptors

Follow-up Comment #7, bug #57242 (project make): About this statement below: "This is necessary, because a command can mess up job server operation or a command may expect a specific fd to be available." a) I wonder how a command can mess up job server operation: a1) One way would be that a

[bug #57242] Non-recursive command passes invalid jobserver file descriptors

Follow-up Comment #6, bug #57242 (project make): I can't speak about the broader situation but Paul's "much simpler" option would certainly be sufficient for my use case. Something else that would be useful to us is a way to force make to consider some or all subprograms to be recursive make

[bug #57242] Non-recursive command passes invalid jobserver file descriptors

Follow-up Comment #5, bug #57242 (project make): It is not TOO hard to provide a custom value (that doesn't include the jobserver options) for the MAKEFLAGS environment variable we set when forking/execing a command that is not a recursive make. It's much trickier to reset the MAKEFLAGS make

[bug #57242] Non-recursive command passes invalid jobserver file descriptors

Follow-up Comment #4, bug #57242 (project make): Hello, I wanted to add that I have written a jobserver client and am currently getting burned by the issue described in this bug. We have an LLVM plugin that is compute-intensive, so it wants to use multiple cores. However, by the time execution

[bug #57242] Non-recursive command passes invalid jobserver file descriptors

Follow-up Comment #3, bug #57242 (project make): I fully agree with Stafan that MAKEFLAGS should be aligned with jobserver FDs. My impression is that a much better approach would be the usage of named pipes instead of file descriptors. I would consider the process relying on fixed file descriptor

[bug #57242] Non-recursive command passes invalid jobserver file descriptors

Follow-up Comment #2, bug #57242 (project make): [comment #1 comment #1:] > Stefan, the behavior you described is intended. > make closes the pipe unless the command has + or (MAKE) or {MAKE}. > This is necessary, because a command can mess up job server operation or a command may expect a

[bug #57242] Non-recursive command passes invalid jobserver file descriptors

Follow-up Comment #1, bug #57242 (project make): Stefan, the behavior you described is intended. make closes the pipe unless the command has + or (MAKE) or {MAKE}. This is necessary, because a command can mess up job server operation or a command may expect a specific fd to be available.

[bug #57242] Non-recursive command passes invalid jobserver file descriptors

URL: Summary: Non-recursive command passes invalid jobserver file descriptors Project: make Submitted by: stefanbruens Submitted on: Fri 15 Nov 2019 07:41:39 PM UTC Severity: 3 -