Re: [bug #64551] Possible null pointer dereference on the function get_buffer

2024-01-21 Thread Haoxin Tu
Hi Martin and Paul, Thanks for your detailed explanation. I have no further concerns now. Have a great day ahead! Best regards, Haoxin Paul Smith 于2024年1月21日周日 23:24写道: > On Sun, 2024-01-21 at 12:00 +0800, Haoxin Tu wrote: > > May I know if you are planning to propose a fix for it? I checked

Re: [bug #64551] Possible null pointer dereference on the function get_buffer

2024-01-21 Thread Paul Smith
On Sun, 2024-01-21 at 12:00 +0800, Haoxin Tu wrote: > May I know if you are planning to propose a fix for it? I checked the > implementations of other `make` versions a bit further, and as far as > I can tell, the issue exists from the older make-4.0.90 (2014-9-30) > to the newest version of make

Re: [bug #64551] Possible null pointer dereference on the function get_buffer

2024-01-20 Thread Martin Dorey
rom. From: bug-make-bounces+martin.dorey=hds@gnu.org on behalf of Haoxin Tu Sent: Saturday, January 20, 2024 20:03 To: Martin Dorey Cc: psm...@gnu.org ; bug-make@gnu.org Subject: Re: [bug #64551] Possible null pointer dereference on the function get_buf

Re: [bug #64551] Possible null pointer dereference on the function get_buffer

2024-01-20 Thread Haoxin Tu
re's a nice catch there - where, in that recursive failure, the >> writing of that terminator overflows a buffer that wasn't actually >> reallocated yet. >> >> ------ >> *From:* Paul Smith >> *Sent:* Saturday, January 20, 2024 07:51 &g

Re: [bug #64551] Possible null pointer dereference on the function get_buffer

2024-01-20 Thread Haoxin Tu
-- > *From:* Paul Smith > *Sent:* Saturday, January 20, 2024 07:51 > *To:* Haoxin Tu ; Martin Dorey < > martin.do...@hitachivantara.com> > *Cc:* bug-make@gnu.org > *Subject:* Re: [bug #64551] Possible null pointer dereference on the > function get_buffer > > **

Re: [bug #64551] Possible null pointer dereference on the function get_buffer

2024-01-20 Thread Martin Dorey
xin Tu ; Martin Dorey Cc: bug-make@gnu.org Subject: Re: [bug #64551] Possible null pointer dereference on the function get_buffer * EXTERNAL EMAIL * On Sat, 2024-01-20 at 23:37 +0800, Haoxin Tu wrote: > But I don't understand why the second invocation of `xrealloc` can > not re

Re: [bug #64551] Possible null pointer dereference on the function get_buffer

2024-01-20 Thread Paul Smith
On Sat, 2024-01-20 at 23:37 +0800, Haoxin Tu wrote: > But I don't understand why the second invocation of `xrealloc` can > not return zero, I apologize for any imprecise information I provided > in the previous emails. Because of what I said in my original reply: > the entire point of xrealloc

Re: [bug #64551] Possible null pointer dereference on the function get_buffer

2024-01-20 Thread Haoxin Tu
- > *From:* bug-make-bounces+martin.dorey=hds@gnu.org > on behalf of Haoxin Tu < > haoxi...@gmail.com> > *Sent:* Saturday, January 20, 2024 06:17 > *To:* Paul D. Smith > *Cc:* Paul D. Smith ; bo...@kolpackov.net < > bo...@kolpackov.net>; bug-make@gnu

Re: [bug #64551] Possible null pointer dereference on the function get_buffer

2024-01-20 Thread Martin Dorey
=68be4f74fce91b76e5915449268d6b5eb687aab9. From: bug-make-bounces+martin.dorey=hds@gnu.org on behalf of Haoxin Tu Sent: Saturday, January 20, 2024 06:17 To: Paul D. Smith Cc: Paul D. Smith ; bo...@kolpackov.net ; bug-make@gnu.org Subject: Re: [bug #64551] Possible null pointer

Re: [bug #64551] Possible null pointer dereference on the function get_buffer

2024-01-20 Thread Haoxin Tu
Hi, Thank you so much for your time and reply. We understand that the entire point of `xrealloc` is never returning 0 to client users/developers who use this function. However, the issue we reported here happens when the `xrealloc` internally handles the returned 0 from `realloc` or `malloc`

[bug #64551] Possible null pointer dereference on the function get_buffer

2024-01-06 Thread Paul D. Smith
Update of bug#64551 (group make): Status:None => Duplicate Assigned to:None => psmith Open/Closed:Open => Closed