Re: [rfc] Colorized output for GNU make?

2011-10-20 Thread Sebastian Pipping
On 10/20/2011 06:40 AM, Paul Smith wrote: However it can take a bit to complete esp. if you reside outside the U.S. (inside the U.S. we can now use scanned documents via email but outside the U.S. we still must rely on physical mail). Outside U.S., yes. I'll send you some options and you

Re: [rfc] Colorized output for GNU make?

2011-10-20 Thread Sebastian Pipping
Hello again! I have some new code ready for you to tear apart, err review :-) I have re-written the patch so that version 2 at [1] does the following: - Add parameter --color[=(yes|no)] to enable/disable color from the command line. Minimal man page entry added, too. - Integrate

Re: [rfc] Colorized output for GNU make?

2011-10-20 Thread Eli Zaretskii
Date: Thu, 20 Oct 2011 20:19:33 +0200 From: Sebastian Pipping sebast...@pipping.org I have some new code ready for you to tear apart, err review :-) Here's mine: + /* Determine target file (i.e. stdout or stderr) and color to pick */ + switch (type) +{ + case

Re: [rfc] Colorized output for GNU make?

2011-10-20 Thread David Boyce
On Thu, Oct 20, 2011 at 2:19 PM, Sebastian Pipping sebast...@pipping.org wrote:  - Add parameter --color[=(yes|no)] to enable/disable color   from the command line. Previously, I suggested XML output piped to a colorizing filter and you indicated a lack of interest in going that way. Which is

Re: [rfc] Colorized output for GNU make?

2011-10-20 Thread Sebastian Pipping
Hello David, to be honest I don't think that --output-format=color is a good choice with regard to usability (or the human factor). Also, it lacks the at-home-feeling for users of grep that --color provides. Best, Sebastian ___ Bug-make mailing

Re: [rfc] Colorized output for GNU make?

2011-10-20 Thread Sebastian Pipping
On 10/20/2011 08:43 PM, Eli Zaretskii wrote: Date: Thu, 20 Oct 2011 20:19:33 +0200 From: Sebastian Pipping sebast...@pipping.org I have some new code ready for you to tear apart, err review :-) Here's mine: Thanks Eli! + /* Determine target file (i.e. stdout or stderr) and color to

Re: [rfc] Colorized output for GNU make?

2011-10-20 Thread Eli Zaretskii
Date: Fri, 21 Oct 2011 00:33:51 +0200 From: Sebastian Pipping sebast...@pipping.org + /* Determine target file (i.e. stdout or stderr) and color to pick */ + switch (type) +{ + case OT_DIR_ENTER: target = stdout; color = color_dir_enter; break; + case