make bug with ONESHELL and SHELLFLAGS

2011-12-22 Thread michael_rytting
Sorry if this has already been reported but I haven't found anything searching through the archives. SHELL = /bin/bash .SHELLFLAGS = -e -o pipefail -c Works .ONESHELL: SHELL = /bin/bash .SHELLFLAGS = -e -o pipefail -c Doesn't When the ONESHELL target is set .SHELLFLAGS must be set to a

Re: make bug with ONESHELL and SHELLFLAGS

2011-12-22 Thread David Boyce
I believe the patch below would fix this. It's up to Paul of course whether he considers it a bug and considers the patch worthy. The only concern I have with it is that there may be places where the argv is assumed to be exactly 4 slots wide (shell, flags, recipe, null) and only the first 3 slots

RE: make bug with ONESHELL and SHELLFLAGS

2011-12-22 Thread michael_rytting
Since I build make myself I went ahead and applied this patch and it works great. I'll let you guys decide if this should go into the official release, but we are happy. -Mike -Original Message- From: David Boyce [mailto:david.s.bo...@gmail.com] Sent: Thursday, December 22, 2011 2:43