Re: [PATCH] output.c: Fix memory stomp when need==fmtbuf.size

2014-01-27 Thread Paul Smith
On Sun, 2014-01-26 at 16:35 +, Ray Donnelly wrote: I missed a few assert cases in the previous patch. Please find a fixed version attached. Thanks Ray; I'm utterly swamped for the last week or so with real life but I should have a bit more free time later this week; I'll check out your fix.

Re: win32 compilation of make 4.0 source code‏

2014-01-27 Thread Paul Smith
On Sun, 2014-01-26 at 16:22 -0800, Mark Brown wrote: That example method is a device to perform this .FEATURES test without inserting it into an existing Makefile. The syntax errors I was seeing were occurring when attempting to insert this test into an existing Makefile, full of Targets and

Re: win32 compilation of make 4.0 source code‏

2014-01-27 Thread Mark Brown
First, let me request that you include the question posed to you, in your Reply responses in this email sequence. 1) I think my question was explicit. A method for an existing Makefile to test for .FEATURES capabilities when it is downloaded to a random linux or Windows make environment and

Re: [PATCH] output.c: Fix memory stomp when need==fmtbuf.size

2014-01-27 Thread Ray Donnelly
No problem Paul, thanks for replying. I could've made it less intrusive by changing the test for whether to reallocate to: /* Make sure we have room. */ if (need = fmtbuf.size) .. instead (so just a single '=' character change) but when I see assert (fmtbuf.buffer[len] == '\0'); it doesn't

Re: win32 compilation of make 4.0 source code

2014-01-27 Thread Philip Guenther
On Mon, Jan 27, 2014 at 9:59 AM, Mark Brown mkbrown_...@hotmail.com wrote: First, let me request that you include the question posed to you, in your Reply responses in this email sequence. How about you stop top-posting and instead reply inline? 1) I think my question was explicit. A

Re: win32 compilation of make 4.0 source code

2014-01-27 Thread Philip Guenther
(Dang it: gmail treats control-enter as send...) On Mon, Jan 27, 2014 at 1:12 PM, Philip Guenther guent...@gmail.com wrote: On Mon, Jan 27, 2014 at 9:59 AM, Mark Brown mkbrown_...@hotmail.com wrote: First, let me request that you include the question posed to you, in your Reply responses in

Re: win32 compilation of make 4.0 source code

2014-01-27 Thread Mark Brown
-Original Message- From: Philip Guenther Sent: Monday, January 27, 2014 1:34 PM To: Mark Brown Cc: Paul Smith ; bug-make Subject: Re: win32 compilation of make 4.0 source code (Dang it: gmail treats control-enter as send...) [Gmail is overrated. When I saw I could not free create

Re: win32 compilation of make 4.0 source code

2014-01-27 Thread Mark Brown
-Original Message- From: Philip Guenther Sent: Monday, January 27, 2014 1:34 PM To: Mark Brown Cc: Paul Smith ; bug-make Subject: Re: win32 compilation of make 4.0 source code (Dang it: gmail treats control-enter as send...) [Gmail is overrated. When I saw I could not free create