Re: [PATCH] Refactor and merge child_execute_job() code

2014-01-30 Thread Eli Zaretskii
Date: Thu, 30 Jan 2014 01:16:34 +0400 From: Pavel Fedin pavel_fe...@mail.ru Hello! This is my long-promised refactor. After this it's much easier to apply runtime selection between spawn() and fork() on Cygwin, because all differences are now consolidated in two functions:

Re: [PATCH] Refactor and merge child_execute_job() code

2014-01-30 Thread Paul Smith
On Thu, 2014-01-30 at 19:29 +0200, Eli Zaretskii wrote: I will review the patch some more in a day or two. (And I hope Paul will as well.) Yes, definitely, but it won't be until the weekend I expect. Life is intruding on hacking this month. ___

Re: [PATCH] Refactor and merge child_execute_job() code

2014-01-30 Thread Eli Zaretskii
From: Paul Smith psm...@gnu.org Cc: Pavel Fedin pavel_fe...@mail.ru, bug-make@gnu.org Date: Thu, 30 Jan 2014 12:33:41 -0500 On Thu, 2014-01-30 at 19:29 +0200, Eli Zaretskii wrote: I will review the patch some more in a day or two. (And I hope Paul will as well.) Yes, definitely, but