Re: [PATCH] output.c: Fix memory stomp when need==fmtbuf.size

2014-02-04 Thread Paul Smith
On Tue, 2014-02-04 at 10:33 +, Ray Donnelly wrote: I can't see it in the git repository yet. .. am I being too impatient? Sorry, it's committed in my local repo at home but I haven't pushed. I'll do that tonight. ___ Bug-make mailing list

Re: [bug #41246] Allow to switch shell batch mode at runtime instead of build time

2014-02-04 Thread Eli Zaretskii
Date: Tue, 4 Feb 2014 13:34:31 +0900 From: Mike Hommey m...@glandium.org Cc: psm...@gnu.org, bo...@kolpackov.net, bug-make@gnu.org On Sat, Feb 01, 2014 at 11:29:19AM +0200, Eli Zaretskii wrote: From: Paul Smith psm...@gnu.org Cc: Mike Hommey m...@glandium.org, mh+savan...@glandium.org,

Re: [bug #41246] Allow to switch shell batch mode at runtime instead of build time

2014-02-04 Thread Paul Smith
On Tue, 2014-02-04 at 18:54 +0200, Eli Zaretskii wrote: Another issue is with backslashes in paths. For example: $ cat EOF foo.mk foo: grep foo foo\\bar EOF (Note the is just there to trigger sh -c) This executes sh -c grep foo foo\\bar, which fails with:

Re: [bug #41246] Allow to switch shell batch mode at runtime instead of build time

2014-02-04 Thread Eli Zaretskii
From: Paul Smith psm...@gnu.org Cc: Mike Hommey m...@glandium.org, bug-make@gnu.org Date: Tue, 04 Feb 2014 12:28:53 -0500 But I do see a problem above; what if the literal file 'foo\bar' (a file with a backslash in the name) existed? Such a file cannot exist on Windows: the backslash

Re: [bug #41246] Allow to switch shell batch mode at runtime instead of build time

2014-02-04 Thread Daniel Herring
On Tue, 4 Feb 2014, Eli Zaretskii wrote: From: Paul Smith psm...@gnu.org Cc: Mike Hommey m...@glandium.org, bug-make@gnu.org Date: Tue, 04 Feb 2014 12:28:53 -0500 But I do see a problem above; what if the literal file 'foo\bar' (a file with a backslash in the name) existed? Such a file

Re: [bug #41246] Allow to switch shell batch mode at runtime instead of build time

2014-02-04 Thread Mike Hommey
On Tue, Feb 04, 2014 at 12:28:53PM -0500, Paul Smith wrote: On Tue, 2014-02-04 at 18:54 +0200, Eli Zaretskii wrote: Another issue is with backslashes in paths. For example: $ cat EOF foo.mk foo: grep foo foo\\bar EOF (Note the is just there to trigger sh

Re: [bug #41246] Allow to switch shell batch mode at runtime instead of build time

2014-02-04 Thread Mike Hommey
On Tue, Feb 04, 2014 at 06:54:36PM +0200, Eli Zaretskii wrote: Why are you using backslashes in file names when your shell is a Unixy shell? That makes little sense to me, and I don't see why Make on Windows should support such use. Unixy shells are supposed to get Unixy file names with