Re: error reporting

2014-04-08 Thread Paul Smith
On Mon, 2014-04-07 at 21:26 -0700, Philip Guenther wrote: I am unable to reproduce this: Based on the offer of MSVC project files I would guess Rob is running on Windows. I expect this is a result of the buggy snprintf()/vsnprintf() implementations in the Windows MSVC compiler (well, by buggy I

Re: vms:test variables

2014-04-08 Thread h.becker
On 04/08/2014 07:28 AM, John E. Malmberg wrote: On 4/7/2014 4:37 PM, h.becker wrote: $ @TEST_MAKE -- Running tests for GNU make on VMS GNU Make 4.0.90

RE: error reporting

2014-04-08 Thread Rob Juergens
You are correct in that building make-4.0 on solaris does not show that problem. However building with VS2013 does not fix it. Attached are 2013 files and updated other files -Original Message- From: Paul Smith [mailto:psm...@gnu.org] Sent: Tuesday, April 08, 2014 5:07 AM To: Philip

RE: error reporting

2014-04-08 Thread Rob Juergens
Note that in Unix, vsnprintf() returns the TOTAL number of chars needed (add 1 for the null). If the output would overflow the buffer, then you would get a return value larger than the specified buffer size. In Windoze, vsnprintf() will return -1 if the buffer would be overflowed, and there

Re: error reporting

2014-04-08 Thread Paul Smith
On Tue, 2014-04-08 at 20:15 +, Rob Juergens wrote: Note that in Unix, vsnprintf() returns the TOTAL number of chars needed (add 1 for the null). If the output would overflow the buffer, then you would get a return value larger than the specified buffer size. In Windoze, vsnprintf()

RE: error reporting

2014-04-08 Thread Rob Juergens
Attached is a rewrite of the method vfmtconcat() in output.c. It seems to fix the problem. -Original Message- From: Paul Smith [mailto:psm...@gnu.org] Sent: Tuesday, April 08, 2014 2:00 PM To: Rob Juergens Cc: Philip Guenther; bug-make@gnu.org Subject: Re: error reporting On Tue,

Re: error reporting

2014-04-08 Thread Paul Smith
On Tue, 2014-04-08 at 21:01 +, Rob Juergens wrote: Attached is a rewrite of the method vfmtconcat() in output.c. It seems to fix the problem. Thanks, but as Philip mentioned earlier I've completely rewritten the output.c file and callers of it so they use only C89 compliant functions (so no

[bug #41983] $(file) function crashes make

2014-04-08 Thread Paul D. Smith
Follow-up Comment #4, bug #41983 (project make): Thanks Tim. Technically according to the docs it's not legal to call file without an argument; in other words, you should be running $(file 4touch,) (note the comma) instead. However, to be clear this will add a newline to the file in all cases,