[bug #63516] `include` of absolute path prepends path with `./`

[Eli Zaretskii]

Follow-up Comment #5, bug #63516 (project make):

Thanks for the patch.

I have three comments:

(1) The test under "WINDOWS32" should allow a backslash after the colon as
well as a forward slash.

(2) Do we want Make to consider "drive-relative" file names, as in
"d:foo/bar", relative or absolute?  I think the latter, so I suggest not to
require the 3rd character to be a slash, in which case (1) gets solved
automatically.

(3) Unis-style absolute file names, like "/foo/bar", should also be considered
"absolute" on Windows, and likewise "\foo\bar".  Which brings the backslash
issue back.




___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

Re: [bug #63516] `include` of absolute path prepends path with `./`

[Jeffrey Walton]

On Thu, Dec 15, 2022 at 4:17 PM anonymous  wrote:
>
> Follow-up Comment #4, bug #63516 (project make):
>
> I've attached my fix in case it's helpful.  Also attached is a small fix to
> `bootstrap.bat` that I had to make to get it to build with `tcc`.
>
> (file #54105, file #54106)

Regarding this from the make part of the patch:

+is_abs = is_abs && path[2] && (path[2] == '/');

Isn't it possible to use Windows path separator in one of the ports by
escaping the backslash? I.e., you may encounter 'C:\\..." in the wild?

(I generally don't use *nix on Windows. But I think there's some
differences among MinGW, Cygwin and MSYS2, and permissible path
separators).

Jeff

[bug #63516] `include` of absolute path prepends path with `./`

[anonymous]

Follow-up Comment #4, bug #63516 (project make):

I've attached my fix in case it's helpful.  Also attached is a small fix to
`bootstrap.bat` that I had to make to get it to build with `tcc`.

(file #54105, file #54106)

___

Additional Item Attachment:

File name: 0001-Remove-extra-backslash-in-sed-invocation.patch Size:0 KB
   


File name: 0002-Windows-Fix-check-for-absolute-pathnames-of-include-.patch
Size:1 KB
   




___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/