No progress output when make 4.4.1 builds Linux 4.19 and earlier

2023-03-08 Thread Eric Biggers
After upgrading to make v4.4.1 (released last week), there's no longer any
progress output from builds of the Linux kernel v4.19 and earlier.  It seems the
actual build still works, but it's now silent except for warnings and errors.

It bisects to the following 'make' commit:

commit dc2d963989b96161472b2cd38cef5d1f4851ea34
Author: Dmitry Goncharov 
Date:   Sun Nov 27 14:09:17 2022 -0500

[SV 63347] Always add command line variable assignments to MAKEFLAGS

Is this an intentional breakage from the 'make' side?

- Eric



Re: No progress output when make 4.4.1 builds Linux 4.19 and earlier

2023-03-08 Thread Eric Biggers
On Wed, Mar 08, 2023 at 07:17:37AM +0100, Greg KH wrote:
> On Tue, Mar 07, 2023 at 10:13:45PM -0800, Eric Biggers wrote:
> > After upgrading to make v4.4.1 (released last week), there's no longer any
> > progress output from builds of the Linux kernel v4.19 and earlier.  It 
> > seems the
> > actual build still works, but it's now silent except for warnings and 
> > errors.
> > 
> > It bisects to the following 'make' commit:
> > 
> > commit dc2d963989b96161472b2cd38cef5d1f4851ea34
> > Author: Dmitry Goncharov 
> > Date:   Sun Nov 27 14:09:17 2022 -0500
> > 
> > [SV 63347] Always add command line variable assignments to MAKEFLAGS
> > 
> > Is this an intentional breakage from the 'make' side?
> 
> Ah, thanks for figuring this out, it's been bugging me locally for a bit
> as well!  The fact that kernels 5.4 and newer imply to me that there is
> a kernel build fix that should resolve this if someone can take the time
> to bisect it...
> 

Fix bisection comes up with the following kernel commit:

commit 80463f1b7bf9f822fd3495139bcf3ef254fdca10
Author: Masahiro Yamada 
Date:   Fri Sep 14 15:33:23 2018 +0900

kbuild: add --include-dir flag only for out-of-tree build

But only for in-tree builds.  Out-of-tree builds need:

commit 3812b8c5c5d527239ac015f1f2c7654da7fcfbba
Author: Masahiro Yamada 
Date:   Fri Feb 22 16:40:07 2019 +0900

kbuild: make -r/-R effective in top Makefile for old Make versions

Masahiro, what dependencies (if any) do the above two commits have in order to
be backported to 4.19 and 4.14?

- Eric