Follow-up Comment #3, bug #33125 (project make):
So I'm happy to make this change, because it does seem cleaner, but I must
confess I don't understand how the original error is caused by it.
The code uses isspace() to count spaces the first time through the list.
isspace() matches spaces and
Follow-up Comment #4, bug #33125 (project make):
I understand your puzzlement - the more I think about it the less I personally
understand...
I will capture the string - there is no easy test case, because the android
build system isn't exactly trivial. It was only found due to corruption in
Follow-up Comment #5, bug #33125 (project make):
Find the captured string attached (excerpt of a debug output). If you analyze
it in a hex dumper, you'll see a number of LF / space combinations.
Because the splitting function does not split at LFs, it creates a number of
single LF tokens split
Update of bug #33125 (project make):
Status:None = Fixed
Assigned to:None = psmith
Open/Closed:Open = Closed
Operating System:
Follow-up Comment #7, bug #33125 (project make):
I also create a test case for regression testing. It's pretty trivial, I'm
attaching it here.
I'm just unsure in which script this should be added to. Presumably
functions/sort. Please do as seems fit.
(file #23337)
Follow-up Comment #8, bug #33125 (project make):
I added a regression test with my fix. It won't show any difference in
behavior unless you run it in valgrind or similar though.
___
Reply to this item at:
URL:
http://savannah.gnu.org/bugs/?33125
Summary: make fails building android build environment due to
memory corruption
Project: make
Submitted by: mshopf
Submitted on: Tue 19 Apr 2011 01:37:36 PM GMT
Severity: 3 -
Follow-up Comment #1, bug #33125 (project make):
Just found that this apparently breaks test variables/define.
Analyzing.
___
Reply to this item at:
http://savannah.gnu.org/bugs/?33125
___
Follow-up Comment #2, bug #33125 (project make):
Please use ONLY the revised patch; it doesn't change whitespace handling in
tokenization, which introduced an incompatible semantic change.
The revised patch only fixes array counting as considered in the original
report.
All test cases are
