On Thu, Apr 21, 2011 at 1:48 AM, Philip Guenther guent...@gmail.com wrote:
[...]
All quite true and admirably researched but this is not a
standards-lawyering exercise, it's a software-engineering issue.
I can't remember how many installers I've run which, when cancelled,
finish by saying ERROR
Follow-up Comment #1, bug #33134 (project make):
Note that there is a thread on the bug-make mailing list discussing this in
some detail:
http://lists.gnu.org/archive/html/bug-make/2011-04/msg00077.html
___
Reply to this item at:
On Thu, Apr 21, 2011 at 3:50 AM, David Boyce david.s.bo...@gmail.com wrote:
All quite true and admirably researched but this is not a
standards-lawyering exercise, it's a software-engineering issue.
Why are you closing stdout instead of redirecting it to /dev/null?
Philip Guenther
On Thu, Apr 21, 2011 at 11:29 AM, Philip Guenther guent...@gmail.com wrote:
On Thu, Apr 21, 2011 at 3:50 AM, David Boyce david.s.bo...@gmail.com wrote:
All quite true and admirably researched but this is not a
standards-lawyering exercise, it's a software-engineering issue.
Why are you
Follow-up Comment #2, bug #33134 (project make):
My original one-line patch had two mistakes, which may be a record! In the
course of work for enhancement #33138 I made a macro:
#define STREAM_OK(strm) ((fcntl(fileno((strm)), F_GETFD) != -1) || (errno !=
EBADF))
whose logic would be much better
URL:
http://savannah.gnu.org/bugs/?33134
Summary: spurious error when stdout is already closed
Project: make
Submitted by: boyski
Submitted on: Thu 21 Apr 2011 01:03:09 AM GMT
Severity: 3 - Normal
Item
On Wed, Apr 20, 2011 at 6:03 PM, David Boyce invalid.nore...@gnu.org wrote:
...
Ironically, make's attempt to be super-duper careful about catching write
errors to stdout (in the close_stdout function) results in a spurious error
message when the user has already closed stdout:
% cat makefile
On Wed, Apr 20, 2011 at 9:58 PM, Philip Guenther guent...@gmail.com wrote:
Could you explain why you think that's spurious? Make wanted to write
date to stdout and the write failed. Seems legit to me.
That's actually not what generates the error message. I'm not sure why
it doesn't happen the
+mdorey=bluearc@gnu.org] On Behalf Of David Boyce
Sent: Wednesday, April 20, 2011 21:32
To: Philip Guenther
Cc: bug-make
Subject: Re: [bug #33134] spurious error when stdout is already closed
On Thu, Apr 21, 2011 at 12:00 AM, Philip Guenther guent...@gmail.com wrote:
Why is that a mistake
