Re: make check under Cygwin

2013-10-05 Thread Paul Smith
On Wed, 2013-09-25 at 11:30 +0200, Denis Excoffier wrote: Still experimenting 'make check' with Cygwin (without the spawn-patch, with --disable-load): 1) In test_driver.pl, line 486 (look for Test returned), a comparison of $code against the value -1 is performed. However, 3 lines above the

RE: make check under Cygwin

2013-10-03 Thread Pavel Fedin
Hello! Please take a look at the change I made, it takes care of all those things at a price of only 5 changed lines. I see. Should work, indeed. I'd say the resulting code is less optimal (repeated conditions, strncpy() with length = 1) and a bit more difficult to understand. But, after

Re: make check under Cygwin

2013-10-02 Thread Eli Zaretskii
From: Pavel Fedin p.fe...@samsung.com Cc: bug-...@denis-excoffier.org, bug-make@gnu.org Date: Thu, 26 Sep 2013 10:47:15 +0400 There must be a better way, since the only difference between Posix and Windows file names is the X: prefix of every absolute file name. Yes. But in certain

make check under Cygwin (3.99.93)

2013-10-01 Thread Denis Excoffier
Hello, Thank you for this new RC. I have tested make-3.99.93 under cygwin 32 bits with --disable-load (and without the spawn-patch). Several items that i had reported in http://lists.gnu.org/archive/html/bug-make/2013-09/msg00110.html (and for which i didn't get any feedback) are still there.

RE: make check under Cygwin (3.99.93)

2013-10-01 Thread Pavel Fedin
Hello! Also, for information with the spawn-patch, the output-sync test still fails (like for 3.99.92, this is not unexpected), but now (with 3.99.93) the GNUMAKEFLAGS test also fails. Thank you very much for testing. I will really try to apply my hands to it this weekend. Kind regards,

Re: make check under Cygwin (3.99.93)

2013-10-01 Thread Paul Smith
On Tue, 2013-10-01 at 11:04 +0200, Denis Excoffier wrote: Hello, Thank you for this new RC. I have tested make-3.99.93 under cygwin 32 bits with --disable-load (and without the spawn-patch). Several items that i had reported in

RE: make check under Cygwin

2013-09-25 Thread Pavel Fedin
Hello! I think the problem is abspath, which fails on Cygwin with DOS-style file names with a drive letter. Fixing that function on Cygwin is a priority for this release, if possible. The patch you suggest, OTOH, entirely disables support for DOS-style file names in the Cygwin build,

Re: make check under Cygwin

2013-09-25 Thread Eli Zaretskii
From: Pavel Fedin p.fe...@samsung.com Cc: bug-make@gnu.org Date: Wed, 25 Sep 2013 16:12:10 +0400 Just a reminder. I have followed your suggestion and fixed this a month ago. Please try this: http://lists.gnu.org/archive/html/bug-make/2013-08/msg00031.html I didn't forget, I just don't