[PATCH] configure.ac: Fix gettimeofday check for C99 compilers

2019-09-10 Thread Florian Weimer
* configure.ac (HAVE_GETTIMEOFDAY): Avoid reference to undeclared exit function. --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index f6919a7..5897ae5 100644 --- a/configure.ac +++ b/configure.ac @@ -127,8 +127,8 @@ AC_CACHE_CHE

[bug #56834] PATH not honored when --disable-posix-spawn is not used

2019-09-10 Thread Paul D. Smith
Update of bug #56834 (project make): Status:None => Fixed Assigned to:None => psmith Open/Closed:Open => Closed Fixed Release:

Re: patch to fix features/archives test 10 on sunos

2019-09-10 Thread Paul Smith
On Mon, 2019-09-09 at 22:30 -0400, Dmitry Goncharov via Bug reports and discussion for GNU make wrote: > ar add output is system dependent. Thanks Dmitry; I had already made basically that same change. See the latest Git master (pushed this morning). I plan to make a new release candidate this w

Re: patch to fix features/archives test 10 on sunos

2019-09-10 Thread Eli Zaretskii
> From: Paul Smith > Date: Tue, 10 Sep 2019 08:36:24 -0400 > > I plan to make a new release candidate this week. Did you have a chance to review the patch I proposed in https://lists.gnu.org/archive/html/bug-make/2019-08/msg00106.html? I'd like to install it. Also, regarding SV 56449: are you o

Re: patch to fix features/archives test 10 on sunos

2019-09-10 Thread Paul Smith
On Tue, 2019-09-10 at 17:47 +0300, Eli Zaretskii wrote: > > From: Paul Smith > > Date: Tue, 10 Sep 2019 08:36:24 -0400 > > > > I plan to make a new release candidate this week. > > Did you have a chance to review the patch I proposed in > https://lists.gnu.org/archive/html/bug-make/2019-08/msg00

Windows error messages

2019-09-10 Thread Paul Smith
It's always annoyed me that the Windows error messages generated by make are so much different (and, arguably, less understandable) than the ones it generates on other platforms. For example on GNU/Linux: ! make: foobar: No such file or directory ! make: *** [work/misc/general4.mk.7;3: all] Error

[bug #56449] job.c (construct_command_argv_internal): Must use shell if '%' character is present in recipe line

2019-09-10 Thread Eli Zaretskii
Update of bug #56449 (project make): Severity: 3 - Normal => 1 - Wish Status: Fixed => Wont Fix Open/Closed:Open => Closed Fixed Release:

Re: patch to fix features/archives test 10 on sunos

2019-09-10 Thread Eli Zaretskii
> From: Paul Smith > Cc: dgoncha...@users.sf.net, bug-make@gnu.org > Date: Tue, 10 Sep 2019 11:47:35 -0400 > > On Tue, 2019-09-10 at 17:47 +0300, Eli Zaretskii wrote: > > > From: Paul Smith > > > Date: Tue, 10 Sep 2019 08:36:24 -0400 > > > > > > I plan to make a new release candidate this week.

wildcard ignores dangling symlinks, and .MAKEPID

2019-09-10 Thread David Boyce
These are two minor topics and I'm not asking for anything to be done about either for the upcoming release but I thought it couldn't hurt to mention them for discussion. First, the $(wildcard ...) function appears to rely on stat(), not lstat(), which means it considers a dangling symlink to not e

Re: Windows error messages

2019-09-10 Thread Eli Zaretskii
> From: Paul Smith > Date: Tue, 10 Sep 2019 11:58:59 -0400 > > ! process_begin: CreateProcess(NULL, foobar, ...) failed. > ! make (e=2): The system cannot find the file specified. > ! make: *** [work/misc/general4.mk.7;3: all] Error 2 > > Aside from the error code, is there a good reason to show

Re: patch to fix features/archives test 10 on sunos

2019-09-10 Thread Paul Smith
On Tue, 2019-09-10 at 19:17 +0300, Eli Zaretskii wrote: > Btw, I see you added support for dirent.d_type for dirent functions > emulation when compiling with MSVC, but I don't think Make uses this > anywhere, except when building with glibc. In particular, the > HAVE_STRUCT_DIRENT_D_TYPE macro doe

Re: patch to fix features/archives test 10 on sunos

2019-09-10 Thread Eli Zaretskii
> From: Paul Smith > Cc: bug-make@gnu.org > Date: Tue, 10 Sep 2019 12:35:18 -0400 > > > Btw, I see you added support for dirent.d_type for dirent functions > > emulation when compiling with MSVC, but I don't think Make uses this > > anywhere, except when building with glibc. In particular, the >

Make error messages

2019-09-10 Thread Paul Smith
I've gone through a few iterations of the format of make error messages and I'm still not happy. Originally we didn't put the makefile name/linenumber in the error at all when a recipe failed (we did for syntax errors in makefiles of course). Then someone asked for make to show a reference to the

patch to fix grouped_targets test 1

2019-09-10 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
Good morning. echo -n is not portable. Certain implementations of echo everything, including -n. This makes test 1 of grouped_targets fail. regards, Dmitry diff --git a/tests/scripts/features/grouped_targets b/tests/scripts/features/grouped_targets index ef9366b..4d2c9d2 100644 --- a/tests/scrip

vpathplus test 2 patch

2019-09-10 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
The new hashing mechanism hashes differently on big vs little endian. This makes vpathplus test 2 fail, because the order of intermediate files inter.b and inter.c is now dependent on endiannes. regards, Dmitry diff --git a/tests/scripts/features/vpathplus b/tests/scripts/features/vpathplus index

Re: Make error messages

2019-09-10 Thread Andreas Schwab
On Sep 10 2019, Paul Smith wrote: > That didn't work, however, because particularly in recursive make the > makefile name is likely not qualified with a path, but the current > working directory when the build is invoked is not the same as the one > where make is invoked--thus "Makefile" is at be

Re: vpathplus test 2 patch

2019-09-10 Thread Andreas Schwab
On Sep 10 2019, Dmitry Goncharov via Bug reports and discussion for GNU make wrote: > The new hashing mechanism hashes differently on big vs little endian. Should this be considered as a bug? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4B