[bug #58656] Cannot handle over 2GB file on Windows

[Eli Zaretskii]

Update of bug #58656 (project make):

  Status:None => Fixed  
 Open/Closed:Open => Closed 
   Fixed Release:None => SCM

___

Follow-up Comment #6:

Thanks, I installed a slightly modified version of your second patch.


___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #58656] Cannot handle over 2GB file on Windows

[Makoto Kato]

Follow-up Comment #5, bug #58656 (project make):

Sorry for delay. I have missed your comment.

[comment #4 comment #4:]
> Sorry, I failed to respond at the time.
> 
> The second variant is better, but it seems to affect only MSVC builds?  What
about MinGW64 builds?
> 

This is MSVC runtime only. When I use MSYS2/MingW64, stat returns 0 even if
file size is over 2GB.

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #58656] Cannot handle over 2GB file on Windows

[Eli Zaretskii]

Follow-up Comment #4, bug #58656 (project make):

Sorry, I failed to respond at the time.

The second variant is better, but it seems to affect only MSVC builds?  What
about MinGW64 builds?


___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #58656] Cannot handle over 2GB file on Windows

[Paul D. Smith]

Follow-up Comment #3, bug #58656 (project make):

@eliz did you have any comments on the second form of this patch or should I
apply it?

Cheers!

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #58656] Cannot handle over 2GB file on Windows

[Makoto Kato]

Follow-up Comment #2, bug #58656 (project make):

[comment #1 comment #1:]
> Thanks.
> 
> However, this change cannot be unconditional even on MS-Windows, because
_stati64 and 'struct _stat64' are not available on all versions of Windows.
> 
> Also, AFAIK _stati64 accepts an argument of type 'struct stati64', not
'struct _stat64', see
> 
>  
https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/stat-functions?view=vs-2019
> 
> Would you like to modify the patch to fix the above 2 issues?

Updated fix with VC version check and using _stat64. Do you have any comment?

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #58656] Cannot handle over 2GB file on Windows

[Makoto Kato]

Additional Item Attachment, bug #58656 (project make):

File name: 0001-make-cannot-handle-over-2GB-file-on-Windows.patch Size:1 KB
   




___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #58656] Cannot handle over 2GB file on Windows

[Eli Zaretskii]

Update of bug #58656 (project make):

  Item Group: Bug => Enhancement
 Assigned to:None => eliz   
   Triage Status:None => Small Effort   

___

Follow-up Comment #1:

Thanks.

However, this change cannot be unconditional even on MS-Windows, because
_stati64 and 'struct _stat64' are not available on all versions of Windows.

Also, AFAIK _stati64 accepts an argument of type 'struct stati64', not 'struct
_stat64', see

 
https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/stat-functions?view=vs-2019

Would you like to modify the patch to fix the above 2 issues?


___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #58656] Cannot handle over 2GB file on Windows

[Makoto Kato]

URL:
  

 Summary: Cannot handle over 2GB file on Windows
 Project: make
Submitted by: mkato
Submitted on: Fri 26 Jun 2020 06:05:07 PM JST
Severity: 3 - Normal
  Item Group: Bug
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
   Component Version: SCM
Operating System: MS Windows
   Fixed Release: None
   Triage Status: None

___

Details:

Actually, windows version uses stat when checking mtime. But stat
returns -1 when file size is over 2GB. So we should use _stati64 instead.



___

File Attachments:


---
Date: Fri 26 Jun 2020 06:05:07 PM JST  Name:
0001-make-cannot-handle-over-2GB-file-on-Windows.patch  Size: 1KiB   By: mkato
fix


___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/