[bug #62174] fix test functions/shell on aix.

[Dmitry Goncharov]

Follow-up Comment #5, bug #62174 (project make):

I can confirm the current code works. Thank you.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #62174] fix test functions/shell on aix.

[Paul D. Smith]

Follow-up Comment #4, bug #62174 (project make):

Hm.  the code tries to reset the locale to "C" before it detects any of this
stuff.  I guess maybe the method it uses (calling POSIX::setlocale()) isn't
sufficient?

OK I'll address this.

I think the idea was that we didn't want to change the locale for the
top-level Perl, so that any messages generated by it would be in the correct
locale.  We only wanted to set the locale inside the tests.  That's why we try
to set the locale to "C", then set it back again after we are done.

Maybe that's not worthwhile.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #62174] fix test functions/shell on aix.

[Dmitry Goncharov]

Follow-up Comment #3, bug #62174 (project make):

i guess this fell through the cracks. Paul, can you please have a look at
sv62174_fix2.diff?


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #62174] fix test functions/shell on aix.

[Dmitry Goncharov]

Follow-up Comment #2, bug #62174 (project make):

Paul, the changes that were introduced in toplevel to set LANG=C do not have
desired effect, because run_make_tests.pl sets $ERR_command_not_found before
 is called.

Since you didn't like removing LANG from environment, i attached another patch
(sv62174_fix2.diff) which sets LANG=C before $ERR_command_not_found is
initialized.


___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #62174] fix test functions/shell on aix.

[Dmitry Goncharov]

Additional Item Attachment, bug #62174 (project make):

File name: sv62174_fix2.diff  Size:0 KB




___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #62174] fix test functions/shell on aix.

[Paul D. Smith]

Update of bug #62174 (project make):

  Status:None => Fixed  
 Assigned to:None => psmith 
 Open/Closed:Open => Closed 
   Fixed Release:None => SCM

___

Follow-up Comment #1:

Fixed.  Thanks.


___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #62174] fix test functions/shell on aix.

[Dmitry Goncharov]

Additional Item Attachment, bug #62174 (project make):

File name: test_functions_shell_fix_on_aix.diff Size:0 KB
   




___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #62174] fix test functions/shell on aix.

[Dmitry Goncharov]

URL:
  

 Summary: fix test functions/shell on aix.
 Project: make
Submitted by: dgoncharov
Submitted on: Sat 12 Mar 2022 11:14:40 PM UTC
Severity: 3 - Normal
  Item Group: Bug
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
   Component Version: SCM
Operating System: None
   Fixed Release: None
   Triage Status: None

___

Details:

Presence of LANG=en_US in the env causes functions/shell test 8 to fail on
aix.



functions/shell . FAILED (8/9 passed)

1 Test in 1 Category Failed (See .diff* files in work dir for details) :-(

$ cat work/functions/shell.diff.8
*** work/functions/shell.base.8 Sat Mar 12 12:30:35 2022
--- work/functions/shell.log.8  Sat Mar 12 12:30:35 2022
***
*** 1 
! 127: /bin/sh: bad-command:  not found.
--- 1 
! 127: /bin/sh: bad-command:  not found



$ LANG=en_US /bin/sh -c 'bad-command'
/bin/sh: bad-command:  not found.
$ LANG= /bin/sh -c 'bad-command'
/bin/sh: bad-command:  not found





___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/